diff mbox

[FFmpeg-devel,2/2] avfilter/vf_lut3d: increase max level to upper limit defined by cube format specification

Message ID 20191025092749.26389-2-onemda@gmail.com
State Accepted
Commit a2210f10d37e890eefa1f94a5528ac69fa1515d2
Headers show

Commit Message

Paul B Mahol Oct. 25, 2019, 9:27 a.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavfilter/vf_lut3d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Clément Bœsch Oct. 25, 2019, 8:18 p.m. UTC | #1 
On Fri, Oct 25, 2019 at 11:27:49AM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavfilter/vf_lut3d.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
> index 8ef1bb7385..edaf9a711e 100644
> --- a/libavfilter/vf_lut3d.c
> +++ b/libavfilter/vf_lut3d.c
> @@ -55,7 +55,7 @@ struct rgbvec {
>  
>  /* 3D LUT don't often go up to level 32, but it is common to have a Hald CLUT
>   * of 512x512 (64x64x64) */
> -#define MAX_LEVEL 128
> +#define MAX_LEVEL 256
>  

Fine with me either way but do we actually need a hard limit anymore?
Paul B Mahol Oct. 25, 2019, 8:39 p.m. UTC | #2 
On 10/25/19, Clément Bœsch <u@pkh.me> wrote:
> On Fri, Oct 25, 2019 at 11:27:49AM +0200, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda@gmail.com>
>> ---
>>  libavfilter/vf_lut3d.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
>> index 8ef1bb7385..edaf9a711e 100644
>> --- a/libavfilter/vf_lut3d.c
>> +++ b/libavfilter/vf_lut3d.c
>> @@ -55,7 +55,7 @@ struct rgbvec {
>>
>>  /* 3D LUT don't often go up to level 32, but it is common to have a Hald
>> CLUT
>>   * of 512x512 (64x64x64) */
>> -#define MAX_LEVEL 128
>> +#define MAX_LEVEL 256
>>
>
> Fine with me either way but do we actually need a hard limit anymore?
>

Sane maximum does not hurt.

> --
> Clément B.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
index 8ef1bb7385..edaf9a711e 100644
--- a/libavfilter/vf_lut3d.c
+++ b/libavfilter/vf_lut3d.c
@@ -55,7 +55,7 @@  struct rgbvec {
 
 /* 3D LUT don't often go up to level 32, but it is common to have a Hald CLUT
  * of 512x512 (64x64x64) */
-#define MAX_LEVEL 128
+#define MAX_LEVEL 256
 
 typedef struct LUT3DContext {
     const AVClass *class;