diff mbox

[FFmpeg-devel] avfilter/avf_showfreqs: free input frame after using it

Message ID 20191026042456.1924-1-jamrial@gmail.com
State Accepted
Commit 1aa4fc1ec204fabed5c40873b86751976167272f
Headers show

Commit Message

James Almer Oct. 26, 2019, 4:24 a.m. UTC 
Fixes ticket #8336.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavfilter/avf_showfreqs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul B Mahol Oct. 26, 2019, 7:31 a.m. UTC | #1 
LGTM

On 10/26/19, James Almer <jamrial@gmail.com> wrote:
> Fixes ticket #8336.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavfilter/avf_showfreqs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
> index c44ac564ac..645754ded3 100644
> --- a/libavfilter/avf_showfreqs.c
> +++ b/libavfilter/avf_showfreqs.c
> @@ -475,6 +475,7 @@ static int activate(AVFilterContext *ctx)
>          av_audio_fifo_write(s->fifo, (void **)in->extended_data,
> in->nb_samples);
>          if (s->pts == AV_NOPTS_VALUE)
>              s->pts = in->pts;
> +        av_frame_free(&in);
>      }
>
>      if (av_audio_fifo_size(s->fifo) >= s->win_size) {
> --
> 2.23.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
James Almer Oct. 26, 2019, 1:17 p.m. UTC | #2 
On 10/26/2019 4:31 AM, Paul B Mahol wrote:
> LGTM
> 
> On 10/26/19, James Almer <jamrial@gmail.com> wrote:
>> Fixes ticket #8336.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavfilter/avf_showfreqs.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
>> index c44ac564ac..645754ded3 100644
>> --- a/libavfilter/avf_showfreqs.c
>> +++ b/libavfilter/avf_showfreqs.c
>> @@ -475,6 +475,7 @@ static int activate(AVFilterContext *ctx)
>>          av_audio_fifo_write(s->fifo, (void **)in->extended_data,
>> in->nb_samples);
>>          if (s->pts == AV_NOPTS_VALUE)
>>              s->pts = in->pts;
>> +        av_frame_free(&in);
>>      }
>>
>>      if (av_audio_fifo_size(s->fifo) >= s->win_size) {
>> --
>> 2.23.0

Applied, thanks.
diff mbox

Patch

diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
index c44ac564ac..645754ded3 100644
--- a/libavfilter/avf_showfreqs.c
+++ b/libavfilter/avf_showfreqs.c
@@ -475,6 +475,7 @@  static int activate(AVFilterContext *ctx)
         av_audio_fifo_write(s->fifo, (void **)in->extended_data, in->nb_samples);
         if (s->pts == AV_NOPTS_VALUE)
             s->pts = in->pts;
+        av_frame_free(&in);
     }
 
     if (av_audio_fifo_size(s->fifo) >= s->win_size) {