diff mbox

[FFmpeg-devel,v1,2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

Message ID 20191104111001.6426-2-lance.lmwang@gmail.com
State Accepted
Commit 2d17f43fe1958de338530c0b03b8d5de397a8e72
Headers show

Commit Message

Lance Wang Nov. 4, 2019, 11:10 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

It's based on the following specs:
RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 doc/bitstream_filters.texi       | 2 ++
 libavcodec/prores_metadata_bsf.c | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Lance Wang Nov. 15, 2019, 3:01 p.m. UTC | #1 
ping, the patchset is for HDR/HLG color support for prores.

On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> It's based on the following specs:
> RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  doc/bitstream_filters.texi       | 2 ++
>  libavcodec/prores_metadata_bsf.c | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> index 8fe5b3ad75..e2de4fd4ed 100644
> --- a/doc/bitstream_filters.texi
> +++ b/doc/bitstream_filters.texi
> @@ -589,6 +589,8 @@ Keep the same transfer characteristics property (default).
>  @item unknown
>  @item bt709
>  BT 601, BT 709, BT 2020
> +@item smpte2084
> +SMPTE ST 2084
>  @end table
>  
>  
> diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c
> index 0510d3520a..24615e9305 100644
> --- a/libavcodec/prores_metadata_bsf.c
> +++ b/libavcodec/prores_metadata_bsf.c
> @@ -140,10 +140,11 @@ static const AVOption options[] = {
>      {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>      {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>  
> -    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_BT709, FLAGS, "color_trc"},
> +    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},
>      {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
>      {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
>      {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
> +    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
>  
>      {"colorspace", "select colorspace", OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,  AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
>      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},
> -- 
> 2.21.0
>
Marton Balint May 3, 2020, 8:01 a.m. UTC | #2 
On Fri, 15 Nov 2019, Limin Wang wrote:

>
> ping, the patchset is for HDR/HLG color support for prores.
>
> On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmwang@gmail.com wrote:
>> From: Limin Wang <lance.lmwang@gmail.com>
>> 
>> It's based on the following specs:
>> RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process
>> 
>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>> ---
>>  doc/bitstream_filters.texi       | 2 ++
>>  libavcodec/prores_metadata_bsf.c | 3 ++-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
>> index 8fe5b3ad75..e2de4fd4ed 100644
>> --- a/doc/bitstream_filters.texi
>> +++ b/doc/bitstream_filters.texi
>> @@ -589,6 +589,8 @@ Keep the same transfer characteristics property (default).
>>  @item unknown
>>  @item bt709
>>  BT 601, BT 709, BT 2020
>> +@item smpte2084
>> +SMPTE ST 2084
>>  @end table
>>
>> 
>> diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c
>> index 0510d3520a..24615e9305 100644
>> --- a/libavcodec/prores_metadata_bsf.c
>> +++ b/libavcodec/prores_metadata_bsf.c
>> @@ -140,10 +140,11 @@ static const AVOption options[] = {
>>      {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>>      {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>> 
>> -    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_BT709, FLAGS, "color_trc"},
>> +    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},

NB-1.

>>      {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
>>      {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
>>      {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
>> +    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
>>
>>      {"colorspace", "select colorspace", OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,  AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
>>      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},

Yet again, please, do not apply patches which have not been LGTM-ed and 
you have not pinged them recently.

Thanks,
Marton
Lance Wang May 3, 2020, 12:47 p.m. UTC | #3 
On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote:
> 
> 
> On Fri, 15 Nov 2019, Limin Wang wrote:
> 
> > 
> > ping, the patchset is for HDR/HLG color support for prores.
> > 
> > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmwang@gmail.com wrote:
> > > From: Limin Wang <lance.lmwang@gmail.com>
> > > 
> > > It's based on the following specs:
> > > RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process
> > > 
> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > > ---
> > >  doc/bitstream_filters.texi       | 2 ++
> > >  libavcodec/prores_metadata_bsf.c | 3 ++-
> > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> > > index 8fe5b3ad75..e2de4fd4ed 100644
> > > --- a/doc/bitstream_filters.texi
> > > +++ b/doc/bitstream_filters.texi
> > > @@ -589,6 +589,8 @@ Keep the same transfer characteristics property (default).
> > >  @item unknown
> > >  @item bt709
> > >  BT 601, BT 709, BT 2020
> > > +@item smpte2084
> > > +SMPTE ST 2084
> > >  @end table
> > > 
> > > 
> > > diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c
> > > index 0510d3520a..24615e9305 100644
> > > --- a/libavcodec/prores_metadata_bsf.c
> > > +++ b/libavcodec/prores_metadata_bsf.c
> > > @@ -140,10 +140,11 @@ static const AVOption options[] = {
> > >      {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
> > >      {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
> > > 
> > > -    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_BT709, FLAGS, "color_trc"},
> > > +    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},
> 
> NB-1.
> 
> > >      {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > >      {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > >      {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > +    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > 
> > >      {"colorspace", "select colorspace", OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,  AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
> > >      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},
> 
> Yet again, please, do not apply patches which have not been LGTM-ed and you
> have not pinged them recently.
Sorry, I think I have ping before. Next time I'll try to ping again for the old patches
or resubmit.

> 
> Thanks,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Marton Balint May 3, 2020, 5:05 p.m. UTC | #4 
On Sun, 3 May 2020, lance.lmwang@gmail.com wrote:

> On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote:
>> 
>> 
>> On Fri, 15 Nov 2019, Limin Wang wrote:
>> 
>> > 
>> > ping, the patchset is for HDR/HLG color support for prores.
>> > 
>> > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmwang@gmail.com wrote:
>> > > From: Limin Wang <lance.lmwang@gmail.com>
>> > > 
>> > > It's based on the following specs:
>> > > RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process
>> > > 
>> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>> > > ---
>> > >  doc/bitstream_filters.texi       | 2 ++
>> > >  libavcodec/prores_metadata_bsf.c | 3 ++-
>> > >  2 files changed, 4 insertions(+), 1 deletion(-)
>> > > 
>> > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
>> > > index 8fe5b3ad75..e2de4fd4ed 100644
>> > > --- a/doc/bitstream_filters.texi
>> > > +++ b/doc/bitstream_filters.texi
>> > > @@ -589,6 +589,8 @@ Keep the same transfer characteristics property (default).
>> > >  @item unknown
>> > >  @item bt709
>> > >  BT 601, BT 709, BT 2020
>> > > +@item smpte2084
>> > > +SMPTE ST 2084
>> > >  @end table
>> > > 
>> > > 
>> > > diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c
>> > > index 0510d3520a..24615e9305 100644
>> > > --- a/libavcodec/prores_metadata_bsf.c
>> > > +++ b/libavcodec/prores_metadata_bsf.c
>> > > @@ -140,10 +140,11 @@ static const AVOption options[] = {
>> > >      {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>> > >      {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
>> > > 
>> > > -    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_BT709, FLAGS, "color_trc"},
>> > > +    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},
>> 
>> NB-1.
>> 
>> > >      {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
>> > >      {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
>> > >      {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
>> > > +    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
>> > > 
>> > >      {"colorspace", "select colorspace", OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,  AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
>> > >      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},
>> 
>> Yet again, please, do not apply patches which have not been LGTM-ed and you
>> have not pinged them recently.
> Sorry, I think I have ping before. Next time I'll try to ping again for the old patches
> or resubmit.

Ok, but please fix the maximum value I commented above. NB is not a valid 
maximum, NB-1 is.

Regards,
Marton
Lance Wang May 3, 2020, 9:47 p.m. UTC | #5 
On Sun, May 03, 2020 at 07:05:14PM +0200, Marton Balint wrote:
> 
> 
> On Sun, 3 May 2020, lance.lmwang@gmail.com wrote:
> 
> > On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote:
> > > 
> > > 
> > > On Fri, 15 Nov 2019, Limin Wang wrote:
> > > 
> > > > > ping, the patchset is for HDR/HLG color support for prores.
> > > > > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmwang@gmail.com
> > > wrote:
> > > > > From: Limin Wang <lance.lmwang@gmail.com>
> > > > > > > It's based on the following specs:
> > > > > RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitstream Syntax and Decoding Process
> > > > > > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > > > > ---
> > > > >  doc/bitstream_filters.texi       | 2 ++
> > > > >  libavcodec/prores_metadata_bsf.c | 3 ++-
> > > > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > > > > > diff --git a/doc/bitstream_filters.texi
> > > b/doc/bitstream_filters.texi
> > > > > index 8fe5b3ad75..e2de4fd4ed 100644
> > > > > --- a/doc/bitstream_filters.texi
> > > > > +++ b/doc/bitstream_filters.texi
> > > > > @@ -589,6 +589,8 @@ Keep the same transfer characteristics property (default).
> > > > >  @item unknown
> > > > >  @item bt709
> > > > >  BT 601, BT 709, BT 2020
> > > > > +@item smpte2084
> > > > > +SMPTE ST 2084
> > > > >  @end table
> > > > > > > > > diff --git a/libavcodec/prores_metadata_bsf.c
> > > b/libavcodec/prores_metadata_bsf.c
> > > > > index 0510d3520a..24615e9305 100644
> > > > > --- a/libavcodec/prores_metadata_bsf.c
> > > > > +++ b/libavcodec/prores_metadata_bsf.c
> > > > > @@ -140,10 +140,11 @@ static const AVOption options[] = {
> > > > >      {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
> > > > >      {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
> > > > > > > -    {"color_trc", "select color transfer",
> > > OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1,
> > > AVCOL_TRC_BT709, FLAGS, "color_trc"},
> > > > > +    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},
> > > 
> > > NB-1.
> > > 
> > > > >      {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > > >      {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > > >      {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > > > +    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
> > > > > > >      {"colorspace", "select colorspace",
> > > OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,
> > > AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
> > > > >      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},
> > > 
> > > Yet again, please, do not apply patches which have not been LGTM-ed and you
> > > have not pinged them recently.
> > Sorry, I think I have ping before. Next time I'll try to ping again for the old patches
> > or resubmit.
> 
> Ok, but please fix the maximum value I commented above. NB is not a valid
> maximum, NB-1 is.

Of course, Will submit a patch to fix it. 

> 
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index 8fe5b3ad75..e2de4fd4ed 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -589,6 +589,8 @@  Keep the same transfer characteristics property (default).
 @item unknown
 @item bt709
 BT 601, BT 709, BT 2020
+@item smpte2084
+SMPTE ST 2084
 @end table
 
 
diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c
index 0510d3520a..24615e9305 100644
--- a/libavcodec/prores_metadata_bsf.c
+++ b/libavcodec/prores_metadata_bsf.c
@@ -140,10 +140,11 @@  static const AVOption options[] = {
     {"smpte431",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE431},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
     {"smpte432",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_PRI_SMPTE432},     INT_MIN, INT_MAX, FLAGS, "color_primaries"},
 
-    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_BT709, FLAGS, "color_trc"},
+    {"color_trc", "select color transfer", OFFSET(transfer_characteristics), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_TRC_NB, FLAGS, "color_trc"},
     {"auto", "keep the same color transfer",  0, AV_OPT_TYPE_CONST, {.i64=-1},                               INT_MIN, INT_MAX, FLAGS, "color_trc"},
     {"unknown",                        NULL,  0, AV_OPT_TYPE_CONST, {.i64=0},                                INT_MIN, INT_MAX, FLAGS, "color_trc"},
     {"bt709",                          NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_BT709},                  INT_MIN, INT_MAX, FLAGS, "color_trc"},
+    {"smpte2084",                      NULL,  0, AV_OPT_TYPE_CONST, {.i64=AVCOL_TRC_SMPTE2084},              INT_MIN, INT_MAX, FLAGS, "color_trc"},
 
     {"colorspace", "select colorspace", OFFSET(matrix_coefficients), AV_OPT_TYPE_INT, {.i64=-1}, -1,  AVCOL_SPC_BT2020_NCL, FLAGS, "colorspace"},
     {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                            INT_MIN, INT_MAX, FLAGS, "colorspace"},