diff mbox

[FFmpeg-devel] avcodec/cbs_av1: avoid reading trailing bits when obu type is OBU_TILE_LIST

Message ID 20191210090100.3421-1-fei.w.wang@intel.com
State Accepted
Commit 1ea44178f5fff7eb600026a09a0ce7d477ed0240
Headers show

Commit Message

Fei Wang Dec. 10, 2019, 9:01 a.m. UTC
Signed-off-by: Wangfei <fei.w.wang@intel.com>
---
 libavcodec/cbs_av1.c | 1 +
 1 file changed, 1 insertion(+)

Comments

James Almer Dec. 10, 2019, 5:11 p.m. UTC | #1
On 12/10/2019 6:01 AM, Wangfei wrote:
> Signed-off-by: Wangfei <fei.w.wang@intel.com>

Could you fix your git configuration to use your full name instead? The
same you use in normal replies. I'll commit this after you resend this
patch with the fixed authorship.

> ---
>  libavcodec/cbs_av1.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c
> index bbe4461130..ab006f4d11 100644
> --- a/libavcodec/cbs_av1.c
> +++ b/libavcodec/cbs_av1.c
> @@ -1039,6 +1039,7 @@ static int cbs_av1_read_unit(CodedBitstreamContext *ctx,
>  
>      if (obu->obu_size > 0 &&
>          obu->header.obu_type != AV1_OBU_TILE_GROUP &&
> +        obu->header.obu_type != AV1_OBU_TILE_LIST &&
>          obu->header.obu_type != AV1_OBU_FRAME) {
>          int nb_bits = obu->obu_size * 8 + start_pos - end_pos;
Fei Wang Dec. 11, 2019, 1:44 a.m. UTC | #2
> -----Original Message-----

> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of

> James Almer

> Sent: Wednesday, December 11, 2019 1:11 AM

> To: ffmpeg-devel@ffmpeg.org

> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reading trailing

> bits when obu type is OBU_TILE_LIST

> 

> On 12/10/2019 6:01 AM, Wangfei wrote:

> > Signed-off-by: Wangfei <fei.w.wang@intel.com>

> 

> Could you fix your git configuration to use your full name instead? The same

> you use in normal replies. I'll commit this after you resend this patch with

> the fixed authorship.

Fixed in v2, please have a review. Thanks.
> 

> > ---

> >  libavcodec/cbs_av1.c | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index

> > bbe4461130..ab006f4d11 100644

> > --- a/libavcodec/cbs_av1.c

> > +++ b/libavcodec/cbs_av1.c

> > @@ -1039,6 +1039,7 @@ static int

> > cbs_av1_read_unit(CodedBitstreamContext *ctx,

> >

> >      if (obu->obu_size > 0 &&

> >          obu->header.obu_type != AV1_OBU_TILE_GROUP &&

> > +        obu->header.obu_type != AV1_OBU_TILE_LIST &&

> >          obu->header.obu_type != AV1_OBU_FRAME) {

> >          int nb_bits = obu->obu_size * 8 + start_pos - end_pos;

> _______________________________________________

> ffmpeg-devel mailing list

> ffmpeg-devel@ffmpeg.org

> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

> 

> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org

> with subject "unsubscribe".
diff mbox

Patch

diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c
index bbe4461130..ab006f4d11 100644
--- a/libavcodec/cbs_av1.c
+++ b/libavcodec/cbs_av1.c
@@ -1039,6 +1039,7 @@  static int cbs_av1_read_unit(CodedBitstreamContext *ctx,
 
     if (obu->obu_size > 0 &&
         obu->header.obu_type != AV1_OBU_TILE_GROUP &&
+        obu->header.obu_type != AV1_OBU_TILE_LIST &&
         obu->header.obu_type != AV1_OBU_FRAME) {
         int nb_bits = obu->obu_size * 8 + start_pos - end_pos;