diff mbox

[FFmpeg-devel] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

Message ID 1576164321-14926-1-git-send-email-linjie.fu@intel.com
State Superseded
Headers show

Commit Message

Fu, Linjie Dec. 12, 2019, 3:25 p.m. UTC
5 cabac states for cbf_cb and cbf_cr are supported according to
Table 9-4.

Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0.

Signedoff-by: Xu Guangxin <guangxin.xu@intel.com>
Signed-off-by: Linjie Fu <linjie.fu@intel.com>
---
 tests/fate/hevc.mak               | 3 +++
 tests/ref/fate/hevc-cabac-tudepth | 6 ++++++
 2 files changed, 9 insertions(+)
 create mode 100644 tests/ref/fate/hevc-cabac-tudepth

Comments

James Almer Dec. 12, 2019, 4:54 p.m. UTC | #1
On 12/12/2019 12:25 PM, Linjie Fu wrote:
> 5 cabac states for cbf_cb and cbf_cr are supported according to
> Table 9-4.
> 
> Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0.
> 
> Signedoff-by: Xu Guangxin <guangxin.xu@intel.com>
> Signed-off-by: Linjie Fu <linjie.fu@intel.com>
> ---
>  tests/fate/hevc.mak               | 3 +++
>  tests/ref/fate/hevc-cabac-tudepth | 6 ++++++
>  2 files changed, 9 insertions(+)
>  create mode 100644 tests/ref/fate/hevc-cabac-tudepth
> 
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index 559c389..bfef675 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -256,6 +256,9 @@ FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC) += fate-hevc-monochrome-crop
>  fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t 00:02.00 -an
>  FATE_HEVC-$(call DEMDEC, MOV, HEVC) += fate-hevc-two-first-slice
>  
> +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p
> +FATE_HEVC +=fate-hevc-cabac-tudepth

Either make this line

FATE_HEVC-$(call DEMDEC, HEVC, HEVC) += fate-hevc-cabac-tudepth

Or place this test right below the fate-hevc-skiploopfilter one.

> +
>  FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>  FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>  
> diff --git a/tests/ref/fate/hevc-cabac-tudepth b/tests/ref/fate/hevc-cabac-tudepth
> new file mode 100644
> index 0000000..ad874c3
> --- /dev/null
> +++ b/tests/ref/fate/hevc-cabac-tudepth
> @@ -0,0 +1,6 @@
> +#tb 0: 1/25
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 64x64
> +#sar 0: 0/1
> +0,          0,          0,        1,    12288, 0x0127a0d9
>
Fu, Linjie Dec. 13, 2019, 2:46 a.m. UTC | #2
Hi,

> -----Original Message-----

> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of

> James Almer

> Sent: Friday, December 13, 2019 00:55

> To: ffmpeg-devel@ffmpeg.org

> Subject: Re: [FFmpeg-devel] [PATCH] FATE: add test for hevc files with 4

> TUDepth(0..4) of cbf_cb/cbf_cr

> 

> On 12/12/2019 12:25 PM, Linjie Fu wrote:

> > 5 cabac states for cbf_cb and cbf_cr are supported according to

> > Table 9-4.

> >

> > Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0.

> >

> > Signedoff-by: Xu Guangxin <guangxin.xu@intel.com>

> > Signed-off-by: Linjie Fu <linjie.fu@intel.com>

> > ---

> >  tests/fate/hevc.mak               | 3 +++

> >  tests/ref/fate/hevc-cabac-tudepth | 6 ++++++

> >  2 files changed, 9 insertions(+)

> >  create mode 100644 tests/ref/fate/hevc-cabac-tudepth

> >

> > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak

> > index 559c389..bfef675 100644

> > --- a/tests/fate/hevc.mak

> > +++ b/tests/fate/hevc.mak

> > @@ -256,6 +256,9 @@ FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC)

> += fate-hevc-monochrome-crop

> >  fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i

> $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t

> 00:02.00 -an

> >  FATE_HEVC-$(call DEMDEC, MOV, HEVC) += fate-hevc-two-first-slice

> >

> > +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i

> $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p

> > +FATE_HEVC +=fate-hevc-cabac-tudepth

> 

> Either make this line

> 

> FATE_HEVC-$(call DEMDEC, HEVC, HEVC) += fate-hevc-cabac-tudepth

> 

> Or place this test right below the fate-hevc-skiploopfilter one.


Updated.
IMHO fate-hevc-paired-fields may need similar rearrangement?

thx,

- linjie
diff mbox

Patch

diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
index 559c389..bfef675 100644
--- a/tests/fate/hevc.mak
+++ b/tests/fate/hevc.mak
@@ -256,6 +256,9 @@  FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC) += fate-hevc-monochrome-crop
 fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t 00:02.00 -an
 FATE_HEVC-$(call DEMDEC, MOV, HEVC) += fate-hevc-two-first-slice
 
+fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p
+FATE_HEVC +=fate-hevc-cabac-tudepth
+
 FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
 FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
 
diff --git a/tests/ref/fate/hevc-cabac-tudepth b/tests/ref/fate/hevc-cabac-tudepth
new file mode 100644
index 0000000..ad874c3
--- /dev/null
+++ b/tests/ref/fate/hevc-cabac-tudepth
@@ -0,0 +1,6 @@ 
+#tb 0: 1/25
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 64x64
+#sar 0: 0/1
+0,          0,          0,        1,    12288, 0x0127a0d9