| Message ID | 1576204402-10303-1-git-send-email-linjie.fu@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
Am Fr., 13. Dez. 2019 um 03:43 Uhr schrieb Linjie Fu <linjie.fu@intel.com>: > 5 cabac states for cbf_cb and cbf_cr are supported according to > Table 9-4. > > Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. > +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p File name looks wrong to me... Carl Eugen
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Carl Eugen Hoyos > Sent: Friday, December 13, 2019 10:47 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 > TUDepth(0..4) of cbf_cb/cbf_cr > > Am Fr., 13. Dez. 2019 um 03:43 Uhr schrieb Linjie Fu <linjie.fu@intel.com>: > > > 5 cabac states for cbf_cb and cbf_cr are supported according to > > Table 9-4. > > > > Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. > > +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i > $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p > > File name looks wrong to me... > I renamed the clips to *.hevc and try to be consistent with other files in fate/hevc/. (If it's not strictly required, cbf_cr_cb_TUDepth_4_circle.h265 may be more straight forward and it has already been in fate-suite) -fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/cbf_cr_cb_TUDepth_4_circle.h265 -pix_fmt yuv444p Do I need to update this in a new version(v3)? - linjie
On 12/13/2019 4:05 AM, Fu, Linjie wrote: >> -----Original Message----- >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of >> Carl Eugen Hoyos >> Sent: Friday, December 13, 2019 10:47 >> To: FFmpeg development discussions and patches <ffmpeg- >> devel@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 >> TUDepth(0..4) of cbf_cb/cbf_cr >> >> Am Fr., 13. Dez. 2019 um 03:43 Uhr schrieb Linjie Fu <linjie.fu@intel.com>: >> >>> 5 cabac states for cbf_cb and cbf_cr are supported according to >>> Table 9-4. >>> >>> Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. >>> +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i >> $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p >> >> File name looks wrong to me... >> > I renamed the clips to *.hevc and try to be consistent with other files in fate/hevc/. > > (If it's not strictly required, cbf_cr_cb_TUDepth_4_circle.h265 may be more straight > forward and it has already been in fate-suite) That's the name the sample has in the fate-suite already, so no reason to change it. Especially if it's the better name. > > -fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p > +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/cbf_cr_cb_TUDepth_4_circle.h265 -pix_fmt yuv444p > > Do I need to update this in a new version(v3)? Yes, please. > > - linjie > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 559c389..1dc7841 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -256,6 +256,9 @@ FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC) += fate-hevc-monochrome-crop fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t 00:02.00 -an FATE_HEVC-$(call DEMDEC, MOV, HEVC) += fate-hevc-two-first-slice +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p +FATE_HEVC-$(call DEMDEC, HEVC, HEVC) += fate-hevc-cabac-tudepth + FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes) FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes) diff --git a/tests/ref/fate/hevc-cabac-tudepth b/tests/ref/fate/hevc-cabac-tudepth new file mode 100644 index 0000000..ad874c3 --- /dev/null +++ b/tests/ref/fate/hevc-cabac-tudepth @@ -0,0 +1,6 @@ +#tb 0: 1/25 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 64x64 +#sar 0: 0/1 +0, 0, 0, 1, 12288, 0x0127a0d9