diff mbox

[FFmpeg-devel] avcodec/simple_idct_template: fix integer overflow

Message ID 20191213142217.25352-1-onemda@gmail.com
State Accepted
Commit 24424a6516f8adc4c73a2fe00fa106b0e49abafd
Headers show

Commit Message

Paul B Mahol Dec. 13, 2019, 2:22 p.m. UTC 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
---
 libavcodec/simple_idct_template.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Dec. 13, 2019, 10:11 p.m. UTC | #1 
On Fri, Dec 13, 2019 at 03:22:17PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/simple_idct_template.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/simple_idct_template.c b/libavcodec/simple_idct_template.c
index d8fcfd7c53..5ddd0b45a2 100644
--- a/libavcodec/simple_idct_template.c
+++ b/libavcodec/simple_idct_template.c
@@ -121,7 +121,7 @@  static inline void FUNC6(idctRowCondDC)(idctin *row, int extra_shift)
 // TODO: Add DC-only support for int32_t input
 #if IN_IDCT_DEPTH == 16
 #if HAVE_FAST_64BIT
-#define ROW0_MASK (0xffffLL << 48 * HAVE_BIGENDIAN)
+#define ROW0_MASK (0xffffULL << 48 * HAVE_BIGENDIAN)
     if (((AV_RN64A(row) & ~ROW0_MASK) | AV_RN64A(row+4)) == 0) {
         uint64_t temp;
         if (DC_SHIFT - extra_shift >= 0) {