| Message ID | 20191218211700.17359-1-wonkap@google.com |
|---|---|
| State | Accepted |
| Commit | a86bb2f606da64d287b1dd807a4f691c39f1a1ec |
| Headers | show |
Hi, On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang <wonkap-at-google.com@ffmpeg.org> wrote: > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > and modifies the example to match the description. > --- > doc/encoders.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > lgtm if you can verify that with the libvpx implementation and update the docs [1]. [1] https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646
Hi James, I have updated the libvpx. https://chromium-review.googlesource.com/c/webm/libvpx/+/1974899 Thank you, Wonkap On Wed, Dec 18, 2019 at 1:39 PM James Zern <jzern-at-google.com@ffmpeg.org> wrote: > Hi, > > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang > <wonkap-at-google.com@ffmpeg.org> wrote: > > > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > > and modifies the example to match the description. > > --- > > doc/encoders.texi | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > lgtm if you can verify that with the libvpx implementation and update > the docs [1]. > > [1] > https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Hi, On Wed, Dec 18, 2019 at 2:00 PM Wonkap Jang <wonkap-at-google.com@ffmpeg.org> wrote: > > Hi James, > > I have updated the libvpx. > https://chromium-review.googlesource.com/c/webm/libvpx/+/1974899 > Thanks for posting the patch. Remember top-posting isn't preferred on this mailing list [1]. [1] http://ffmpeg.org/contact.html#MailingLists > Thank you, > > Wonkap > > On Wed, Dec 18, 2019 at 1:39 PM James Zern <jzern-at-google.com@ffmpeg.org> > wrote: > > > Hi, > > > > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang > > <wonkap-at-google.com@ffmpeg.org> wrote: > > > > > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > > > and modifies the example to match the description. > > > --- > > > doc/encoders.texi | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > lgtm if you can verify that with the libvpx implementation and update > > the docs [1]. > > > > [1] > > https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646 > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Wed, Dec 18, 2019 at 4:17 PM Wonkap Jang <wonkap-at-google.com@ffmpeg.org> wrote: > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > and modifies the example to match the description. > --- > doc/encoders.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > applied, thanks.
diff --git a/doc/encoders.texi b/doc/encoders.texi index 4ee518a124..a207363650 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1893,7 +1893,7 @@ key=value pairs. For example, to specify temporal scalability parameters with @code{ffmpeg}: @example ffmpeg -i INPUT -c:v libvpx -ts-parameters ts_number_layers=3:\ -ts_target_bitrate=250000,500000,1000000:ts_rate_decimator=4,2,1:\ +ts_target_bitrate=250,500,1000:ts_rate_decimator=4,2,1:\ ts_periodicity=4:ts_layer_id=0,2,1,2 OUTPUT @end example Below is a brief explanation of each of the parameters, please @@ -1903,7 +1903,8 @@ details. @item ts_number_layers Number of temporal coding layers. @item ts_target_bitrate -Target bitrate for each temporal layer. +Target bitrate for each temporal layer (in kbps). +(bitrate should be inclusive of the lower temporal layer). @item ts_rate_decimator Frame rate decimation factor for each temporal layer. @item ts_periodicity