| Message ID | 20200227053351.26785-2-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avformat/ivfenc: Don't use size_t for size of file | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Thursday, February 27, 2020 13:34 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/cdtoons: Remove > superfluous ; > > The second ; in a double ;; is actually a null statement. It triggers > the typical declaration-after-statement compiler-warnings if it occurs > in the middle of several declarations (like here). > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavcodec/cdtoons.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c > index d5dce6351f..13f9a60f0f 100644 > --- a/libavcodec/cdtoons.c > +++ b/libavcodec/cdtoons.c > @@ -61,7 +61,7 @@ static int cdtoons_render_sprite(AVCodecContext > *avctx, const uint8_t *data, > { > CDToonsContext *c = avctx->priv_data; > const uint8_t *next_line = data; > - const uint8_t *end = data + data_size;; > + const uint8_t *end = data + data_size; > uint16_t line_size; > uint8_t *dest; > int skip = 0, to_skip, x; > -- lgtm, same issue exists in vf_cas.c maybe could be fixed in one commit. libavfilter/vf_cas.c:61: const int w1 = w - 1;; libavfilter/vf_cas.c:128: const int w1 = w - 1;; - Linjie
On Thu, Feb 27, 2020 at 06:15:26AM +0000, Fu, Linjie wrote: > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > > Andreas Rheinhardt > > Sent: Thursday, February 27, 2020 13:34 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > > Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/cdtoons: Remove > > superfluous ; > > > > The second ; in a double ;; is actually a null statement. It triggers > > the typical declaration-after-statement compiler-warnings if it occurs > > in the middle of several declarations (like here). > > > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > > --- > > libavcodec/cdtoons.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c > > index d5dce6351f..13f9a60f0f 100644 > > --- a/libavcodec/cdtoons.c > > +++ b/libavcodec/cdtoons.c > > @@ -61,7 +61,7 @@ static int cdtoons_render_sprite(AVCodecContext > > *avctx, const uint8_t *data, > > { > > CDToonsContext *c = avctx->priv_data; > > const uint8_t *next_line = data; > > - const uint8_t *end = data + data_size;; > > + const uint8_t *end = data + data_size; > > uint16_t line_size; > > uint8_t *dest; > > int skip = 0, to_skip, x; > > -- > > lgtm, same issue exists in vf_cas.c maybe could be fixed in one commit. will apply, dont see a reason why not to apply. thx [...]
diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c index d5dce6351f..13f9a60f0f 100644 --- a/libavcodec/cdtoons.c +++ b/libavcodec/cdtoons.c @@ -61,7 +61,7 @@ static int cdtoons_render_sprite(AVCodecContext *avctx, const uint8_t *data, { CDToonsContext *c = avctx->priv_data; const uint8_t *next_line = data; - const uint8_t *end = data + data_size;; + const uint8_t *end = data + data_size; uint16_t line_size; uint8_t *dest; int skip = 0, to_skip, x;
The second ; in a double ;; is actually a null statement. It triggers the typical declaration-after-statement compiler-warnings if it occurs in the middle of several declarations (like here). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavcodec/cdtoons.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)