| Message ID | 20200314063050.629-1-ffmpeg@gyani.pro |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel] web/download: update min. kernel version for linux binaries | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | warning | Failed to apply patch |
Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > > As per https://johnvansickle.com/ffmpeg/ > --- > src/download | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/download b/src/download > index 6292a7e..d9155ee 100644 > --- a/src/download > +++ b/src/download > @@ -70,7 +70,7 @@ > <h3>Linux Static Builds</h3> > <div class="list-group"> > <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and > - 64-bit for kernel 2.6.32 and above</a> > + 64-bit for kernel 3.2.0 and above</a> Shouldn't we instead remove the line? Carl Eugen
On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: > Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >> As per https://johnvansickle.com/ffmpeg/ >> --- >> src/download | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/download b/src/download >> index 6292a7e..d9155ee 100644 >> --- a/src/download >> +++ b/src/download >> @@ -70,7 +70,7 @@ >> <h3>Linux Static Builds</h3> >> <div class="list-group"> >> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and >> - 64-bit for kernel 2.6.32 and above</a> >> + 64-bit for kernel 3.2.0 and above</a> > Shouldn't we instead remove the line? Why? Gyan
Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > > > > On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: > > Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >> As per https://johnvansickle.com/ffmpeg/ > >> --- > >> src/download | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/src/download b/src/download > >> index 6292a7e..d9155ee 100644 > >> --- a/src/download > >> +++ b/src/download > >> @@ -70,7 +70,7 @@ > >> <h3>Linux Static Builds</h3> > >> <div class="list-group"> > >> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and > >> - 64-bit for kernel 2.6.32 and above</a> > >> + 64-bit for kernel 3.2.0 and above</a> > > Shouldn't we instead remove the line? > > Why? Because we cannot know which kernel version the binaries currently require and because people with ancient kernels probably won't download current FFmpeg. Are we mentioning that the Zeranoe binaries do not work on XP? Carl Eugen
On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: > Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >> >> >> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: >>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>> As per https://johnvansickle.com/ffmpeg/ >>>> --- >>>> src/download | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/src/download b/src/download >>>> index 6292a7e..d9155ee 100644 >>>> --- a/src/download >>>> +++ b/src/download >>>> @@ -70,7 +70,7 @@ >>>> <h3>Linux Static Builds</h3> >>>> <div class="list-group"> >>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and >>>> - 64-bit for kernel 2.6.32 and above</a> >>>> + 64-bit for kernel 3.2.0 and above</a> >>> Shouldn't we instead remove the line? >> Why? > Because we cannot know which kernel version the binaries currently require We know, because the provider mentions it. > Are we mentioning that the Zeranoe binaries do not work on XP? Or on Vista, as mentioned by the provider. That should be noted. As long as the qualifications don't get too verbose, no harm in adding/maintaining the practice. Gyan
Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > > > > On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: > > Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >> > >> > >> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: > >>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>> As per https://johnvansickle.com/ffmpeg/ > >>>> --- > >>>> src/download | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/src/download b/src/download > >>>> index 6292a7e..d9155ee 100644 > >>>> --- a/src/download > >>>> +++ b/src/download > >>>> @@ -70,7 +70,7 @@ > >>>> <h3>Linux Static Builds</h3> > >>>> <div class="list-group"> > >>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and > >>>> - 64-bit for kernel 2.6.32 and above</a> > >>>> + 64-bit for kernel 3.2.0 and above</a> > >>> Shouldn't we instead remove the line? > >> Why? > > Because we cannot know which kernel version the binaries currently require > > We know, because the provider mentions it. > > > Are we mentioning that the Zeranoe binaries do not work on XP? > > Or on Vista, as mentioned by the provider. That should be noted. > > As long as the qualifications don't get too verbose, no harm in > adding/maintaining the practice. I believe it is better if Zeranoe and johnvansickle mention it, we should remove the existing line. Carl Eugen
On 14-03-2020 07:15 pm, Carl Eugen Hoyos wrote: > Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >> >> >> On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: >>> Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>> >>>> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: >>>>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>>>> As per https://johnvansickle.com/ffmpeg/ >>>>>> --- >>>>>> src/download | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/src/download b/src/download >>>>>> index 6292a7e..d9155ee 100644 >>>>>> --- a/src/download >>>>>> +++ b/src/download >>>>>> @@ -70,7 +70,7 @@ >>>>>> <h3>Linux Static Builds</h3> >>>>>> <div class="list-group"> >>>>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and >>>>>> - 64-bit for kernel 2.6.32 and above</a> >>>>>> + 64-bit for kernel 3.2.0 and above</a> >>>>> Shouldn't we instead remove the line? >>>> Why? >>> Because we cannot know which kernel version the binaries currently require >> We know, because the provider mentions it. >> >>> Are we mentioning that the Zeranoe binaries do not work on XP? >> Or on Vista, as mentioned by the provider. That should be noted. >> >> As long as the qualifications don't get too verbose, no harm in >> adding/maintaining the practice. > I believe it is better if Zeranoe and johnvansickle mention it, we > should remove the existing line. They already so. So have we, for some years now. Why haven't you removed it yet? In any case, the current line is wrong. So it has to be either updated or removed. I propose updating it. Gyan
Am Mi., 18. März 2020 um 07:04 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > > On 14-03-2020 07:15 pm, Carl Eugen Hoyos wrote: > > Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >> > >> On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: > >>> Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>> > >>>> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: > >>>>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>>>> As per https://johnvansickle.com/ffmpeg/ > >>>>>> --- > >>>>>> src/download | 2 +- > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/src/download b/src/download > >>>>>> index 6292a7e..d9155ee 100644 > >>>>>> --- a/src/download > >>>>>> +++ b/src/download > >>>>>> @@ -70,7 +70,7 @@ > >>>>>> <h3>Linux Static Builds</h3> > >>>>>> <div class="list-group"> > >>>>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and > >>>>>> - 64-bit for kernel 2.6.32 and above</a> > >>>>>> + 64-bit for kernel 3.2.0 and above</a> > >>>>> Shouldn't we instead remove the line? > >>>> Why? > >>> Because we cannot know which kernel version the binaries currently require > >> We know, because the provider mentions it. I should probably mention that I don't think this was a very useful comment. > >>> Are we mentioning that the Zeranoe binaries do not work on XP? > >> Or on Vista, as mentioned by the provider. That should be noted. > >> > >> As long as the qualifications don't get too verbose, no harm in > >> adding/maintaining the practice. > > I believe it is better if Zeranoe and johnvansickle mention it, we > > should remove the existing line. > > They already so. So have we, for some years now. Why haven't > you removed it yet? Why haven't you fixed a few user-reported bugs lately? Sorry, I really don't understand your question. > In any case, the current line is wrong. So it has to be either updated > or removed. I propose updating it. You know how much I hate the word here but the "cleaner" solution to me seems to simply remove the mentioning of the kernel. Carl Eugen
On 18-03-2020 02:44 pm, Carl Eugen Hoyos wrote: > Am Mi., 18. März 2020 um 07:04 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >> On 14-03-2020 07:15 pm, Carl Eugen Hoyos wrote: >>> Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>> On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: >>>>> Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>>>> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: >>>>>>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: >>>>>>>> As per https://johnvansickle.com/ffmpeg/ >>>>>>>> --- >>>>>>>> src/download | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/src/download b/src/download >>>>>>>> index 6292a7e..d9155ee 100644 >>>>>>>> --- a/src/download >>>>>>>> +++ b/src/download >>>>>>>> @@ -70,7 +70,7 @@ >>>>>>>> <h3>Linux Static Builds</h3> >>>>>>>> <div class="list-group"> >>>>>>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and >>>>>>>> - 64-bit for kernel 2.6.32 and above</a> >>>>>>>> + 64-bit for kernel 3.2.0 and above</a> >>>>>>> Shouldn't we instead remove the line? >>>>>> Why? >>>>> Because we cannot know which kernel version the binaries currently require >>>> We know, because the provider mentions it. > I should probably mention that I don't think this was a very useful comment. > >>>>> Are we mentioning that the Zeranoe binaries do not work on XP? >>>> Or on Vista, as mentioned by the provider. That should be noted. >>>> >>>> As long as the qualifications don't get too verbose, no harm in >>>> adding/maintaining the practice. >>> I believe it is better if Zeranoe and johnvansickle mention it, we >>> should remove the existing line. >> They already so. So have we, for some years now. Why haven't >> you removed it yet? > Why haven't you fixed a few user-reported bugs lately? > Sorry, I really don't understand your question. The current practice if mentioning kernel/OS thresholds has been in place for some years now. You apparently have a problem with it. YAnd you haven't pushed a patch to remove it. Why now? >> In any case, the current line is wrong. So it has to be either updated >> or removed. I propose updating it. > You know how much I hate the word here but the "cleaner" solution > to me seems to simply remove the mentioning of the kernel. Do you want to remove the OS versions from Mac/Win links as well? Gyan
Am Mi., 18. März 2020 um 12:34 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > > > > On 18-03-2020 02:44 pm, Carl Eugen Hoyos wrote: > > Am Mi., 18. März 2020 um 07:04 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >> On 14-03-2020 07:15 pm, Carl Eugen Hoyos wrote: > >>> Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>> On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote: > >>>>> Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>>>> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote: > >>>>>>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi <ffmpeg@gyani.pro>: > >>>>>>>> As per https://johnvansickle.com/ffmpeg/ > >>>>>>>> --- > >>>>>>>> src/download | 2 +- > >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>>>> > >>>>>>>> diff --git a/src/download b/src/download > >>>>>>>> index 6292a7e..d9155ee 100644 > >>>>>>>> --- a/src/download > >>>>>>>> +++ b/src/download > >>>>>>>> @@ -70,7 +70,7 @@ > >>>>>>>> <h3>Linux Static Builds</h3> > >>>>>>>> <div class="list-group"> > >>>>>>>> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and > >>>>>>>> - 64-bit for kernel 2.6.32 and above</a> > >>>>>>>> + 64-bit for kernel 3.2.0 and above</a> > >>>>>>> Shouldn't we instead remove the line? > >>>>>> Why? > >>>>> Because we cannot know which kernel version the binaries currently require > >>>> We know, because the provider mentions it. > > I should probably mention that I don't think this was a very useful comment. > > > >>>>> Are we mentioning that the Zeranoe binaries do not work on XP? > >>>> Or on Vista, as mentioned by the provider. That should be noted. > >>>> > >>>> As long as the qualifications don't get too verbose, no harm in > >>>> adding/maintaining the practice. > >>> I believe it is better if Zeranoe and johnvansickle mention it, we > >>> should remove the existing line. > >> They already so. So have we, for some years now. Why haven't > >> you removed it yet? > > Why haven't you fixed a few user-reported bugs lately? > > Sorry, I really don't understand your question. > > The current practice if mentioning kernel/OS thresholds has been in > place for some years now. You apparently have a problem with it. YAnd > you haven't pushed a patch to remove it. Why now? I can only repeat: Imo, this is not a very constructive question. > >> In any case, the current line is wrong. So it has to be either updated > >> or removed. I propose updating it. > > You know how much I hate the word here but the "cleaner" solution > > to me seems to simply remove the mentioning of the kernel. > > Do you want to remove the OS versions from Mac/Win links as well? An alternative would be to mention non-supported kernel and os versions (instead of supported). Carl Eugen
On Fri, Mar 13, 2020, at 10:30 PM, Gyan Doshi wrote: > As per https://johnvansickle.com/ffmpeg/ > --- > src/download | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM
On 18-03-2020 10:38 pm, Lou Logan wrote: > On Fri, Mar 13, 2020, at 10:30 PM, Gyan Doshi wrote: >> As per https://johnvansickle.com/ffmpeg/ >> --- >> src/download | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > LGTM Thanks. Can you push this? Gyan
On Wed, Mar 18, 2020, at 10:05 PM, Gyan Doshi wrote:
> Thanks. Can you push this?
Sure, I’ll be able push it in about 12 hours or so.
On Wed, Mar 18, 2020, at 10:39 PM, Lou Logan wrote:
> Sure, I’ll be able push it in about 12 hours or so.
Pushed
Am Do., 19. März 2020 um 20:00 Uhr schrieb Lou Logan <lou@lrcd.com>: > > On Wed, Mar 18, 2020, at 10:39 PM, Lou Logan wrote: > > Sure, I’ll be able push it in about 12 hours or so. > > Pushed How good to know that all comments are taken seriously on this mailing list. Carl Eugen
On Thu, Mar 19, 2020, at 3:07 PM, Carl Eugen Hoyos wrote: > > How good to know that all comments are taken seriously on this > mailing list. Gyan took the initiative to update the description with a trivial, very minor, insignificant patch. It was a simple improvement and seemed fine to me. If it were my patch I would have pushed it without posting it to the mailing list. Perhaps you would have too. Applying Gyan's patch was more logical than doing nothing and leaving the kernel info outdated; which is what I believe would have happened if I didn't apply it. That would have been the worst choice. Feel free to submit a patch that eliminates the kernel version if you feel so strongly about it. I don't think anybody really cares one way or another. The important part is that the wrong info is no longer there. This has already taken up way too much time, but unfortunately I believe it will take up more.
diff --git a/src/download b/src/download index 6292a7e..d9155ee 100644 --- a/src/download +++ b/src/download @@ -70,7 +70,7 @@ <h3>Linux Static Builds</h3> <div class="list-group"> <a class="list-group-item" href="https://johnvansickle.com/ffmpeg/">32-bit and - 64-bit for kernel 2.6.32 and above</a> + 64-bit for kernel 3.2.0 and above</a> </div> <!-- list-group --> </div> <!-- build -->