diff mbox series

[FFmpeg-devel] movenc: mark Opus encapsulation as stable

Message ID M38RtpE--3-2@lynne.ee
State Accepted
Headers show
Series [FFmpeg-devel] movenc: mark Opus encapsulation as stable | expand

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Lynne March 23, 2020, 10:11 p.m. UTC 
The specifications are de-facto frozen now as they've already been used in
production for years now, the author has indicated reluctance on IRC to change
it further, and the only potential changes would, from what I understand, be
forward-compatible.

Patch attached.

Comments

Derek Buitenhuis March 23, 2020, 10:56 p.m. UTC | #1 
On 23/03/2020 22:11, Lynne wrote:
> The specifications are de-facto frozen now as they've already been used in
> production for years now, the author has indicated reluctance on IRC to change
> it further, and the only potential changes would, from what I understand, be
> forward-compatible.

+1 from me for all the same reasons.

I am actually surprised it was still marked as experimental.

- Derek
diff mbox series

Patch

From c8d4d5a3d7aeaddabb9e14bcf5816f3b1a7a3290 Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Mon, 23 Mar 2020 22:03:24 +0000
Subject: [PATCH] movenc: mark Opus encapsulation as stable

The specifications are de-facto frozen now as they've already been used in
production for years now, the author has indicated reluctance on IRC to change
it further, and the only potential changes would, from what I understand, be
forward-compatible.
---
 libavformat/movenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 85df5d1374..4e56a7df46 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -6500,7 +6500,8 @@  static int mov_init(AVFormatContext *s)
                     av_log(s, AV_LOG_ERROR, "%s only supported in MP4.\n", avcodec_get_name(track->par->codec_id));
                     return AVERROR(EINVAL);
                 }
-                if (s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
+                if (track->par->codec_id != AV_CODEC_ID_OPUS &&
+                    s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
                     av_log(s, AV_LOG_ERROR,
                            "%s in MP4 support is experimental, add "
                            "'-strict %d' if you want to use it.\n",
-- 
2.26.0.rc2