diff mbox

[FFmpeg-devel,1/3] tests: print errors from ffserver

Message ID 3d7233eb-5e4c-40dd-ac75-7f1981064872@googlemail.com
State Accepted
Commit 0bd227e31ca769c1403ec3df9272d008fa5985c6
Headers show

Commit Message

Andreas Cadhalpun Nov. 30, 2016, 1:27 a.m. UTC
Not doing so makes debugging unnecessarily hard.

Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
---
 tests/ffserver-regression.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Nov. 30, 2016, 3:42 a.m. UTC | #1
On Wed, Nov 30, 2016 at 02:27:12AM +0100, Andreas Cadhalpun wrote:
> Not doing so makes debugging unnecessarily hard.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> ---
>  tests/ffserver-regression.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

i agree, i did the same mysef locally

[...]
Reynaldo H. Verdejo Pinochet Nov. 30, 2016, 7:22 a.m. UTC | #2
The entire set looks good to go. Please feel free to push.

Thank you!


On 11/29/2016 05:27 PM, Andreas Cadhalpun wrote:
> Not doing so makes debugging unnecessarily hard.
>
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> ---
>   tests/ffserver-regression.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ffserver-regression.sh b/tests/ffserver-regression.sh
> index b776bad..47d6016 100755
> --- a/tests/ffserver-regression.sh
> +++ b/tests/ffserver-regression.sh
> @@ -12,7 +12,7 @@ target_path=$5
>   FILES=$(sed -n 's/^[^#]*<Stream \(.*\)>.*/\1/p' $2 | grep -v html)
>   
>   rm -f tests/feed1.ffm
> -$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" 2> /dev/null &
> +$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" &
>   FFSERVER_PID=$!
>   echo "Waiting for feeds to startup..."
>   sleep 2
Andreas Cadhalpun Nov. 30, 2016, 9:40 p.m. UTC | #3
On 30.11.2016 08:22, Reynaldo H. Verdejo Pinochet wrote:
> The entire set looks good to go. Please feel free to push.

Pushed.

> Thank you!

You're welcome. ;)

Best regards,
Andreas
diff mbox

Patch

diff --git a/tests/ffserver-regression.sh b/tests/ffserver-regression.sh
index b776bad..47d6016 100755
--- a/tests/ffserver-regression.sh
+++ b/tests/ffserver-regression.sh
@@ -12,7 +12,7 @@  target_path=$5
 FILES=$(sed -n 's/^[^#]*<Stream \(.*\)>.*/\1/p' $2 | grep -v html)
 
 rm -f tests/feed1.ffm
-$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" 2> /dev/null &
+$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" &
 FFSERVER_PID=$!
 echo "Waiting for feeds to startup..."
 sleep 2