| Message ID | 20200418005721.31951-1-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Commit | 4bbf2a240fb5b59eaa8aef09514a96f4395c155d |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/truehd_core_bsf: Remove unused AVClass pointer | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
On 4/17/2020 9:57 PM, Andreas Rheinhardt wrote: > The context structure of the truehd_core bsf had a pointer to a const > AVClass as its first member; yet this bsf does not have any AVClass > associated with it, so that this pointer is always NULL. So remove it. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavcodec/truehd_core_bsf.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/truehd_core_bsf.c b/libavcodec/truehd_core_bsf.c > index dbd05b34ca..dfe291d9e9 100644 > --- a/libavcodec/truehd_core_bsf.c > +++ b/libavcodec/truehd_core_bsf.c > @@ -31,8 +31,6 @@ typedef struct AccessUnit { > } AccessUnit; > > typedef struct TrueHDCoreContext { > - const AVClass *class; > - > MLPHeaderInfo hdr; > } TrueHDCoreContext; LGTM
James Almer: > On 4/17/2020 9:57 PM, Andreas Rheinhardt wrote: >> The context structure of the truehd_core bsf had a pointer to a const >> AVClass as its first member; yet this bsf does not have any AVClass >> associated with it, so that this pointer is always NULL. So remove it. >> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> >> --- >> libavcodec/truehd_core_bsf.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/libavcodec/truehd_core_bsf.c b/libavcodec/truehd_core_bsf.c >> index dbd05b34ca..dfe291d9e9 100644 >> --- a/libavcodec/truehd_core_bsf.c >> +++ b/libavcodec/truehd_core_bsf.c >> @@ -31,8 +31,6 @@ typedef struct AccessUnit { >> } AccessUnit; >> >> typedef struct TrueHDCoreContext { >> - const AVClass *class; >> - >> MLPHeaderInfo hdr; >> } TrueHDCoreContext; > > LGTM Applied, thanks. - Andreas
diff --git a/libavcodec/truehd_core_bsf.c b/libavcodec/truehd_core_bsf.c index dbd05b34ca..dfe291d9e9 100644 --- a/libavcodec/truehd_core_bsf.c +++ b/libavcodec/truehd_core_bsf.c @@ -31,8 +31,6 @@ typedef struct AccessUnit { } AccessUnit; typedef struct TrueHDCoreContext { - const AVClass *class; - MLPHeaderInfo hdr; } TrueHDCoreContext;
The context structure of the truehd_core bsf had a pointer to a const AVClass as its first member; yet this bsf does not have any AVClass associated with it, so that this pointer is always NULL. So remove it. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavcodec/truehd_core_bsf.c | 2 -- 1 file changed, 2 deletions(-)