mbox series

[FFmpeg-devel,0/2] ffprobe add closed caption output to stream info

Message ID 20200424172806.87267-1-hello.vectronic@gmail.com
Headers show
Series ffprobe add closed caption output to stream info | expand

Message

vectronic April 24, 2020, 5:28 p.m. UTC
closed caption presence is detected with ffprobe and output as part of
av_dump_format() however it is not included in output from -show_streams
this add closed_captions=0 or 1 to the stream info output and updates
fate test results.

vectronic (2):
  tools ffprobe: add closed caption output to stream info
  fate: update test references for closed_caption output in ffprobe
    stream results

 fftools/ffprobe.c                                         | 2 ++
 tests/ref/fate/concat-demuxer-extended-lavf-mxf           | 2 +-
 tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10       | 2 +-
 tests/ref/fate/concat-demuxer-simple1-lavf-mxf            | 2 +-
 tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10        | 2 +-
 tests/ref/fate/concat-demuxer-simple2-lavf-ts             | 2 +-
 tests/ref/fate/ffprobe_compact                            | 4 ++--
 tests/ref/fate/ffprobe_csv                                | 4 ++--
 tests/ref/fate/ffprobe_default                            | 2 ++
 tests/ref/fate/ffprobe_flat                               | 2 ++
 tests/ref/fate/ffprobe_ini                                | 2 ++
 tests/ref/fate/ffprobe_json                               | 2 ++
 tests/ref/fate/ffprobe_xml                                | 4 ++--
 tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 +
 tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov         | 1 +
 tests/ref/fate/mov-zombie                                 | 2 +-
 tests/ref/fate/mxf-probe-d10                              | 1 +
 tests/ref/fate/mxf-probe-dnxhd                            | 1 +
 tests/ref/fate/mxf-probe-dv25                             | 1 +
 19 files changed, 27 insertions(+), 12 deletions(-)

Comments

Marton Balint April 25, 2020, 7:56 a.m. UTC | #1
On Fri, 24 Apr 2020, vectronic wrote:

> closed caption presence is detected with ffprobe and output as part of
> av_dump_format() however it is not included in output from -show_streams
> this add closed_captions=0 or 1 to the stream info output and updates
> fate test results.
>
> vectronic (2):
>  tools ffprobe: add closed caption output to stream info
>  fate: update test references for closed_caption output in ffprobe
>    stream results

Functional changes and affected fate changes must be in the same patch.

Regards,
Marton

>
> fftools/ffprobe.c                                         | 2 ++
> tests/ref/fate/concat-demuxer-extended-lavf-mxf           | 2 +-
> tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10       | 2 +-
> tests/ref/fate/concat-demuxer-simple1-lavf-mxf            | 2 +-
> tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10        | 2 +-
> tests/ref/fate/concat-demuxer-simple2-lavf-ts             | 2 +-
> tests/ref/fate/ffprobe_compact                            | 4 ++--
> tests/ref/fate/ffprobe_csv                                | 4 ++--
> tests/ref/fate/ffprobe_default                            | 2 ++
> tests/ref/fate/ffprobe_flat                               | 2 ++
> tests/ref/fate/ffprobe_ini                                | 2 ++
> tests/ref/fate/ffprobe_json                               | 2 ++
> tests/ref/fate/ffprobe_xml                                | 4 ++--
> tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 +
> tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov         | 1 +
> tests/ref/fate/mov-zombie                                 | 2 +-
> tests/ref/fate/mxf-probe-d10                              | 1 +
> tests/ref/fate/mxf-probe-dnxhd                            | 1 +
> tests/ref/fate/mxf-probe-dv25                             | 1 +
> 19 files changed, 27 insertions(+), 12 deletions(-)
>
> -- 
> 2.24.2 (Apple Git-127)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Marton Balint April 25, 2020, 7:58 a.m. UTC | #2
On Sat, 25 Apr 2020, Marton Balint wrote:

>
>
> On Fri, 24 Apr 2020, vectronic wrote:
>
>> closed caption presence is detected with ffprobe and output as part of
>> av_dump_format() however it is not included in output from -show_streams
>> this add closed_captions=0 or 1 to the stream info output and updates
>> fate test results.
>>
>> vectronic (2):
>>  tools ffprobe: add closed caption output to stream info
>>  fate: update test references for closed_caption output in ffprobe
>>    stream results
>
> Functional changes and affected fate changes must be in the same patch.

Sorry, I missed your update.

Regards,
Marton

>
> Regards,
> Marton
>
>>
>> fftools/ffprobe.c                                         | 2 ++
>> tests/ref/fate/concat-demuxer-extended-lavf-mxf           | 2 +-
>> tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10       | 2 +-
>> tests/ref/fate/concat-demuxer-simple1-lavf-mxf            | 2 +-
>> tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10        | 2 +-
>> tests/ref/fate/concat-demuxer-simple2-lavf-ts             | 2 +-
>> tests/ref/fate/ffprobe_compact                            | 4 ++--
>> tests/ref/fate/ffprobe_csv                                | 4 ++--
>> tests/ref/fate/ffprobe_default                            | 2 ++
>> tests/ref/fate/ffprobe_flat                               | 2 ++
>> tests/ref/fate/ffprobe_ini                                | 2 ++
>> tests/ref/fate/ffprobe_json                               | 2 ++
>> tests/ref/fate/ffprobe_xml                                | 4 ++--
>> tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 +
>> tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov         | 1 +
>> tests/ref/fate/mov-zombie                                 | 2 +-
>> tests/ref/fate/mxf-probe-d10                              | 1 +
>> tests/ref/fate/mxf-probe-dnxhd                            | 1 +
>> tests/ref/fate/mxf-probe-dv25                             | 1 +
>> 19 files changed, 27 insertions(+), 12 deletions(-)
>>
>> -- 
>> 2.24.2 (Apple Git-127)
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".