Message ID | 1588065363-7104-5-git-send-email-linjie.fu@intel.com |
---|---|
State | Superseded |
Headers | show |
Series | enhancement for libopenh264 | expand |
Context | Check | Description |
---|---|---|
andriy/default | pending | |
andriy/make | success | Make finished |
andriy/make_fate | success | Make fate finished |
On Tue, 28 Apr 2020, Linjie Fu wrote: > Libopenh264enc would set the slice according to the number of cpu cores > if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. > > Prompt a warning for user to catch this. > > Signed-off-by: Linjie Fu <linjie.fu@intel.com> > --- > libavcodec/libopenh264enc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c > index 93d3de2..6487ce5 100644 > --- a/libavcodec/libopenh264enc.c > +++ b/libavcodec/libopenh264enc.c > @@ -247,6 +247,8 @@ FF_ENABLE_DEPRECATION_WARNINGS > param.sSpatialLayers[0].sSliceCfg.uiSliceMode = s->slice_mode; > param.sSpatialLayers[0].sSliceCfg.sSliceArgument.uiSliceNum = avctx->slices; > #endif > + if (avctx->slices == 0 && s->slice_mode == SM_FIXEDSLCNUM_SLICE) > + av_log(avctx, AV_LOG_WARNING, "Slice count will be set automatically\n"); > > if (s->slice_mode == SM_SIZELIMITED_SLICE) { > if (s->max_nal_size) { > -- > 2.7.4 This is ok with me. // Martin
diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 93d3de2..6487ce5 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -247,6 +247,8 @@ FF_ENABLE_DEPRECATION_WARNINGS param.sSpatialLayers[0].sSliceCfg.uiSliceMode = s->slice_mode; param.sSpatialLayers[0].sSliceCfg.sSliceArgument.uiSliceNum = avctx->slices; #endif + if (avctx->slices == 0 && s->slice_mode == SM_FIXEDSLCNUM_SLICE) + av_log(avctx, AV_LOG_WARNING, "Slice count will be set automatically\n"); if (s->slice_mode == SM_SIZELIMITED_SLICE) { if (s->max_nal_size) {
Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu <linjie.fu@intel.com> --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed, 2 insertions(+)