| Message ID | 20200430190027.17905-1-lou@lrcd.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel] doc/encoders: remove ffaac>fdk-aac claim | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
On 01-05-2020 12:30 am, Lou Logan wrote: > Signed-off-by: Lou Logan <lou@lrcd.com> > --- > After this claim was made in e34e3619a2b kamedo2 did in-depth ABX > testing comparing these encoders: > > https://hydrogenaud.io/index.php?topic=111085.0 > > Result: FFmpeg AAC wasn't as good as libfdk_aac on average. > > I know some things have changed since then, "use the fast coder as the > default" (fcb681ac) for example, so maybe the situation is different now. > However, I am unaware of any recent comparison. So without any > substantiation we shouldn't make such a blantant claim. > --- > doc/encoders.texi | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 18bfe8f2eb..f987e88f30 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -30,11 +30,7 @@ follows. > > Advanced Audio Coding (AAC) encoder. > > -This encoder is the default AAC encoder, natively implemented into FFmpeg. Its > -quality is on par or better than libfdk_aac at the default bitrate of 128kbps. > -This encoder also implements more options, profiles and samplerates than > -other encoders (with only the AAC-HE profile pending to be implemented) so this > -encoder has become the default and is the recommended choice. > +This encoder is the default AAC encoder, natively implemented into FFmpeg. > > @subsection Options > LGTM. Gyan
On Thu, Apr 30, 2020, at 21:00, Lou Logan wrote: > -This encoder is the default AAC encoder, natively implemented into FFmpeg. Its > -quality is on par or better than libfdk_aac at the default bitrate of 128kbps. > -This encoder also implements more options, profiles and samplerates than > -other encoders (with only the AAC-HE profile pending to be implemented) so this > -encoder has become the default and is the recommended choice. > +This encoder is the default AAC encoder, natively implemented into FFmpeg. Is it not true that the encoder implements more options, profiles and samplerates?
Jean-Baptiste Kempf (12020-05-01): > Is it not true that the encoder implements more options, profiles and > samplerates? But even if it is true, does it belong in the introductory part of the documentation? The many options will be visible in the list of options anyway. This paragraph looks more like a sales pitch to me. "this encoder has become the default and is the recommended choice" could be in an encoding guide, but it has nothing to do in a reference documentation. Regards,
On Fri, May 1, 2020, at 6:56 AM, Jean-Baptiste Kempf wrote: > > Is it not true that the encoder implements more options, profiles and > samplerates? ffaacenc has 1 additional AVoption compared to libfdk_aac; if that means anything. ffaacenc supports 1 additional sample rate (7350) compared to libfdk_aac. Not sure about profiles, but it certainly doesn't support HE(v2). I didn't compare aac_at (AudioToolbox). But as Nicolas mentioned I don't think any of that needs to be stated. We don't do it for others. I realize that the libfdk_aac section also has a claim which should be removed: > This encoder is considered to produce output on par or worse at > 128kbps to the the native FFmpeg AAC encoder but can often produce > better sounding audio at identical or lower bitrates... I'll remove this when/if I apply the patch.
On Thu, Apr 30, 2020, at 11:00 AM, Lou Logan wrote: > doc/encoders.texi | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Pushed.
diff --git a/doc/encoders.texi b/doc/encoders.texi index 18bfe8f2eb..f987e88f30 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -30,11 +30,7 @@ follows. Advanced Audio Coding (AAC) encoder. -This encoder is the default AAC encoder, natively implemented into FFmpeg. Its -quality is on par or better than libfdk_aac at the default bitrate of 128kbps. -This encoder also implements more options, profiles and samplerates than -other encoders (with only the AAC-HE profile pending to be implemented) so this -encoder has become the default and is the recommended choice. +This encoder is the default AAC encoder, natively implemented into FFmpeg. @subsection Options
Signed-off-by: Lou Logan <lou@lrcd.com> --- After this claim was made in e34e3619a2b kamedo2 did in-depth ABX testing comparing these encoders: https://hydrogenaud.io/index.php?topic=111085.0 Result: FFmpeg AAC wasn't as good as libfdk_aac on average. I know some things have changed since then, "use the fast coder as the default" (fcb681ac) for example, so maybe the situation is different now. However, I am unaware of any recent comparison. So without any substantiation we shouldn't make such a blantant claim. --- doc/encoders.texi | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)