| Message ID | 20200209130957.25474-2-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 2d465a401dd790e2ca126ecb9cbda43f898a492f |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avcodec/agm: Test remaining data in decode_raw_intra_rgb() | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
On Sun, Feb 09, 2020 at 02:09:57PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -16 * 134217879 cannot be represented in type 'int' > Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5639509530378240 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/dstdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...]
diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c index 880b838b0c..a239e30b78 100644 --- a/libavcodec/dstdec.c +++ b/libavcodec/dstdec.c @@ -156,7 +156,7 @@ static int read_table(GetBitContext *gb, Table *t, const int8_t code_pred_coeff[ for (j = method + 1; j < t->length[i]; j++) { int c, x = 0; for (k = 0; k < method + 1; k++) - x += code_pred_coeff[method][k] * t->coeff[i][j - k - 1]; + x += code_pred_coeff[method][k] * (unsigned)t->coeff[i][j - k - 1]; c = get_sr_golomb_dst(gb, lsb_size); if (x >= 0) c -= (x + 4) / 8;
Fixes: signed integer overflow: -16 * 134217879 cannot be represented in type 'int' Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5639509530378240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/dstdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)