mbox series

[FFmpeg-devel,v3,0/7] adpcm_ima_apm encoder + apm muxer

Message ID 20200612114603.1157417-1-zane@zanevaniperen.com
Headers show
Series adpcm_ima_apm encoder + apm muxer | expand

Message

Zane van Iperen June 12, 2020, 11:46 a.m. UTC 
Add support for encoding adpcm_ima_apm and muxing to apm.

If possible, I would like to get this functionality into the 4.3
release.

v3: [4][5][6]
* Support both extradata formats
  - fixes FATE failure + preserves compatibility
* EINVAL->ERANGE

v2: [1][2][3]
* fix mixed declarations and code
* remove unused variable
* fix array initialisation
* LOG_WARNING->LOG_ERROR
* reorder "name and probe fix"

[1] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264310.html
[2] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264309.html
[3] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264308.html
[4] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264328.html
[5] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264329.html
[6] https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/264326.html

Zane van Iperen (7):
  avformat/apm: check codec tag in probe and add constant
  avcodec/adpcm_ima_apm: support new extradata format
  avcodec: add adpcm_ima_apm encoder
  avformat/apm: use new extradata format
  avformat: add apm muxer
  fate: add adpcm_ima_apm encoding test
  avcodec/adpcmenc: cleanup trellis checks

 Changelog                      |   1 +
 doc/general.texi               |   2 +-
 libavcodec/Makefile            |   1 +
 libavcodec/adpcm.c             |  17 ++-
 libavcodec/adpcmenc.c          |  63 ++++++---
 libavcodec/allcodecs.c         |   1 +
 libavcodec/utils.c             |   1 +
 libavcodec/version.h           |   2 +-
 libavformat/Makefile           |   3 +-
 libavformat/allformats.c       |   1 +
 libavformat/apm.c              | 244 ++++++++++++++++++++++++---------
 libavformat/version.h          |   2 +-
 tests/fate/acodec.mak          |   2 +
 tests/ref/acodec/adpcm-ima_apm |   4 +
 14 files changed, 256 insertions(+), 88 deletions(-)
 create mode 100644 tests/ref/acodec/adpcm-ima_apm

Comments

Zane van Iperen June 13, 2020, 2:38 p.m. UTC | #1 
On Fri, 12 Jun 2020 11:46:08 +0000
"Zane van Iperen" <zane@zanevaniperen.com> wrote:

> 
> Add support for encoding adpcm_ima_apm and muxing to apm.
> 
> If possible, I would like to get this functionality into the 4.3
> release.
>

Ping.

Zane
Zane van Iperen June 16, 2020, 1:38 p.m. UTC | #2 
On Fri, 12 Jun 2020 11:46:08 +0000
"Zane van Iperen" <zane@zanevaniperen.com> wrote:

> 
> Add support for encoding adpcm_ima_apm and muxing to apm.
> 
> If possible, I would like to get this functionality into the 4.3
> release.
> 
Ping 2.

Also, I noticed that patches 3 and 4 should probably be swapped.

Zane