diff mbox series

[FFmpeg-devel] avformat/flvdec: Remove unnecessary initializations

Message ID tencent_4F805034B33E7B56A99CF8E0145A7234BF09@qq.com
State New
Headers show
Series [FFmpeg-devel] avformat/flvdec: Remove unnecessary initializations | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Zhao Zhili July 26, 2020, 5:30 a.m. UTC 
pre_tag_size is always reset by avio_rb32(). For AVFormatContext
start_time, as the document says, "NEVER set this value directly:
It is deduced from the AVStream values."
---
fix commit subject
 libavformat/flvdec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Zhao Zhili July 31, 2020, 11:24 a.m. UTC | #1 
Please help review the patch, thanks!

> On Jul 26, 2020, at 1:30 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> pre_tag_size is always reset by avio_rb32(). For AVFormatContext
> start_time, as the document says, "NEVER set this value directly:
> It is deduced from the AVStream values."
> ---
> fix commit subject
> libavformat/flvdec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
> index 08622739f3..31bdbbd5e9 100644
> --- a/libavformat/flvdec.c
> +++ b/libavformat/flvdec.c
> @@ -747,7 +747,7 @@ static int flv_read_header(AVFormatContext *s)
>     int flags;
>     FLVContext *flv = s->priv_data;
>     int offset;
> -    int pre_tag_size = 0;
> +    int pre_tag_size;
> 
>     /* Actual FLV data at 0xe40000 in KUX file */
>     if(!strcmp(s->iformat->name, "kux"))
> @@ -773,7 +773,6 @@ static int flv_read_header(AVFormatContext *s)
>         av_log(s, AV_LOG_WARNING, "Read FLV header error, input file is not a standard flv format, first PreviousTagSize0 always is 0\n");
>     }
> 
> -    s->start_time = 0;
>     flv->sum_flv_tag_size = 0;
>     flv->last_keyframe_stream_index = -1;
> 
> -- 
> 2.25.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index 08622739f3..31bdbbd5e9 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -747,7 +747,7 @@  static int flv_read_header(AVFormatContext *s)
     int flags;
     FLVContext *flv = s->priv_data;
     int offset;
-    int pre_tag_size = 0;
+    int pre_tag_size;
 
     /* Actual FLV data at 0xe40000 in KUX file */
     if(!strcmp(s->iformat->name, "kux"))
@@ -773,7 +773,6 @@  static int flv_read_header(AVFormatContext *s)
         av_log(s, AV_LOG_WARNING, "Read FLV header error, input file is not a standard flv format, first PreviousTagSize0 always is 0\n");
     }
 
-    s->start_time = 0;
     flv->sum_flv_tag_size = 0;
     flv->last_keyframe_stream_index = -1;