diff mbox series

[FFmpeg-devel] avutil/video_enc_params: fix code comment

Message ID 1597291025-145065-1-git-send-email-leozhang@qiyi.com
State Accepted
Commit 3b7036bc1d3bea6631088b58a6dc6399aad157e3
Headers show
Series [FFmpeg-devel] avutil/video_enc_params: fix code comment | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

leozhang Aug. 13, 2020, 3:57 a.m. UTC
Signed-off-by: leozhang <leozhang@qiyi.com>
---
 libavutil/video_enc_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhao Zhili Aug. 12, 2020, 4:55 p.m. UTC | #1
> On Aug 13, 2020, at 11:57 AM, leozhang <leozhang@qiyi.com> wrote:
> 
> Signed-off-by: leozhang <leozhang@qiyi.com>
> ---
> libavutil/video_enc_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h
> index 43fa443..e3b422d 100644
> --- a/libavutil/video_enc_params.h
> +++ b/libavutil/video_enc_params.h
> @@ -153,7 +153,7 @@ AVVideoEncParams *av_video_enc_params_alloc(enum AVVideoEncParamsType type,
> /**
>  * Allocates memory for AVEncodeInfoFrame plus an array of
>  * {@code nb_blocks} AVEncodeInfoBlock in the given AVFrame {@code frame}
> - * as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO
> + * as AVFrameSideData of type AV_FRAME_DATA_VIDEO_ENC_PARAMS
>  * and initializes the variables.
>  */
> AVVideoEncParams*

LGTM.

> -- 
> 1.8.3.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
leozhang Aug. 20, 2020, 5:47 a.m. UTC | #2
zhilizhao <quinkblack@foxmail.com> 于2020年8月13日周四 下午12:55写道:
>
>
>
> > On Aug 13, 2020, at 11:57 AM, leozhang <leozhang@qiyi.com> wrote:
> >
> > Signed-off-by: leozhang <leozhang@qiyi.com>
> > ---
> > libavutil/video_enc_params.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h
> > index 43fa443..e3b422d 100644
> > --- a/libavutil/video_enc_params.h
> > +++ b/libavutil/video_enc_params.h
> > @@ -153,7 +153,7 @@ AVVideoEncParams *av_video_enc_params_alloc(enum AVVideoEncParamsType type,
> > /**
> >  * Allocates memory for AVEncodeInfoFrame plus an array of
> >  * {@code nb_blocks} AVEncodeInfoBlock in the given AVFrame {@code frame}
> > - * as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO
> > + * as AVFrameSideData of type AV_FRAME_DATA_VIDEO_ENC_PARAMS
> >  * and initializes the variables.
> >  */
> > AVVideoEncParams*
>
> LGTM.
Thanks for the review. So could someone help to push it?
>
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Steven Liu Aug. 20, 2020, 9:46 a.m. UTC | #3
leozhang <nowerzt@gmail.com> 于2020年8月20日周四 下午1:53写道:
>
> zhilizhao <quinkblack@foxmail.com> 于2020年8月13日周四 下午12:55写道:
> >
> >
> >
> > > On Aug 13, 2020, at 11:57 AM, leozhang <leozhang@qiyi.com> wrote:
> > >
> > > Signed-off-by: leozhang <leozhang@qiyi.com>
> > > ---
> > > libavutil/video_enc_params.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h
> > > index 43fa443..e3b422d 100644
> > > --- a/libavutil/video_enc_params.h
> > > +++ b/libavutil/video_enc_params.h
> > > @@ -153,7 +153,7 @@ AVVideoEncParams *av_video_enc_params_alloc(enum AVVideoEncParamsType type,
> > > /**
> > >  * Allocates memory for AVEncodeInfoFrame plus an array of
> > >  * {@code nb_blocks} AVEncodeInfoBlock in the given AVFrame {@code frame}
> > > - * as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO
> > > + * as AVFrameSideData of type AV_FRAME_DATA_VIDEO_ENC_PARAMS
> > >  * and initializes the variables.
> > >  */
> > > AVVideoEncParams*
> >
> > LGTM.
> Thanks for the review. So could someone help to push it?
Applied!


Thanks
Steven
diff mbox series

Patch

diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h
index 43fa443..e3b422d 100644
--- a/libavutil/video_enc_params.h
+++ b/libavutil/video_enc_params.h
@@ -153,7 +153,7 @@  AVVideoEncParams *av_video_enc_params_alloc(enum AVVideoEncParamsType type,
 /**
  * Allocates memory for AVEncodeInfoFrame plus an array of
  * {@code nb_blocks} AVEncodeInfoBlock in the given AVFrame {@code frame}
- * as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO
+ * as AVFrameSideData of type AV_FRAME_DATA_VIDEO_ENC_PARAMS
  * and initializes the variables.
  */
 AVVideoEncParams*