| Message ID | 20200727041305.19051-1-andreas.rheinhardt@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avformat/internal: Remove wrong documentation | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
Quoting Andreas Rheinhardt (2020-07-27 06:13:05) > Has apparently been copied from ff_choose_timebase() in commit > a45cf639e6fb8c86aff91a00970060cd0be401c9. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > Btw: There is exactly one user of this, namely the MXF muxer. > Should this be moved to mxfenc.c? The same issue exists for > ff_choose_timebase(), which is only used by the nut muxer. > > libavformat/internal.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavformat/internal.h b/libavformat/internal.h > index 17a6ab07d3..a2eac3250d 100644 > --- a/libavformat/internal.h > +++ b/libavformat/internal.h > @@ -538,9 +538,6 @@ enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int be, int sflags); > */ > AVRational ff_choose_timebase(AVFormatContext *s, AVStream *st, int min_precision); > > -/** > - * Chooses a timebase for muxing the specified stream. > - */ > enum AVChromaLocation ff_choose_chroma_location(AVFormatContext *s, AVStream *st); > > /** > -- > 2.20.1 I'd say yes. Patch looks ok either way.
On 7/27/20, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote: > Has apparently been copied from ff_choose_timebase() in commit > a45cf639e6fb8c86aff91a00970060cd0be401c9. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > Btw: There is exactly one user of this, namely the MXF muxer. > Should this be moved to mxfenc.c? The same issue exists for > ff_choose_timebase(), which is only used by the nut muxer. > > libavformat/internal.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavformat/internal.h b/libavformat/internal.h > index 17a6ab07d3..a2eac3250d 100644 > --- a/libavformat/internal.h > +++ b/libavformat/internal.h > @@ -538,9 +538,6 @@ enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int > be, int sflags); > */ > AVRational ff_choose_timebase(AVFormatContext *s, AVStream *st, int > min_precision); > > -/** > - * Chooses a timebase for muxing the specified stream. > - */ > enum AVChromaLocation ff_choose_chroma_location(AVFormatContext *s, > AVStream *st); > > /** > -- > 2.20.1 > LGTM too > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/libavformat/internal.h b/libavformat/internal.h index 17a6ab07d3..a2eac3250d 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -538,9 +538,6 @@ enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int be, int sflags); */ AVRational ff_choose_timebase(AVFormatContext *s, AVStream *st, int min_precision); -/** - * Chooses a timebase for muxing the specified stream. - */ enum AVChromaLocation ff_choose_chroma_location(AVFormatContext *s, AVStream *st); /**
Has apparently been copied from ff_choose_timebase() in commit a45cf639e6fb8c86aff91a00970060cd0be401c9. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- Btw: There is exactly one user of this, namely the MXF muxer. Should this be moved to mxfenc.c? The same issue exists for ff_choose_timebase(), which is only used by the nut muxer. libavformat/internal.h | 3 --- 1 file changed, 3 deletions(-)