diff mbox

[FFmpeg-devel] news: add entry about stricter configure behavior

Message ID 1f7f6589-e82e-0cd5-d8d7-1a5d9424da70@googlemail.com
State New
Headers show

Commit Message

Andreas Cadhalpun Dec. 10, 2016, 6:47 p.m. UTC
Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
---
 src/index | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

James Almer Dec. 10, 2016, 6:49 p.m. UTC | #1
On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote:
> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> ---
>  src/index | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/index b/src/index
> index c203676..8f533f5 100644
> --- a/src/index
> +++ b/src/index
> @@ -37,6 +37,13 @@
>      News
>    </h1>
>  
> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
> +  <p>
> +    The configure script now fails if autodetect-libraries are requested but not found.
> +  </p>
> +  <p>
> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
> +  </p>
>    <h3 id="gsoc2016finalreport">October 30th, 2016, Results: Summer Of Code 2016.</h3>
>    <p>
>      This has been a long time coming but we wanted to give a proper closure to our participation in this run of the program and it takes time. Sometimes it's just to get the final report for each project trimmed down, others, is finalizing whatever was still in progress when the program finished: final patches need to be merged, TODO lists stabilized, future plans agreed; you name it.
> 

This is a Changelog kind of line, not a news entry.

It could maybe be added to the news entry announcing the next release,
but it's not worth alone on its own.
Andreas Cadhalpun Dec. 10, 2016, 6:53 p.m. UTC | #2
On 10.12.2016 19:49, James Almer wrote:
> On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote:
>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>> ---
>>  src/index | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/src/index b/src/index
>> index c203676..8f533f5 100644
>> --- a/src/index
>> +++ b/src/index
>> @@ -37,6 +37,13 @@
>>      News
>>    </h1>
>>  
>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>> +  <p>
>> +    The configure script now fails if autodetect-libraries are requested but not found.
>> +  </p>
>> +  <p>
>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>> +  </p>
>>    <h3 id="gsoc2016finalreport">October 30th, 2016, Results: Summer Of Code 2016.</h3>
>>    <p>
>>      This has been a long time coming but we wanted to give a proper closure to our participation in this run of the program and it takes time. Sometimes it's just to get the final report for each project trimmed down, others, is finalizing whatever was still in progress when the program finished: final patches need to be merged, TODO lists stabilized, future plans agreed; you name it.
>>
> 
> This is a Changelog kind of line, not a news entry.
> 
> It could maybe be added to the news entry announcing the next release,
> but it's not worth alone on its own.

I don't mind either way, so discuss this with Carl Eugen.

Best regards,
Andreas
Ronald S. Bultje Dec. 10, 2016, 8:06 p.m. UTC | #3
Hi,

On Sat, Dec 10, 2016 at 1:53 PM, Andreas Cadhalpun <
andreas.cadhalpun@googlemail.com> wrote:

> On 10.12.2016 19:49, James Almer wrote:
> > On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote:
> >> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> >> ---
> >>  src/index | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/src/index b/src/index
> >> index c203676..8f533f5 100644
> >> --- a/src/index
> >> +++ b/src/index
> >> @@ -37,6 +37,13 @@
> >>      News
> >>    </h1>
> >>
> >> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure
> behavior.</h3>
> >> +  <p>
> >> +    The configure script now fails if autodetect-libraries are
> requested but not found.
> >> +  </p>
> >> +  <p>
> >> +    If for example SDL headers are not available, '--enable-sdl2' will
> cause a configure failure.
> >> +  </p>
> >>    <h3 id="gsoc2016finalreport">October 30th, 2016, Results: Summer Of
> Code 2016.</h3>
> >>    <p>
> >>      This has been a long time coming but we wanted to give a proper
> closure to our participation in this run of the program and it takes time.
> Sometimes it's just to get the final report for each project trimmed down,
> others, is finalizing whatever was still in progress when the program
> finished: final patches need to be merged, TODO lists stabilized, future
> plans agreed; you name it.
> >>
> >
> > This is a Changelog kind of line, not a news entry.
> >
> > It could maybe be added to the news entry announcing the next release,
> > but it's not worth alone on its own.
>
> I don't mind either way, so discuss this with Carl Eugen.


What makes Carl Eugen so special when it comes to posting news entries?

Ronald
Carl Eugen Hoyos Dec. 10, 2016, 10:22 p.m. UTC | #4
2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> ---
>  src/index | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/index b/src/index
> index c203676..8f533f5 100644
> --- a/src/index
> +++ b/src/index
> @@ -37,6 +37,13 @@
>      News
>    </h1>
>
> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
> +  <p>
> +    The configure script now fails if autodetect-libraries are requested but not found.
> +  </p>
> +  <p>
> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.

Please push, esp. since the relevant change is already in git.

Thank you, Carl Eugen
James Almer Dec. 10, 2016, 10:24 p.m. UTC | #5
On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>> ---
>>  src/index | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/src/index b/src/index
>> index c203676..8f533f5 100644
>> --- a/src/index
>> +++ b/src/index
>> @@ -37,6 +37,13 @@
>>      News
>>    </h1>
>>
>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>> +  <p>
>> +    The configure script now fails if autodetect-libraries are requested but not found.
>> +  </p>
>> +  <p>
>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
> 
> Please push, esp. since the relevant change is already in git.
> 
> Thank you, Carl Eugen

Again, I'm against this. This is not news entry worthy.

A line can be added to the next release news entry announcement, or
to the RELEASE_NOTES files, but not alone.
Carl Eugen Hoyos Dec. 10, 2016, 10:27 p.m. UTC | #6
2016-12-10 23:24 GMT+01:00 James Almer <jamrial@gmail.com>:
> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>> ---
>>>  src/index | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/src/index b/src/index
>>> index c203676..8f533f5 100644
>>> --- a/src/index
>>> +++ b/src/index
>>> @@ -37,6 +37,13 @@
>>>      News
>>>    </h1>
>>>
>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>> +  <p>
>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>> +  </p>
>>> +  <p>
>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>
>> Please push, esp. since the relevant change is already in git.
>>
>> Thank you, Carl Eugen
>
> Again, I'm against this. This is not news entry worthy.

Then please revert the configure change:
This is (by far) the biggest change in configure behaviour since forever,
this has to be communicated and this was the condition for the patch.

> A line can be added to the next release news entry announcement, or
> to the RELEASE_NOTES files, but not alone.

If you care, add it to the release notes, but this cannot replace the
news entry.

Carl Eugen
Hendrik Leppkes Dec. 10, 2016, 10:32 p.m. UTC | #7
On Sat, Dec 10, 2016 at 11:24 PM, James Almer <jamrial@gmail.com> wrote:
> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>> ---
>>>  src/index | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/src/index b/src/index
>>> index c203676..8f533f5 100644
>>> --- a/src/index
>>> +++ b/src/index
>>> @@ -37,6 +37,13 @@
>>>      News
>>>    </h1>
>>>
>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>> +  <p>
>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>> +  </p>
>>> +  <p>
>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>
>> Please push, esp. since the relevant change is already in git.
>>
>> Thank you, Carl Eugen
>
> Again, I'm against this. This is not news entry worthy.
>
> A line can be added to the next release news entry announcement, or
> to the RELEASE_NOTES files, but not alone.
>

I agree with James, simple behavior changes in git master should not
be posted as their own news entries. We have changelogs for this and
release summary announcements.

- Hendrik
Carl Eugen Hoyos Dec. 10, 2016, 10:34 p.m. UTC | #8
2016-12-10 23:32 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>:
> On Sat, Dec 10, 2016 at 11:24 PM, James Almer <jamrial@gmail.com> wrote:
>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>>> ---
>>>>  src/index | 7 +++++++
>>>>  1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/src/index b/src/index
>>>> index c203676..8f533f5 100644
>>>> --- a/src/index
>>>> +++ b/src/index
>>>> @@ -37,6 +37,13 @@
>>>>      News
>>>>    </h1>
>>>>
>>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>>> +  <p>
>>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>>> +  </p>
>>>> +  <p>
>>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>>
>>> Please push, esp. since the relevant change is already in git.
>>>
>>> Thank you, Carl Eugen
>>
>> Again, I'm against this. This is not news entry worthy.
>>
>> A line can be added to the next release news entry announcement, or
>> to the RELEASE_NOTES files, but not alone.
>>
>
> I agree with James,

> simple behavior changes in git master should not
> be posted as their own news entries.

Of course!
But this is not a "simple" change but the biggest change in
configure behaviour in the last decade.

Carl Eugen
Hendrik Leppkes Dec. 10, 2016, 10:37 p.m. UTC | #9
On Sat, Dec 10, 2016 at 11:34 PM, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2016-12-10 23:32 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>:
>> On Sat, Dec 10, 2016 at 11:24 PM, James Almer <jamrial@gmail.com> wrote:
>>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>>>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>>>> ---
>>>>>  src/index | 7 +++++++
>>>>>  1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/src/index b/src/index
>>>>> index c203676..8f533f5 100644
>>>>> --- a/src/index
>>>>> +++ b/src/index
>>>>> @@ -37,6 +37,13 @@
>>>>>      News
>>>>>    </h1>
>>>>>
>>>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>>>> +  <p>
>>>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>>>> +  </p>
>>>>> +  <p>
>>>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>>>
>>>> Please push, esp. since the relevant change is already in git.
>>>>
>>>> Thank you, Carl Eugen
>>>
>>> Again, I'm against this. This is not news entry worthy.
>>>
>>> A line can be added to the next release news entry announcement, or
>>> to the RELEASE_NOTES files, but not alone.
>>>
>>
>> I agree with James,
>
>> simple behavior changes in git master should not
>> be posted as their own news entries.
>
> Of course!
> But this is not a "simple" change but the biggest change in
> configure behaviour in the last decade.
>

Not really, it just makes all options consistent. We had various
--enable-* options that failed when not found and various that didn't
fail. If anything its a bugfix.

- Hendrik
James Almer Dec. 10, 2016, 10:47 p.m. UTC | #10
On 12/10/2016 7:34 PM, Carl Eugen Hoyos wrote:
> 2016-12-10 23:32 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>:
>> On Sat, Dec 10, 2016 at 11:24 PM, James Almer <jamrial@gmail.com> wrote:
>>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>>>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>>>> ---
>>>>>  src/index | 7 +++++++
>>>>>  1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/src/index b/src/index
>>>>> index c203676..8f533f5 100644
>>>>> --- a/src/index
>>>>> +++ b/src/index
>>>>> @@ -37,6 +37,13 @@
>>>>>      News
>>>>>    </h1>
>>>>>
>>>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>>>> +  <p>
>>>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>>>> +  </p>
>>>>> +  <p>
>>>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>>>
>>>> Please push, esp. since the relevant change is already in git.
>>>>
>>>> Thank you, Carl Eugen
>>>
>>> Again, I'm against this. This is not news entry worthy.
>>>
>>> A line can be added to the next release news entry announcement, or
>>> to the RELEASE_NOTES files, but not alone.
>>>
>>
>> I agree with James,
> 
>> simple behavior changes in git master should not
>> be posted as their own news entries.
> 
> Of course!
> But this is not a "simple" change but the biggest change in
> configure behaviour in the last decade.
> 
> Carl Eugen

It is still a behavior change and specific to one part of the package
that is the configure script.
We don't announce when we increase the minimum version required for
some external library, or when we "upgrade" a library to auto-detect,
and that's something that has as many chances to break existing scripts 
from distros running specific configure line option combinations as
this behavior change recently introduced.
We don't even add a line in Changelog for those in general.

If this is really that important then it can have a line in the news
entry for the upcoming release, and of course should be mentioned in
the RELEASE_NOTES file (Assuming someone actually writes one this time
instead of reusing the boilerplate one from the past several versions).
Marton Balint Dec. 10, 2016, 10:53 p.m. UTC | #11
On Sat, 10 Dec 2016, James Almer wrote:

> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>> ---
>>>  src/index | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/src/index b/src/index
>>> index c203676..8f533f5 100644
>>> --- a/src/index
>>> +++ b/src/index
>>> @@ -37,6 +37,13 @@
>>>      News
>>>    </h1>
>>>
>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>> +  <p>
>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>> +  </p>
>>> +  <p>
>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>> 
>> Please push, esp. since the relevant change is already in git.
>> 
>> Thank you, Carl Eugen
>
> Again, I'm against this. This is not news entry worthy.
>
> A line can be added to the next release news entry announcement, or
> to the RELEASE_NOTES files, but not alone.
>

Please, be more accepting about patches which has no technical downside,
if Carl find this impotant, it is no use to start a lengthy thread
discussing it, which in the worst case will cause another vote, and some 
people will either feel bad or trolled after it.

Marton
James Almer Dec. 10, 2016, 10:59 p.m. UTC | #12
On 12/10/2016 7:27 PM, Carl Eugen Hoyos wrote:
> 2016-12-10 23:24 GMT+01:00 James Almer <jamrial@gmail.com>:
>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote:
>>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>>> ---
>>>>  src/index | 7 +++++++
>>>>  1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/src/index b/src/index
>>>> index c203676..8f533f5 100644
>>>> --- a/src/index
>>>> +++ b/src/index
>>>> @@ -37,6 +37,13 @@
>>>>      News
>>>>    </h1>
>>>>
>>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>>> +  <p>
>>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>>> +  </p>
>>>> +  <p>
>>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>>
>>> Please push, esp. since the relevant change is already in git.
>>>
>>> Thank you, Carl Eugen
>>
>> Again, I'm against this. This is not news entry worthy.
> 
> Then please revert the configure change:
> This is (by far) the biggest change in configure behaviour since forever,
> this has to be communicated and this was the condition for the patch.

I don't think reverting an (allegedly wanted and beneficial) change just
because you wont accept it unless it has its own news entry makes sense
or is even fair to the person that wrote it and submitted it.

> 
>> A line can be added to the next release news entry announcement, or
>> to the RELEASE_NOTES files, but not alone.
> 
> If you care, add it to the release notes, but this cannot replace the
> news entry.

The RELEASE_NOTES mention is the only thing that's a must for this,
aside from the Changelog entry.
Carl Eugen Hoyos Dec. 11, 2016, 12:16 a.m. UTC | #13
2016-12-10 23:37 GMT+01:00 Hendrik Leppkes <h.leppkes@gmail.com>:
>>> simple behavior changes in git master should not
>>> be posted as their own news entries.
>>
>> Of course!
>> But this is not a "simple" change but the biggest change in
>> configure behaviour in the last decade.
>>
>
> Not really, it just makes all options consistent. We had various
> --enable-* options that failed when not found and various that didn't
> fail. If anything its a bugfix.

This is about auto-detected options, not optional libraries
that you are talking about.

Please understand that such information to our users
is important and needed.

Carl Eugen
Carl Eugen Hoyos Dec. 11, 2016, 12:17 a.m. UTC | #14
2016-12-10 23:59 GMT+01:00 James Almer <jamrial@gmail.com>:

>>> Again, I'm against this. This is not news entry worthy.
>>
>> Then please revert the configure change:
>> This is (by far) the biggest change in configure behaviour since forever,
>> this has to be communicated and this was the condition for the patch.
>
> I don't think reverting an (allegedly wanted and beneficial) change just

What does "wanted" mean in this context?

The change was reviewed and it was ok with a Changelog and a news
entry. The patch was applied, so please add the news entry.

> because you wont accept it unless it has its own news entry makes sense
> or is even fair to the person that wrote it and submitted it.
>
>>
>>> A line can be added to the next release news entry announcement, or
>>> to the RELEASE_NOTES files, but not alone.
>>
>> If you care, add it to the release notes, but this cannot replace the
>> news entry.
>
> The RELEASE_NOTES mention is the only thing that's a must for this,
> aside from the Changelog entry.

I disagree but please feel free to add this to release notes if you want.

The news entry is needed for this change.

Carl Eugen
Ronald S. Bultje Dec. 11, 2016, 2:09 a.m. UTC | #15
Hi,

On Sat, Dec 10, 2016 at 7:17 PM, Carl Eugen Hoyos <ceffmpeg@gmail.com>
wrote:

> 2016-12-10 23:59 GMT+01:00 James Almer <jamrial@gmail.com>:
>
> >>> Again, I'm against this. This is not news entry worthy.
> >>
> >> Then please revert the configure change:
> >> This is (by far) the biggest change in configure behaviour since
> forever,
> >> this has to be communicated and this was the condition for the patch.
> >
> > I don't think reverting an (allegedly wanted and beneficial) change just
>
> What does "wanted" mean in this context?
>
> The change was reviewed and it was ok with a Changelog and a news
> entry. The patch was applied, so please add the news entry.
>
> > because you wont accept it unless it has its own news entry makes sense
> > or is even fair to the person that wrote it and submitted it.
> >
> >>
> >>> A line can be added to the next release news entry announcement, or
> >>> to the RELEASE_NOTES files, but not alone.
> >>
> >> If you care, add it to the release notes, but this cannot replace the
> >> news entry.
> >
> > The RELEASE_NOTES mention is the only thing that's a must for this,
> > aside from the Changelog entry.
>
> I disagree but please feel free to add this to release notes if you want.
>
> The news entry is needed for this change.


... according to you...

Right?

Ronald
Nicolas George Dec. 11, 2016, 11:45 a.m. UTC | #16
Le decadi 20 frimaire, an CCXXV, Ronald S. Bultje a écrit :
> > The news entry is needed for this change.
> 
> ... according to you...
> 
> Right?

Are we starting a world war against a news entry, now?
Paul B Mahol Dec. 11, 2016, 1:12 p.m. UTC | #17
On 12/11/16, Nicolas George <george@nsup.org> wrote:
> Le decadi 20 frimaire, an CCXXV, Ronald S. Bultje a ecrit :
>> > The news entry is needed for this change.
>>
>> ... according to you...
>>
>> Right?
>
> Are we starting a world war against a news entry, now?
>

Yes, Carl is our revolution leader/dictator.
Andreas Cadhalpun Dec. 11, 2016, 6:41 p.m. UTC | #18
On 10.12.2016 23:22, Carl Eugen Hoyos wrote:
> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>> ---
>>  src/index | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/src/index b/src/index
>> index c203676..8f533f5 100644
>> --- a/src/index
>> +++ b/src/index
>> @@ -37,6 +37,13 @@
>>      News
>>    </h1>
>>
>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>> +  <p>
>> +    The configure script now fails if autodetect-libraries are requested but not found.
>> +  </p>
>> +  <p>
>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
> 
> Please push, esp. since the relevant change is already in git.

This trivial news patch already got way more comments than the original
patch series, which gives me the impression that people care more about
the website than the actual code. :-/

As I care more about the code I'll leave applying this patch or deciding
that it shouldn't be applied to those who care more about the website.

Best regards,
Andreas
Ronald S. Bultje Dec. 11, 2016, 9:03 p.m. UTC | #19
Hi,

On Sun, Dec 11, 2016 at 1:41 PM, Andreas Cadhalpun <
andreas.cadhalpun@googlemail.com> wrote:

> On 10.12.2016 23:22, Carl Eugen Hoyos wrote:
> > 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <
> andreas.cadhalpun@googlemail.com>:
> >> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> >> ---
> >>  src/index | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/src/index b/src/index
> >> index c203676..8f533f5 100644
> >> --- a/src/index
> >> +++ b/src/index
> >> @@ -37,6 +37,13 @@
> >>      News
> >>    </h1>
> >>
> >> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure
> behavior.</h3>
> >> +  <p>
> >> +    The configure script now fails if autodetect-libraries are
> requested but not found.
> >> +  </p>
> >> +  <p>
> >> +    If for example SDL headers are not available, '--enable-sdl2' will
> cause a configure failure.
> >
> > Please push, esp. since the relevant change is already in git.
>
> This trivial news patch already got way more comments than the original
> patch series, which gives me the impression that people care more about
> the website than the actual code. :-/


That's unfair and somewhat offensive to those of us that commented in this
thread but do more than enough to keep our tree healthy and fresh. We might
not care specifically about configure patches, but we may certainly well
care what goes on our website, since that reflects very specifically and
very focused on all of us.

Ronald
James Almer Dec. 11, 2016, 9:19 p.m. UTC | #20
On 12/11/2016 3:41 PM, Andreas Cadhalpun wrote:
> On 10.12.2016 23:22, Carl Eugen Hoyos wrote:
>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>:
>>> Suggested-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
>>> ---
>>>  src/index | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/src/index b/src/index
>>> index c203676..8f533f5 100644
>>> --- a/src/index
>>> +++ b/src/index
>>> @@ -37,6 +37,13 @@
>>>      News
>>>    </h1>
>>>
>>> +  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
>>> +  <p>
>>> +    The configure script now fails if autodetect-libraries are requested but not found.
>>> +  </p>
>>> +  <p>
>>> +    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
>>
>> Please push, esp. since the relevant change is already in git.
> 
> This trivial news patch already got way more comments than the original
> patch series, which gives me the impression that people care more about
> the website than the actual code. :-/

I think it's more like the code is fine so there was no need to discuss
anything, unlike with this patch which is disliked by some.

> 
> As I care more about the code I'll leave applying this patch or deciding
> that it shouldn't be applied to those who care more about the website.
> 
> Best regards,
> Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
Andreas Cadhalpun Dec. 11, 2016, 9:27 p.m. UTC | #21
On 11.12.2016 22:03, Ronald S. Bultje wrote:
> On Sun, Dec 11, 2016 at 1:41 PM, Andreas Cadhalpun <
> andreas.cadhalpun@googlemail.com> wrote:
>> This trivial news patch already got way more comments than the original
>> patch series, which gives me the impression that people care more about
>> the website than the actual code. :-/
> 
> 
> That's unfair and somewhat offensive to those of us that commented in this
> thread but do more than enough to keep our tree healthy and fresh.

I didn't mean to offend anyone and I'm sorry if I did. I just wanted to
express my feeling that this thread went a bit out of proportion.

Best regards,
Andreas
diff mbox

Patch

diff --git a/src/index b/src/index
index c203676..8f533f5 100644
--- a/src/index
+++ b/src/index
@@ -37,6 +37,13 @@ 
     News
   </h1>
 
+  <h3 id="stricterconfigure">December 10th, 2016, stricter configure behavior.</h3>
+  <p>
+    The configure script now fails if autodetect-libraries are requested but not found.
+  </p>
+  <p>
+    If for example SDL headers are not available, '--enable-sdl2' will cause a configure failure.
+  </p>
   <h3 id="gsoc2016finalreport">October 30th, 2016, Results: Summer Of Code 2016.</h3>
   <p>
     This has been a long time coming but we wanted to give a proper closure to our participation in this run of the program and it takes time. Sometimes it's just to get the final report for each project trimmed down, others, is finalizing whatever was still in progress when the program finished: final patches need to be merged, TODO lists stabilized, future plans agreed; you name it.