| Message ID | 20200822183935.1991-3-aghorui@teknik.io |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v6,1/4] lavc: add FLIF decoding support | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
On Sun, Aug 23, 2020 at 00:09:34 +0530, Anamitra Ghorui wrote: > --- a/configure > +++ b/configure > @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" > flac_demuxer_select="flac_parser" > flv_muxer_select="aac_adtstoasc_bsf" > gxf_muxer_select="pcm_rechunk_bsf" > +flif_demuxer_select="zlib exif" > hds_muxer_select="flv_muxer" This needs to be in the same commit as the one which adds the demuxer, it's a necessity for its build. Moritz
On 26/08/2020 18:57, Moritz Barsnick wrote: > On Sun, Aug 23, 2020 at 00:09:34 +0530, Anamitra Ghorui wrote: >> --- a/configure >> +++ b/configure >> @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" >> flac_demuxer_select="flac_parser" >> flv_muxer_select="aac_adtstoasc_bsf" >> gxf_muxer_select="pcm_rechunk_bsf" >> +flif_demuxer_select="zlib exif" >> hds_muxer_select="flv_muxer" > > This needs to be in the same commit as the one which adds the demuxer, > it's a necessity for its build. > > Moritz These are actually optional dependencies for the demuxer, and these are only required for metadata decoding. If not enabled, metadata is skipped. Should I actually remove this and let the user voluntarily add in the dependencies? I now notice that removing the line generates some unused variable warnings in the demuxer. I will take care of them in the next patch. Will also do the suggested in the rest of the 2 Emails.
diff --git a/configure b/configure index 6faff9bc7b..a80e300cdb 100755 --- a/configure +++ b/configure @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" flac_demuxer_select="flac_parser" flv_muxer_select="aac_adtstoasc_bsf" gxf_muxer_select="pcm_rechunk_bsf" +flif_demuxer_select="zlib exif" hds_muxer_select="flv_muxer" hls_muxer_select="mpegts_muxer" hls_muxer_suggest="gcrypt openssl"
Signed-off-by: Anamitra Ghorui <aghorui@teknik.io> --- configure | 1 + 1 file changed, 1 insertion(+)