| Message ID | 201612120154.12299.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Dec 12, 2016 at 01:54:12AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6014. > > Please comment, Carl Eugen > isom.c | 1 + > 1 file changed, 1 insertion(+) > d9c95ca1ee86b780a596b39f0170cb176945a5a3 0001-lavf-isom-Support-EVRC-in-pvAuthor-files.patch > From 8878744426cdaf31227786a07743d06cc6ef8995 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos <cehoyos@ag.or.at> > Date: Mon, 12 Dec 2016 01:52:12 +0100 > Subject: [PATCH] lavf/isom: Support EVRC in pvAuthor files. > > Fixes ticket #6014. > --- > libavformat/isom.c | 1 + > 1 file changed, 1 insertion(+) should be ok fate test is welcome if we have a small sample thx [...]
On 12/12/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: > Hi! > > Attached patch fixes ticket #6014. > > Please comment, Carl Eugen > Please try keep it in order, otherwise ok
2016-12-12 9:24 GMT+01:00 Paul B Mahol <onemda@gmail.com>: > On 12/12/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >> Hi! >> >> Attached patch fixes ticket #6014. >> >> Please comment, Carl Eugen >> > > Please try keep it in order, otherwise ok Where exactly do you want me to put the new line? Carl Eugen
On 12/12/16, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > 2016-12-12 9:24 GMT+01:00 Paul B Mahol <onemda@gmail.com>: >> On 12/12/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >>> Hi! >>> >>> Attached patch fixes ticket #6014. >>> >>> Please comment, Carl Eugen >>> >> >> Please try keep it in order, otherwise ok > > Where exactly do you want me to put the new line? > Right before vorbis is, few lines above. > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
2016-12-12 11:15 GMT+01:00 Paul B Mahol <onemda@gmail.com>: > On 12/12/16, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: >> 2016-12-12 9:24 GMT+01:00 Paul B Mahol <onemda@gmail.com>: >>> On 12/12/16, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: >>>> Hi! >>>> >>>> Attached patch fixes ticket #6014. >>>> >>>> Please comment, Carl Eugen >>>> >>> >>> Please try keep it in order, otherwise ok >> >> Where exactly do you want me to put the new line? >> > > Right before vorbis is, few lines above. Moved right before vorbis and pushed. Thank you, Carl Eugen
2016-12-12 3:44 GMT+01:00 Michael Niedermayer <michael@niedermayer.cc>: > On Mon, Dec 12, 2016 at 01:54:12AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #6014. >> >> Please comment, Carl Eugen > >> isom.c | 1 + >> 1 file changed, 1 insertion(+) >> d9c95ca1ee86b780a596b39f0170cb176945a5a3 0001-lavf-isom-Support-EVRC-in-pvAuthor-files.patch >> From 8878744426cdaf31227786a07743d06cc6ef8995 Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos <cehoyos@ag.or.at> >> Date: Mon, 12 Dec 2016 01:52:12 +0100 >> Subject: [PATCH] lavf/isom: Support EVRC in pvAuthor files. >> >> Fixes ticket #6014. >> --- >> libavformat/isom.c | 1 + >> 1 file changed, 1 insertion(+) > > should be ok > fate test is welcome if we have a small sample Is that possible for flt codecs? Carl Eugen
On Mon, Dec 12, 2016 at 11:49:41AM +0100, Carl Eugen Hoyos wrote: > 2016-12-12 3:44 GMT+01:00 Michael Niedermayer <michael@niedermayer.cc>: > > On Mon, Dec 12, 2016 at 01:54:12AM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes ticket #6014. > >> > >> Please comment, Carl Eugen > > > >> isom.c | 1 + > >> 1 file changed, 1 insertion(+) > >> d9c95ca1ee86b780a596b39f0170cb176945a5a3 0001-lavf-isom-Support-EVRC-in-pvAuthor-files.patch > >> From 8878744426cdaf31227786a07743d06cc6ef8995 Mon Sep 17 00:00:00 2001 > >> From: Carl Eugen Hoyos <cehoyos@ag.or.at> > >> Date: Mon, 12 Dec 2016 01:52:12 +0100 > >> Subject: [PATCH] lavf/isom: Support EVRC in pvAuthor files. > >> > >> Fixes ticket #6014. > >> --- > >> libavformat/isom.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > should be ok > > fate test is welcome if we have a small sample > > Is that possible for flt codecs? a reference PCM file can be used, fate supports "fuzzy" comparing its not 100% sure that this is possible with this codec but its worth a try [...]
diff --git a/libavformat/isom.c b/libavformat/isom.c index cd0b0b7..bab875d 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -63,6 +63,7 @@ const AVCodecTag ff_mp4_obj_type[] = { { AV_CODEC_ID_FLAC , 0xC1 }, /* nonstandard, update when there is a standard value */ { AV_CODEC_ID_TSCC2 , 0xD0 }, /* nonstandard, camtasia uses it */ { AV_CODEC_ID_VORBIS , 0xDD }, /* nonstandard, gpac uses it */ + { AV_CODEC_ID_EVRC , 0xD1 }, /* nonstandard, pvAuthor uses it */ { AV_CODEC_ID_DVD_SUBTITLE, 0xE0 }, /* nonstandard, see unsupported-embedded-subs-2.mp4 */ { AV_CODEC_ID_QCELP , 0xE1 }, { AV_CODEC_ID_MPEG4SYSTEMS, 0x01 },
Hi! Attached patch fixes ticket #6014. Please comment, Carl Eugen From 8878744426cdaf31227786a07743d06cc6ef8995 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Mon, 12 Dec 2016 01:52:12 +0100 Subject: [PATCH] lavf/isom: Support EVRC in pvAuthor files. Fixes ticket #6014. --- libavformat/isom.c | 1 + 1 file changed, 1 insertion(+)