| Message ID | 20201030110122.26502-3-martin@martin.st |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/3] tls: Share code for common protocol functions and fields | expand |
| Context | Check | Description |
|---|---|---|
| andriy/PPC64_make | success | Make finished |
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | fail | Make fate failed |
| andriy/PPC64_make_fate | warning | Make fate failed |
On Fri, 30 Oct 2020, Martin Storsjö wrote: > The previous threshold, 4 KB, maybe was reasonable when it was set > (in 2010), but in today's settings and with typical network speeds > and data sizes, it's pretty small. 32 KB probably is a more reasonable > default now, regardless of input. > --- > libavformat/aviobuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c > index a77517d712..e1acb3890c 100644 > --- a/libavformat/aviobuf.c > +++ b/libavformat/aviobuf.c > @@ -40,7 +40,7 @@ > * data instead of calling the protocol seek function, for seekable > * protocols. > */ > -#define SHORT_SEEK_THRESHOLD 4096 > +#define SHORT_SEEK_THRESHOLD 32768 > I see that this change changes a few test cases in fate-seek-lavf-{al,ul}, will try to have a look at what they are and if we just should update the references, or if something else should be done here... // Martin
diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index a77517d712..e1acb3890c 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -40,7 +40,7 @@ * data instead of calling the protocol seek function, for seekable * protocols. */ -#define SHORT_SEEK_THRESHOLD 4096 +#define SHORT_SEEK_THRESHOLD 32768 static void *ff_avio_child_next(void *obj, void *prev) {