| Message ID | 20201204225740.1506052-3-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/3] avcodec/av1dec: Fix leak in case of failure | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | fail | Make fate fail |
Quoting Andreas Rheinhardt (2020-12-04 23:57:40) > The md5 test up until now ignored errors from ffmpeg (the cli) and just > md5'ed whatever ffmpeg has output; while testing scenarios in which > ffmpeg fails has its merits, errors should not be overlooked by default; > doing so also reduces the effectiveness of sanitizers as errors from > them are ignored. This has happened with a memleak in the AV1 decoder. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > tests/fate-run.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good
diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 58d5fdbb60..b69176f7c3 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -158,7 +158,7 @@ md5pipe(){ md5(){ encfile="${outdir}/${test}.out" cleanfiles="$cleanfiles $encfile" - ffmpeg -y "$@" $(target_path $encfile) + ffmpeg -y "$@" $(target_path $encfile) || return do_md5sum $encfile | awk '{print $1}' }
The md5 test up until now ignored errors from ffmpeg (the cli) and just md5'ed whatever ffmpeg has output; while testing scenarios in which ffmpeg fails has its merits, errors should not be overlooked by default; doing so also reduces the effectiveness of sanitizers as errors from them are ignored. This has happened with a memleak in the AV1 decoder. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)