diff mbox series

[FFmpeg-devel] lavd/decklink_dec: Use correct case for codec point / fourcc v210

Message ID CAB0OVGpcqHnoN5N_bi3_PG9AjRTtQ-uRfKGzzrcq3R-FDBnk7w@mail.gmail.com
State Accepted
Headers show
Series [FFmpeg-devel] lavd/decklink_dec: Use correct case for codec point / fourcc v210 | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Carl Eugen Hoyos Dec. 10, 2020, 11:35 p.m. UTC 
Hi!

Attached patch fixes ticket #9005.

Please comment, Carl Eugen
Subject: [PATCH] lavd/decklink_dec: Use correct case for codec point / fourcc v210.

Reported and tested by trac user carbenium.
Fixes ticket #9005.
---
 libavdevice/decklink_dec.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marton Balint Dec. 12, 2020, 9:57 a.m. UTC | #1 
On Fri, 11 Dec 2020, Carl Eugen Hoyos wrote:

> Hi!
>
> Attached patch fixes ticket #9005.

Why are the codec_tags set at all? Can't we simply remove setting of all 
the codec tags in decklink? They hold no additional information to 
codec id and pixel format. This should also fix the issue IMHO.

Regards,
Marton
Carl Eugen Hoyos Dec. 13, 2020, 10:04 a.m. UTC | #2 
Am Sa., 12. Dez. 2020 um 10:57 Uhr schrieb Marton Balint <cus@passwd.hu>:
>
> On Fri, 11 Dec 2020, Carl Eugen Hoyos wrote:
>
> > Attached patch fixes ticket #9005.
>
> Why are the codec_tags set at all? Can't we simply remove setting of all
> the codec tags in decklink? They hold no additional information to
> codec id and pixel format. This should also fix the issue IMHO.

Alternative patch attached, completely untested.

Carl Eugen
Marton Balint Dec. 21, 2020, 12:18 a.m. UTC | #3 
On Sun, 13 Dec 2020, Carl Eugen Hoyos wrote:

> Am Sa., 12. Dez. 2020 um 10:57 Uhr schrieb Marton Balint <cus@passwd.hu>:
>>
>> On Fri, 11 Dec 2020, Carl Eugen Hoyos wrote:
>>
>>> Attached patch fixes ticket #9005.
>>
>> Why are the codec_tags set at all? Can't we simply remove setting of all
>> the codec tags in decklink? They hold no additional information to
>> codec id and pixel format. This should also fix the issue IMHO.
>
> Alternative patch attached, completely untested.

I have tested it and it fixes the ticket. Patch LGTM.

Thanks,
Marton
Carl Eugen Hoyos Dec. 24, 2020, 11:14 a.m. UTC | #4 
Am Mo., 21. Dez. 2020 um 01:18 Uhr schrieb Marton Balint <cus@passwd.hu>:

> >>> Attached patch fixes ticket #9005.
> >>
> >> Why are the codec_tags set at all? Can't we simply remove setting of all
> >> the codec tags in decklink? They hold no additional information to
> >> codec id and pixel format. This should also fix the issue IMHO.
> >
> > Alternative patch attached, completely untested.
>
> I have tested it and it fixes the ticket. Patch LGTM.

Thank you, patch applied.

Merry Christmas, Carl Eugen
diff mbox series

Patch

diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index 6517b9df13..dd8c3b7d95 100644
--- a/libavdevice/decklink_dec.cpp
+++ b/libavdevice/decklink_dec.cpp
@@ -1286,7 +1286,7 @@  av_cold int ff_decklink_read_header(AVFormatContext *avctx)
         break;
     case bmdFormat10BitYUV:
         st->codecpar->codec_id    = AV_CODEC_ID_V210;
-        st->codecpar->codec_tag   = MKTAG('V','2','1','0');
+        st->codecpar->codec_tag   = MKTAG('v','2','1','0');
         st->codecpar->bit_rate    = av_rescale(ctx->bmd_width * ctx->bmd_height * 64, st->time_base.den, st->time_base.num * 3);
         st->codecpar->bits_per_coded_sample = 10;
         break;