Message ID | 20201210111657.2276739-15-andreas.rheinhardt@gmail.com |
---|---|
State | Accepted |
Commit | ebbdb928e88e160fddedf6eb182503bfefadb37d |
Headers | show |
Series | Make mpegvideo encoders init-threadsafe | expand |
Context | Check | Description |
---|---|---|
andriy/x86_make | success | Make finished |
andriy/x86_make_fate | success | Make fate finished |
On Thu, Dec 10, 2020 at 12:16:32PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavcodec/h261dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok assuming its not better to make H261_CBP_VLC_BITS smaller thx [...]
Michael Niedermayer: > On Thu, Dec 10, 2020 at 12:16:32PM +0100, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> >> --- >> libavcodec/h261dec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > ok assuming its not better to make H261_CBP_VLC_BITS smaller > > thx > > [...] > Honestly, I don't care either way. Do you have a preference? - Andreas
On Mon, Dec 21, 2020 at 12:57:17PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Dec 10, 2020 at 12:16:32PM +0100, Andreas Rheinhardt wrote: > >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > >> --- > >> libavcodec/h261dec.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > ok assuming its not better to make H261_CBP_VLC_BITS smaller > > > > thx > > > > [...] > > > Honestly, I don't care either way. Do you have a preference? no preference, apply what you prefer thx [...]
diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index dfa779b574..374d17dfba 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -431,7 +431,7 @@ static int h261_decode_mb(H261Context *h) // Read cbp if (HAS_CBP(h->mtype)) - cbp = get_vlc2(&s->gb, h261_cbp_vlc.table, H261_CBP_VLC_BITS, 2) + 1; + cbp = get_vlc2(&s->gb, h261_cbp_vlc.table, H261_CBP_VLC_BITS, 1) + 1; if (s->mb_intra) { s->current_picture.mb_type[xy] = MB_TYPE_INTRA;
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavcodec/h261dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)