Message ID | 20201115023653.17657-1-oddstone@gmail.com |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag | expand |
Context | Check | Description |
---|---|---|
andriy/x86_make | success | Make finished |
andriy/x86_make_fate | fail | Make fate failed |
andriy/PPC64_make | success | Make finished |
andriy/PPC64_make_fate | warning | Make fate failed |
Hi Guangxin, On Sun, Nov 15, 2020 at 11:07 AM Xu Guangxin <oddstone@gmail.com> wrote: > > you can download it from: > https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip > > Signed-off-by: Xu Guangxin <oddstone@gmail.com> > --- > tests/fate/hevc.mak | 1 + > .../hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 | 8 ++++++++ > 2 files changed, 9 insertions(+) > create mode 100644 tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak > index 9a32a7d74c..97edb49781 100644 > --- a/tests/fate/hevc.mak > +++ b/tests/fate/hevc.mak > @@ -141,6 +141,7 @@ HEVC_SAMPLES = \ > WPP_D_ericsson_MAIN_2 \ > WPP_E_ericsson_MAIN_2 \ > WPP_F_ericsson_MAIN_2 \ > + WPP_HIGH_TP_444_8BIT_RExt_Apple_2 \ > > HEVC_SAMPLES_10BIT = \ > DBLK_A_MAIN10_VIXS_3 \ > diff --git a/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > new file mode 100644 > index 0000000000..fcb1d2894a > --- /dev/null > +++ b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > @@ -0,0 +1,8 @@ > +#tb 0: 1/25 > +#media_type 0: video > +#codec_id 0: rawvideo > +#dimensions 0: 1024x768 > +#sar 0: 0/1 > +0, 0, 0, 1, 1179648, 0x78e55a69 > +0, 1, 1, 1, 1179648, 0x5babb3cb > +0, 2, 2, 1, 1179648, 0x65935648 > -- > 2.17.1 > For this sample, native hevc decoder doesn't support "High Throughput 4:4:4" (profile_idc = 5) yet: $ ffmpeg -i fate-suite/hevc-conformance/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.bit [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet implemented [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet implemented [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet implemented Hence the md5 result seems to be different from the reference in WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 - linjie
Hi Lingjie thanks for the review. The stream has the feature but not used. the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc it's matched with the WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 thanks On Thu, Dec 10, 2020 at 6:14 PM Linjie Fu <linjie.justin.fu@gmail.com> wrote: > Hi Guangxin, > > On Sun, Nov 15, 2020 at 11:07 AM Xu Guangxin <oddstone@gmail.com> wrote: > > > > you can download it from: > > > https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip > > > > Signed-off-by: Xu Guangxin <oddstone@gmail.com> > > --- > > tests/fate/hevc.mak | 1 + > > .../hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > create mode 100644 > tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > > > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak > > index 9a32a7d74c..97edb49781 100644 > > --- a/tests/fate/hevc.mak > > +++ b/tests/fate/hevc.mak > > @@ -141,6 +141,7 @@ HEVC_SAMPLES = \ > > WPP_D_ericsson_MAIN_2 \ > > WPP_E_ericsson_MAIN_2 \ > > WPP_F_ericsson_MAIN_2 \ > > + WPP_HIGH_TP_444_8BIT_RExt_Apple_2 \ > > > > HEVC_SAMPLES_10BIT = \ > > DBLK_A_MAIN10_VIXS_3 \ > > diff --git > a/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > > new file mode 100644 > > index 0000000000..fcb1d2894a > > --- /dev/null > > +++ b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 > > @@ -0,0 +1,8 @@ > > +#tb 0: 1/25 > > +#media_type 0: video > > +#codec_id 0: rawvideo > > +#dimensions 0: 1024x768 > > +#sar 0: 0/1 > > +0, 0, 0, 1, 1179648, 0x78e55a69 > > +0, 1, 1, 1, 1179648, 0x5babb3cb > > +0, 2, 2, 1, 1179648, 0x65935648 > > -- > > 2.17.1 > > > > For this sample, native hevc decoder doesn't support "High Throughput > 4:4:4" (profile_idc = 5) yet: > > $ ffmpeg -i > fate-suite/hevc-conformance/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.bit > [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 > [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet > implemented > [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 > [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet > implemented > [hevc @ 0x7fcf04818800] Unknown HEVC profile: 5 > [hevc @ 0x7fcf04818800] high_precision_offsets_enabled_flag not yet > implemented > > Hence the md5 result seems to be different from the reference in > WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 > > - linjie >
On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu <oddstone@gmail.com> wrote: > > Hi Lingjie > thanks for the review. > The stream has the feature but not used. > > the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc > it's matched with the WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 > Double checked, md5 is matched, and the related the descriptions in 9.3.1 and 9.3.2.4: For each Rice parameter initialization state k, each entry of the table tableStatCoeffSync is initialized to the corresponding value of StatCoeff[ k ]. Would like to push this patch firstly if no objections. The fate patch could be applied later if someone helps to upload the sample. - linjie
On Fri, Jan 1, 2021 at 9:39 PM Linjie Fu <linjie.justin.fu@gmail.com> wrote: > > On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu <oddstone@gmail.com> wrote: > > > > Hi Lingjie > > thanks for the review. > > The stream has the feature but not used. > > > > the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc > > it's matched with the WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 > > > > Double checked, md5 is matched, and the related the descriptions in > 9.3.1 and 9.3.2.4: > For each Rice parameter initialization state k, each entry of the > table tableStatCoeffSync is initialized to the corresponding value of > StatCoeff[ k ]. > > Would like to push this patch firstly if no objections. > The fate patch could be applied later if someone helps to upload the sample. Applied the functional patch, thx. - linjie
Awesome, thanks! On Mon, Jan 4, 2021 at 11:45 PM Linjie Fu <linjie.justin.fu@gmail.com> wrote: > On Fri, Jan 1, 2021 at 9:39 PM Linjie Fu <linjie.justin.fu@gmail.com> > wrote: > > > > On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu <oddstone@gmail.com> wrote: > > > > > > Hi Lingjie > > > thanks for the review. > > > The stream has the feature but not used. > > > > > > the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc > > > it's matched with the WPP_HIGH_TP_444_8BIT_RExt_Apple_2.md5 > > > > > > > Double checked, md5 is matched, and the related the descriptions in > > 9.3.1 and 9.3.2.4: > > For each Rice parameter initialization state k, each entry of the > > table tableStatCoeffSync is initialized to the corresponding value of > > StatCoeff[ k ]. > > > > Would like to push this patch firstly if no objections. > > The fate patch could be applied later if someone helps to upload the > sample. > Applied the functional patch, thx. > > - linjie >
diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 9a32a7d74c..97edb49781 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -141,6 +141,7 @@ HEVC_SAMPLES = \ WPP_D_ericsson_MAIN_2 \ WPP_E_ericsson_MAIN_2 \ WPP_F_ericsson_MAIN_2 \ + WPP_HIGH_TP_444_8BIT_RExt_Apple_2 \ HEVC_SAMPLES_10BIT = \ DBLK_A_MAIN10_VIXS_3 \ diff --git a/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 new file mode 100644 index 0000000000..fcb1d2894a --- /dev/null +++ b/tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 @@ -0,0 +1,8 @@ +#tb 0: 1/25 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 1024x768 +#sar 0: 0/1 +0, 0, 0, 1, 1179648, 0x78e55a69 +0, 1, 1, 1, 1179648, 0x5babb3cb +0, 2, 2, 1, 1179648, 0x65935648
you can download it from: https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/RExt/WPP_HIGH_TP_444_8BIT_RExt_Apple_2.zip Signed-off-by: Xu Guangxin <oddstone@gmail.com> --- tests/fate/hevc.mak | 1 + .../hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2 | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 tests/ref/fate/hevc-conformance-WPP_HIGH_TP_444_8BIT_RExt_Apple_2