diff mbox series

[FFmpeg-devel] lavfi/vflip: Support Bayer vertical flip

Message ID CAB0OVGrPg-eowR1nJLQXr_4_G-0HBgu0ZK90uwHGwsjBkSaXug@mail.gmail.com
State Accepted
Headers show
Series [FFmpeg-devel] lavfi/vflip: Support Bayer vertical flip | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Carl Eugen Hoyos Sept. 5, 2020, 7:15 p.m. UTC 
Hi!

Attached patch fixes ticket #8819.

Please comment, Carl Eugen
Subject: [PATCH] lavfi/vflip: Support Bayer vertical flip.

Fixes ticket #8819.
---
 libavfilter/vf_vflip.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

Comments

Carl Eugen Hoyos Jan. 25, 2021, 3:07 a.m. UTC | #1 
Am Sa., 5. Sept. 2020 um 21:15 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:

> Attached patch fixes ticket #8819.

Paul, I believe you had an objection but I forgot what it was...

Please comment, Carl Eugen
Paul B Mahol Jan. 25, 2021, 10:34 a.m. UTC | #2 
On Mon, Jan 25, 2021 at 4:07 AM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:

> Am Sa., 5. Sept. 2020 um 21:15 Uhr schrieb Carl Eugen Hoyos
> <ceffmpeg@gmail.com>:
>
> > Attached patch fixes ticket #8819.
>
> Paul, I believe you had an objection but I forgot what it was...
>

Have you benched with alternative solutions this memcpy version?


>
> Please comment, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Paul B Mahol Feb. 10, 2021, 6:49 p.m. UTC | #3 
Just apply this, it is very unlikely that there are faster ways.
Carl Eugen Hoyos Feb. 14, 2021, 11:23 p.m. UTC | #4 
Am Mi., 10. Feb. 2021 um 19:50 Uhr schrieb Paul B Mahol <onemda@gmail.com>:
>
> Just apply this, it is very unlikely that there are faster ways.

Thank you, patch applied.

Carl Eugen
diff mbox series

Patch

diff --git a/libavfilter/vf_vflip.c b/libavfilter/vf_vflip.c
index c7c39d3341..fb729142ab 100644
--- a/libavfilter/vf_vflip.c
+++ b/libavfilter/vf_vflip.c
@@ -33,6 +33,7 @@ 
 typedef struct FlipContext {
     const AVClass *class;
     int vsub;   ///< vertical chroma subsampling
+    int bayer;
 } FlipContext;
 
 static const AVOption vflip_options[] = {
@@ -47,6 +48,7 @@  static int config_input(AVFilterLink *link)
     const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(link->format);
 
     flip->vsub = desc->log2_chroma_h;
+    flip->bayer = !!(desc->flags & AV_PIX_FMT_FLAG_BAYER);
 
     return 0;
 }
@@ -74,11 +76,44 @@  static AVFrame *get_video_buffer(AVFilterLink *link, int w, int h)
     return frame;
 }
 
+static int flip_bayer(AVFilterLink *link, AVFrame *in)
+{
+    AVFilterContext *ctx  = link->dst;
+    AVFilterLink *outlink = ctx->outputs[0];
+    AVFrame *out;
+    uint8_t *inrow = in->data[0], *outrow;
+    int width, i, is16 = av_pix_fmt_desc_get(link->format)->comp[0].step > 1;
+    if (outlink->h & 1) {
+        av_log(ctx, AV_LOG_ERROR, "Bayer vertical flip needs even height\n");
+        return AVERROR_INVALIDDATA;
+    }
+
+    width = outlink->w << is16;
+    out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
+    if (!out) {
+        av_frame_free(&in);
+        return AVERROR(ENOMEM);
+    }
+    av_frame_copy_props(out, in);
+    outrow = out->data[0] + out->linesize[0] * (outlink->h - 2);
+    for (i = 0; i < outlink->h >> 1; i++) {
+        memcpy(outrow, inrow, width);
+        memcpy(outrow + out->linesize[0], inrow + in->linesize[0], width);
+        inrow  += 2 *  in->linesize[0];
+        outrow -= 2 * out->linesize[0];
+    }
+    av_frame_free(&in);
+    return ff_filter_frame(outlink, out);
+}
+
 static int filter_frame(AVFilterLink *link, AVFrame *frame)
 {
     FlipContext *flip = link->dst->priv;
     int i;
 
+    if (flip->bayer)
+        return flip_bayer(link, frame);
+
     for (i = 0; i < 4; i ++) {
         int vsub = i == 1 || i == 2 ? flip->vsub : 0;
         int height = AV_CEIL_RSHIFT(link->h, vsub);