| Message ID | 20210131050123.661-1-ffmpeg@gyani.pro |
|---|---|
| State | Accepted |
| Commit | d16b0a4bf0830db852ce404210e293f6ae26559f |
| Headers | show |
| Series | [FFmpeg-devel] ffmpeg: remove dead code for -vol | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
On Sun, Jan 31, 2021 at 1:01 PM Gyan Doshi <ffmpeg@gyani.pro> wrote: > > It is applied via configure_input_audio_filter() > --- > fftools/ffmpeg_filter.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c > index e9e31e043e..1cba3055cc 100644 > --- a/fftools/ffmpeg_filter.c > +++ b/fftools/ffmpeg_filter.c > @@ -641,13 +641,6 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter, > pad_idx = 0; > } > > - if (audio_volume != 256 && 0) { > - char args[256]; > - > - snprintf(args, sizeof(args), "%f", audio_volume / 256.); > - AUTO_INSERT_FILTER("-vol", "volume", args); > - } > - > if (ost->apad && of->shortest) { > char args[256]; > int i; > -- > 2.30.0 LGTM
On 31-01-2021 04:01 pm, mypopy@gmail.com wrote: > On Sun, Jan 31, 2021 at 1:01 PM Gyan Doshi <ffmpeg@gyani.pro> wrote: >> It is applied via configure_input_audio_filter() >> --- >> fftools/ffmpeg_filter.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c >> index e9e31e043e..1cba3055cc 100644 >> --- a/fftools/ffmpeg_filter.c >> +++ b/fftools/ffmpeg_filter.c >> @@ -641,13 +641,6 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter, >> pad_idx = 0; >> } >> >> - if (audio_volume != 256 && 0) { >> - char args[256]; >> - >> - snprintf(args, sizeof(args), "%f", audio_volume / 256.); >> - AUTO_INSERT_FILTER("-vol", "volume", args); >> - } >> - >> if (ost->apad && of->shortest) { >> char args[256]; >> int i; >> -- >> 2.30.0 > LGTM Thanks. Pushed as d16b0a4bf0830db852ce404210e293f6ae26559f Regards, Gyan
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index e9e31e043e..1cba3055cc 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -641,13 +641,6 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter, pad_idx = 0; } - if (audio_volume != 256 && 0) { - char args[256]; - - snprintf(args, sizeof(args), "%f", audio_volume / 256.); - AUTO_INSERT_FILTER("-vol", "volume", args); - } - if (ost->apad && of->shortest) { char args[256]; int i;