| Message ID | 20210306232619.5963-7-cus@passwd.hu |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/7] libavformat: add librist protocol | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
How you tested this? And why you have not asked nicely before taking working on this? On Sun, Mar 7, 2021 at 12:28 AM Marton Balint <cus@passwd.hu> wrote: > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > Changelog | 1 + > libavformat/version.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Changelog b/Changelog > index b28a8c59f1..b4d3258be7 100644 > --- a/Changelog > +++ b/Changelog > @@ -81,6 +81,7 @@ version <next>: > - TTML subtitle encoder and muxer > - identity video filter > - msad video filter > +- RIST protocol via librist > > > version 4.3: > diff --git a/libavformat/version.h b/libavformat/version.h > index a05676d979..2a2804582c 100644 > --- a/libavformat/version.h > +++ b/libavformat/version.h > @@ -32,7 +32,7 @@ > // Major bumping may affect Ticket5467, 5421, 5451(compatibility with > Chromium) > // Also please add any ticket numbers that you believe might be affected > here > #define LIBAVFORMAT_VERSION_MAJOR 58 > -#define LIBAVFORMAT_VERSION_MINOR 71 > +#define LIBAVFORMAT_VERSION_MINOR 72 > #define LIBAVFORMAT_VERSION_MICRO 100 > > #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, > \ > -- > 2.26.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 3/6/2021 8:47 PM, Paul B Mahol wrote: > How you tested this? > > And why you have not asked nicely before taking working on this? He took your patch, included it without changes and with proper authorship, and worked on top of it. It's no different than sending only patches 2 to 6 after you committed 1. But i agree he could have asked first if you were still working on it in order to not do duplicate or incompatible work. > > On Sun, Mar 7, 2021 at 12:28 AM Marton Balint <cus@passwd.hu> wrote: > >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> Changelog | 1 + >> libavformat/version.h | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Changelog b/Changelog >> index b28a8c59f1..b4d3258be7 100644 >> --- a/Changelog >> +++ b/Changelog >> @@ -81,6 +81,7 @@ version <next>: >> - TTML subtitle encoder and muxer >> - identity video filter >> - msad video filter >> +- RIST protocol via librist >> >> >> version 4.3: >> diff --git a/libavformat/version.h b/libavformat/version.h >> index a05676d979..2a2804582c 100644 >> --- a/libavformat/version.h >> +++ b/libavformat/version.h >> @@ -32,7 +32,7 @@ >> // Major bumping may affect Ticket5467, 5421, 5451(compatibility with >> Chromium) >> // Also please add any ticket numbers that you believe might be affected >> here >> #define LIBAVFORMAT_VERSION_MAJOR 58 >> -#define LIBAVFORMAT_VERSION_MINOR 71 >> +#define LIBAVFORMAT_VERSION_MINOR 72 >> #define LIBAVFORMAT_VERSION_MICRO 100 >> >> #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, >> \ >> -- >> 2.26.2 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
On Sun, 7 Mar 2021, Paul B Mahol wrote: > How you tested this? with the librist tools. > > And why you have not asked nicely before taking working on this? You wrote you have given up. It is your behaviour which is not very nice. After your continuous ignorance of my requests, I try to help your work get merged, and this is your feedback... Regards, Marton
On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > > > How you tested this? > > with the librist tools. > > > > > And why you have not asked nicely before taking working on this? > > You wrote you have given up. It is your behaviour which is not very nice. > After your continuous ignorance of my requests, I try to help your work > get merged, and this is your feedback... > Why are you so aggressive? Other devs raised issues that looks not resolved. > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 3/6/2021 9:51 PM, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >>> How you tested this? >> >> with the librist tools. >> >>> >>> And why you have not asked nicely before taking working on this? >> >> You wrote you have given up. It is your behaviour which is not very nice. >> After your continuous ignorance of my requests, I try to help your work >> get merged, and this is your feedback... >> > > > Why are you so aggressive? Other devs raised issues that looks not resolved. I don't see aggressiveness from his part. I see you making things incredibly more complex than they should be.
On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> wrote: > On 3/6/2021 9:51 PM, Paul B Mahol wrote: > > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: > > > >> > >> > >> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> > >>> How you tested this? > >> > >> with the librist tools. > >> > >>> > >>> And why you have not asked nicely before taking working on this? > >> > >> You wrote you have given up. It is your behaviour which is not very > nice. > >> After your continuous ignorance of my requests, I try to help your work > >> get merged, and this is your feedback... > >> > > > > > > Why are you so aggressive? Other devs raised issues that looks not > resolved. > > I don't see aggressiveness from his part. I see you making things > incredibly more complex than they should be. > The code in functional part is not much different from initial versions. So I really doubt that fifo filling up issue have been properly addressed.
On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: >> > >> >> >> >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> >> >>> How you tested this? >> >> >> >> with the librist tools. >> >> >> >>> >> >>> And why you have not asked nicely before taking working on this? >> >> >> >> You wrote you have given up. It is your behaviour which is not very >> nice. >> >> After your continuous ignorance of my requests, I try to help your work >> >> get merged, and this is your feedback... >> >> >> > >> > >> > Why are you so aggressive? Other devs raised issues that looks not >> resolved. >> >> I don't see aggressiveness from his part. I see you making things >> incredibly more complex than they should be. >> > > The code in functional part is not much different from initial versions. > > So I really doubt that fifo filling up issue have been properly addressed. I can take a look at that if you provide command lines to reproduce. Regards, Marton
On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > > > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> wrote: > > > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: > >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: > >> > > >> >> > >> >> > >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> >> > >> >>> How you tested this? > >> >> > >> >> with the librist tools. > >> >> > >> >>> > >> >>> And why you have not asked nicely before taking working on this? > >> >> > >> >> You wrote you have given up. It is your behaviour which is not very > >> nice. > >> >> After your continuous ignorance of my requests, I try to help your > work > >> >> get merged, and this is your feedback... > >> >> > >> > > >> > > >> > Why are you so aggressive? Other devs raised issues that looks not > >> resolved. > >> > >> I don't see aggressiveness from his part. I see you making things > >> incredibly more complex than they should be. > >> > > > > The code in functional part is not much different from initial versions. > > > > So I really doubt that fifo filling up issue have been properly > addressed. > > I can take a look at that if you provide command lines to reproduce. > I couldn't reproduce it, so you have to ask others. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> wrote: >> > >> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: >> >> > >> >> >> >> >> >> >> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> >> >> >> >>> How you tested this? >> >> >> >> >> >> with the librist tools. >> >> >> >> >> >>> >> >> >>> And why you have not asked nicely before taking working on this? >> >> >> >> >> >> You wrote you have given up. It is your behaviour which is not very >> >> nice. >> >> >> After your continuous ignorance of my requests, I try to help your >> work >> >> >> get merged, and this is your feedback... >> >> >> >> >> > >> >> > >> >> > Why are you so aggressive? Other devs raised issues that looks not >> >> resolved. >> >> >> >> I don't see aggressiveness from his part. I see you making things >> >> incredibly more complex than they should be. >> >> >> > >> > The code in functional part is not much different from initial versions. >> > >> > So I really doubt that fifo filling up issue have been properly >> addressed. >> >> I can take a look at that if you provide command lines to reproduce. >> > > I couldn't reproduce it, so you have to ask others. I found one issue in librist code which can be related and might cause ffmpeg not to recover from a fifo fillup. I have reported it here: https://code.videolan.org/rist/librist/-/issues/93 Regards, Marton
On Sun, 7 Mar 2021, Marton Balint wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: >> >>> >>> >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: >>> >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> wrote: >>> > >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> wrote: >>> >> > >>> >> >> >>> >> >> >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >>> >> >> >>> >> >>> How you tested this? >>> >> >> >>> >> >> with the librist tools. >>> >> >> >>> >> >>> >>> >> >>> And why you have not asked nicely before taking working on this? >>> >> >> >>> >> >> You wrote you have given up. It is your behaviour which is not very >>> >> nice. >>> >> >> After your continuous ignorance of my requests, I try to help your >>> work >>> >> >> get merged, and this is your feedback... >>> >> >> >>> >> > >>> >> > >>> >> > Why are you so aggressive? Other devs raised issues that looks not >>> >> resolved. >>> >> >>> >> I don't see aggressiveness from his part. I see you making things >>> >> incredibly more complex than they should be. >>> >> >>> > >>> > The code in functional part is not much different from initial versions. >>> > >>> > So I really doubt that fifo filling up issue have been properly >>> addressed. >>> >>> I can take a look at that if you provide command lines to reproduce. >>> >> >> I couldn't reproduce it, so you have to ask others. > > I found one issue in librist code which can be related and might cause > ffmpeg not to recover from a fifo fillup. I have reported it here: > > https://code.videolan.org/rist/librist/-/issues/93 I'd love to see rist support in 4.4, so maybe we should apply this series as is and fix any remaining issues later... Regards, Marton
On Fri, Mar 12, 2021 at 12:21 AM Marton Balint <cus@passwd.hu> wrote: > > > On Sun, 7 Mar 2021, Marton Balint wrote: > > > > > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > > > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: > >> > >>> > >>> > >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >>> > >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> > wrote: > >>> > > >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: > >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> > wrote: > >>> >> > > >>> >> >> > >>> >> >> > >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >>> >> >> > >>> >> >>> How you tested this? > >>> >> >> > >>> >> >> with the librist tools. > >>> >> >> > >>> >> >>> > >>> >> >>> And why you have not asked nicely before taking working on this? > >>> >> >> > >>> >> >> You wrote you have given up. It is your behaviour which is not > very > >>> >> nice. > >>> >> >> After your continuous ignorance of my requests, I try to help > your > >>> work > >>> >> >> get merged, and this is your feedback... > >>> >> >> > >>> >> > > >>> >> > > >>> >> > Why are you so aggressive? Other devs raised issues that looks not > >>> >> resolved. > >>> >> > >>> >> I don't see aggressiveness from his part. I see you making things > >>> >> incredibly more complex than they should be. > >>> >> > >>> > > >>> > The code in functional part is not much different from initial > versions. > >>> > > >>> > So I really doubt that fifo filling up issue have been properly > >>> addressed. > >>> > >>> I can take a look at that if you provide command lines to reproduce. > >>> > >> > >> I couldn't reproduce it, so you have to ask others. > > > > I found one issue in librist code which can be related and might cause > > ffmpeg not to recover from a fifo fillup. I have reported it here: > > > > https://code.videolan.org/rist/librist/-/issues/93 > > I'd love to see rist support in 4.4, so maybe we should apply this series > as is and fix any remaining issues later... > Not gonna block it. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Fri, 12 Mar 2021, Paul B Mahol wrote: > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Sun, 7 Mar 2021, Marton Balint wrote: >> >> > >> > >> > On Sun, 7 Mar 2021, Paul B Mahol wrote: >> > >> >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: >> >> >> >>> >> >>> >> >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >>> >> >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> >> wrote: >> >>> > >> >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> >> wrote: >> >>> >> > >> >>> >> >> >> >>> >> >> >> >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >>> >> >> >> >>> >> >>> How you tested this? >> >>> >> >> >> >>> >> >> with the librist tools. >> >>> >> >> >> >>> >> >>> >> >>> >> >>> And why you have not asked nicely before taking working on this? >> >>> >> >> >> >>> >> >> You wrote you have given up. It is your behaviour which is not >> very >> >>> >> nice. >> >>> >> >> After your continuous ignorance of my requests, I try to help >> your >> >>> work >> >>> >> >> get merged, and this is your feedback... >> >>> >> >> >> >>> >> > >> >>> >> > >> >>> >> > Why are you so aggressive? Other devs raised issues that looks not >> >>> >> resolved. >> >>> >> >> >>> >> I don't see aggressiveness from his part. I see you making things >> >>> >> incredibly more complex than they should be. >> >>> >> >> >>> > >> >>> > The code in functional part is not much different from initial >> versions. >> >>> > >> >>> > So I really doubt that fifo filling up issue have been properly >> >>> addressed. >> >>> >> >>> I can take a look at that if you provide command lines to reproduce. >> >>> >> >> >> >> I couldn't reproduce it, so you have to ask others. >> > >> > I found one issue in librist code which can be related and might cause >> > ffmpeg not to recover from a fifo fillup. I have reported it here: >> > >> > https://code.videolan.org/rist/librist/-/issues/93 >> >> I'd love to see rist support in 4.4, so maybe we should apply this series >> as is and fix any remaining issues later... >> > > > Not gonna block it. OK, will apply. Thanks, Marton
On Sat, Mar 13, 2021 at 5:56 PM Marton Balint <cus@passwd.hu> wrote: > > > On Fri, 12 Mar 2021, Paul B Mahol wrote: > > > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint <cus@passwd.hu> wrote: > > > >> > >> > >> On Sun, 7 Mar 2021, Marton Balint wrote: > >> > >> > > >> > > >> > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> > > >> >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: > >> >> > >> >>> > >> >>> > >> >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> >>> > >> >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> > >> wrote: > >> >>> > > >> >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: > >> >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> > >> wrote: > >> >>> >> > > >> >>> >> >> > >> >>> >> >> > >> >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> >>> >> >> > >> >>> >> >>> How you tested this? > >> >>> >> >> > >> >>> >> >> with the librist tools. > >> >>> >> >> > >> >>> >> >>> > >> >>> >> >>> And why you have not asked nicely before taking working on > this? > >> >>> >> >> > >> >>> >> >> You wrote you have given up. It is your behaviour which is not > >> very > >> >>> >> nice. > >> >>> >> >> After your continuous ignorance of my requests, I try to help > >> your > >> >>> work > >> >>> >> >> get merged, and this is your feedback... > >> >>> >> >> > >> >>> >> > > >> >>> >> > > >> >>> >> > Why are you so aggressive? Other devs raised issues that looks > not > >> >>> >> resolved. > >> >>> >> > >> >>> >> I don't see aggressiveness from his part. I see you making things > >> >>> >> incredibly more complex than they should be. > >> >>> >> > >> >>> > > >> >>> > The code in functional part is not much different from initial > >> versions. > >> >>> > > >> >>> > So I really doubt that fifo filling up issue have been properly > >> >>> addressed. > >> >>> > >> >>> I can take a look at that if you provide command lines to reproduce. > >> >>> > >> >> > >> >> I couldn't reproduce it, so you have to ask others. > >> > > >> > I found one issue in librist code which can be related and might cause > >> > ffmpeg not to recover from a fifo fillup. I have reported it here: > >> > > >> > https://code.videolan.org/rist/librist/-/issues/93 > >> > >> I'd love to see rist support in 4.4, so maybe we should apply this > series > >> as is and fix any remaining issues later... > >> > > > > > > Not gonna block it. > > OK, will apply. > IIRC librist have not released new release yet, and configure check does not check for new functions that are required for building. > > Thanks, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Sat, 13 Mar 2021, Paul B Mahol wrote: > On Sat, Mar 13, 2021 at 5:56 PM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Fri, 12 Mar 2021, Paul B Mahol wrote: >> >> > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint <cus@passwd.hu> wrote: >> > >> >> >> >> >> >> On Sun, 7 Mar 2021, Marton Balint wrote: >> >> >> >> > >> >> > >> >> > On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> > >> >> >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus@passwd.hu> wrote: >> >> >> >> >> >>> >> >> >>> >> >> >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> >>> >> >> >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial@gmail.com> >> >> wrote: >> >> >>> > >> >> >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> >> >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus@passwd.hu> >> >> wrote: >> >> >>> >> > >> >> >>> >> >> >> >> >>> >> >> >> >> >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote: >> >> >>> >> >> >> >> >>> >> >>> How you tested this? >> >> >>> >> >> >> >> >>> >> >> with the librist tools. >> >> >>> >> >> >> >> >>> >> >>> >> >> >>> >> >>> And why you have not asked nicely before taking working on >> this? >> >> >>> >> >> >> >> >>> >> >> You wrote you have given up. It is your behaviour which is not >> >> very >> >> >>> >> nice. >> >> >>> >> >> After your continuous ignorance of my requests, I try to help >> >> your >> >> >>> work >> >> >>> >> >> get merged, and this is your feedback... >> >> >>> >> >> >> >> >>> >> > >> >> >>> >> > >> >> >>> >> > Why are you so aggressive? Other devs raised issues that looks >> not >> >> >>> >> resolved. >> >> >>> >> >> >> >>> >> I don't see aggressiveness from his part. I see you making things >> >> >>> >> incredibly more complex than they should be. >> >> >>> >> >> >> >>> > >> >> >>> > The code in functional part is not much different from initial >> >> versions. >> >> >>> > >> >> >>> > So I really doubt that fifo filling up issue have been properly >> >> >>> addressed. >> >> >>> >> >> >>> I can take a look at that if you provide command lines to reproduce. >> >> >>> >> >> >> >> >> >> I couldn't reproduce it, so you have to ask others. >> >> > >> >> > I found one issue in librist code which can be related and might cause >> >> > ffmpeg not to recover from a fifo fillup. I have reported it here: >> >> > >> >> > https://code.videolan.org/rist/librist/-/issues/93 >> >> >> >> I'd love to see rist support in 4.4, so maybe we should apply this >> series >> >> as is and fix any remaining issues later... >> >> >> > >> > >> > Not gonna block it. >> >> OK, will apply. >> > > IIRC librist have not released new release yet, and configure check does > not check for new functions that are required for building. They are still at 0.2 RC something and we require 0.2. I thought that means the stable 0.2 release, so we are good. But yes, if somebody uses an earlier RC from git, it might not work correctly. Is that something we should fix? I am not sure. Regards, Marton
diff --git a/Changelog b/Changelog index b28a8c59f1..b4d3258be7 100644 --- a/Changelog +++ b/Changelog @@ -81,6 +81,7 @@ version <next>: - TTML subtitle encoder and muxer - identity video filter - msad video filter +- RIST protocol via librist version 4.3: diff --git a/libavformat/version.h b/libavformat/version.h index a05676d979..2a2804582c 100644 --- a/libavformat/version.h +++ b/libavformat/version.h @@ -32,7 +32,7 @@ // Major bumping may affect Ticket5467, 5421, 5451(compatibility with Chromium) // Also please add any ticket numbers that you believe might be affected here #define LIBAVFORMAT_VERSION_MAJOR 58 -#define LIBAVFORMAT_VERSION_MINOR 71 +#define LIBAVFORMAT_VERSION_MINOR 72 #define LIBAVFORMAT_VERSION_MICRO 100 #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \
Signed-off-by: Marton Balint <cus@passwd.hu> --- Changelog | 1 + libavformat/version.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)