diff mbox series

[FFmpeg-devel] libavcodec/amfenc_hevc: Recommend values for min and max video quantizer scale.

Message ID 20210309190507.1415-1-ovchinnikov.dmitrii@gmail.com
State Accepted
Commit 1a549efefb590a83b2516dfd287dbda4e8d6b846
Headers show
Series [FFmpeg-devel] libavcodec/amfenc_hevc: Recommend values for min and max video quantizer scale. | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Dmitrii Ovchinnikov March 9, 2021, 7:05 p.m. UTC 
Current settings makes bitrate large, than expected, more information:
https://github.com/HandBrake/HandBrake/issues/3447#issue-820490736
Thanks for review! updated to "-1" values.

---
 libavcodec/amfenc_hevc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer March 9, 2021, 7:15 p.m. UTC | #1 
On 3/9/2021 4:05 PM, Ovchinnikov Dmitrii wrote:
> Current settings makes bitrate large, than expected, more information:
> https://github.com/HandBrake/HandBrake/issues/3447#issue-820490736
> Thanks for review! updated to "-1" values.
> 
> ---
>   libavcodec/amfenc_hevc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c
> index 77e57d2461..890272d135 100644
> --- a/libavcodec/amfenc_hevc.c
> +++ b/libavcodec/amfenc_hevc.c
> @@ -298,6 +298,8 @@ static const AVCodecDefault defaults[] = {
>       { "b",          "2M"  },
>       { "g",          "250" },
>       { "slices",     "1"   },
> +    { "qmin",       "-1"  },
> +    { "qmax",       "-1"  },
>       { NULL                },
>   };
>   static const AVClass hevc_amf_class = {

Applied, thanks.
diff mbox series

Patch

diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c
index 77e57d2461..890272d135 100644
--- a/libavcodec/amfenc_hevc.c
+++ b/libavcodec/amfenc_hevc.c
@@ -298,6 +298,8 @@  static const AVCodecDefault defaults[] = {
     { "b",          "2M"  },
     { "g",          "250" },
     { "slices",     "1"   },
+    { "qmin",       "-1"  },
+    { "qmax",       "-1"  },
     { NULL                },
 };
 static const AVClass hevc_amf_class = {