diff mbox series

[FFmpeg-devel,FFmpeg-web] web/download: add signing key and verification instructions

Message ID d279ab96-576a-2947-7de3-043e0d201ad1@zanevaniperen.com
State Accepted
Headers show
Series [FFmpeg-devel,FFmpeg-web] web/download: add signing key and verification instructions | expand

Checks

Context Check Description
andriy/configure warning Failed to apply patch

Commit Message

Zane van Iperen Feb. 24, 2021, 4:06 a.m. UTC
As per discussion at [1]. Patches attached.

Patch 1/3 adds /node_modules/ to .gitignore

Patch 2/3 adds the actual key and verification instructions

Patch 3/3 adds a prominent download link for the public key.
This might be bit obnoxious, but it was suggested in the original discussion.

[1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276752.html
Subject: [PATCH 1/3] gitignore: add /node_modules/

Signed-off-by: Zane van Iperen <zane@zanevaniperen.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Thilo Borgmann Feb. 24, 2021, 4:53 p.m. UTC | #1
Am 24.02.21 um 05:06 schrieb Zane van Iperen:
> As per discussion at [1]. Patches attached.
> 
> Patch 1/3 adds /node_modules/ to .gitignore
> 
> Patch 2/3 adds the actual key and verification instructions
> 
> Patch 3/3 adds a prominent download link for the public key.
> This might be bit obnoxious, but it was suggested in the original discussion.
> 
> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276752.html

As in [1] above I like that idea. However, I can't really comment on the technical side of keys and signatures. So proper someones opinion with actual knowledge would be appreciated.

Thanks!
-Thilo
Thilo Borgmann March 8, 2021, 1:24 p.m. UTC | #2
Am 24.02.21 um 17:53 schrieb Thilo Borgmann:
> Am 24.02.21 um 05:06 schrieb Zane van Iperen:
>> As per discussion at [1]. Patches attached.
>>
>> Patch 1/3 adds /node_modules/ to .gitignore
>>
>> Patch 2/3 adds the actual key and verification instructions
>>
>> Patch 3/3 adds a prominent download link for the public key.
>> This might be bit obnoxious, but it was suggested in the original discussion.
>>
>> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276752.html
> 
> As in [1] above I like that idea. However, I can't really comment on the technical side of keys and signatures. So proper someones opinion with actual knowledge would be appreciated.

If there are no complains, I'll push that soon (tm).

-Thilo
Zane van Iperen March 10, 2021, 8:25 a.m. UTC | #3
Before you do, just give it a crack locally.

I couldn't get the cloned version of the site to look identical to what's already published (something to do with 
incorrect CSS symlinks iirc). It's probably fine, but for something like this I'd rather err on the side of caution.

Zane


On 8/3/21 11:24 pm, Thilo Borgmann wrote:
> Am 24.02.21 um 17:53 schrieb Thilo Borgmann:
>> Am 24.02.21 um 05:06 schrieb Zane van Iperen:
>>> As per discussion at [1]. Patches attached.
>>>
>>> Patch 1/3 adds /node_modules/ to .gitignore
>>>
>>> Patch 2/3 adds the actual key and verification instructions
>>>
>>> Patch 3/3 adds a prominent download link for the public key.
>>> This might be bit obnoxious, but it was suggested in the original discussion.
>>>
>>> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276752.html
>>
>> As in [1] above I like that idea. However, I can't really comment on the technical side of keys and signatures. So proper someones opinion with actual knowledge would be appreciated.
> 
> If there are no complains, I'll push that soon (tm).
> 
> -Thilo
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Thilo Borgmann March 10, 2021, 5:19 p.m. UTC | #4
Am 10.03.21 um 09:25 schrieb Zane van Iperen:
> Before you do, just give it a crack locally.
> 
> I couldn't get the cloned version of the site to look identical to what's already published (something to do with incorrect CSS symlinks iirc). It's probably fine, but for something like this I'd rather err on the side of caution.

I know this problem and I'm happily ignoring it - because the style thingys are living happily on the server and look like intended.

So I don't expect any problems. If so, its the website being a bit more ugly for maybe some short time...
Not doing it today anyway, so you can still test on if you feel the desire to get a 1:1 website locally.

-Thilo

> 
> On 8/3/21 11:24 pm, Thilo Borgmann wrote:
>> Am 24.02.21 um 17:53 schrieb Thilo Borgmann:
>>> Am 24.02.21 um 05:06 schrieb Zane van Iperen:
>>>> As per discussion at [1]. Patches attached.
>>>>
>>>> Patch 1/3 adds /node_modules/ to .gitignore
>>>>
>>>> Patch 2/3 adds the actual key and verification instructions
>>>>
>>>> Patch 3/3 adds a prominent download link for the public key.
>>>> This might be bit obnoxious, but it was suggested in the original discussion.
>>>>
>>>> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276752.html
>>>
>>> As in [1] above I like that idea. However, I can't really comment on the technical side of keys and signatures. So proper someones opinion with actual knowledge would be appreciated.
>>
>> If there are no complains, I'll push that soon (tm).
>>
>> -Thilo
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Thilo Borgmann March 16, 2021, 1:31 p.m. UTC | #5
Am 10.03.21 um 18:19 schrieb Thilo Borgmann:
> Am 10.03.21 um 09:25 schrieb Zane van Iperen:
>> Before you do, just give it a crack locally.
>>
>> I couldn't get the cloned version of the site to look identical to what's already published (something to do with incorrect CSS symlinks iirc). It's probably fine, but for something like this I'd rather err on the side of caution.
> 
> I know this problem and I'm happily ignoring it - because the style thingys are living happily on the server and look like intended.
> 
> So I don't expect any problems. If so, its the website being a bit more ugly for maybe some short time...
> Not doing it today anyway, so you can still test on if you feel the desire to get a 1:1 website locally.

Pushed. I don't see any bad thing on ffmpeg.org, please check.

-Thilo
Zane van Iperen March 16, 2021, 11:44 p.m. UTC | #6
On 16/3/21 11:31 pm, Thilo Borgmann wrote:
> Am 10.03.21 um 18:19 schrieb Thilo Borgmann:
>> Am 10.03.21 um 09:25 schrieb Zane van Iperen:
>>> Before you do, just give it a crack locally.
>>>
>>> I couldn't get the cloned version of the site to look identical to what's already published (something to do with incorrect CSS symlinks iirc). It's probably fine, but for something like this I'd rather err on the side of caution.
>>
>> I know this problem and I'm happily ignoring it - because the style thingys are living happily on the server and look like intended.
>>
>> So I don't expect any problems. If so, its the website being a bit more ugly for maybe some short time...
>> Not doing it today anyway, so you can still test on if you feel the desire to get a 1:1 website locally.
> 
> Pushed. I don't see any bad thing on ffmpeg.org, please check.

Look all good to me.
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index b215828..60a2b0a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@ 
 /htdocs/components
 /htdocs/style.less
 /htdocs/fonts/*.woff2
+/node_modules/