| Message ID | 20210311164046.53036-1-jamrial@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9e2e6f935bed329a7c2eabae7de02cccd88e2f26 |
| Headers | show |
| Series | [FFmpeg-devel] avdevice/decklink: add missing include for buffer_size_t | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
On 3/11/2021 1:40 PM, James Almer wrote: > Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavdevice/decklink_dec.cpp | 1 + > libavdevice/decklink_enc.cpp | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp > index 6c0a338fca..0262b2f16a 100644 > --- a/libavdevice/decklink_dec.cpp > +++ b/libavdevice/decklink_dec.cpp > @@ -39,6 +39,7 @@ extern "C" { > #include "libavutil/avassert.h" > #include "libavutil/avutil.h" > #include "libavutil/common.h" > +#include "libavutil/internal.h" > #include "libavutil/imgutils.h" > #include "libavutil/intreadwrite.h" > #include "libavutil/time.h" > diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp > index df901b0d68..114c3e1a8c 100644 > --- a/libavdevice/decklink_enc.cpp > +++ b/libavdevice/decklink_enc.cpp > @@ -32,6 +32,7 @@ extern "C" { > > extern "C" { > #include "libavformat/avformat.h" > +#include "libavutil/internal.h" > #include "libavutil/imgutils.h" > #include "avdevice.h" > } Will apply soon since it fixes coverity builds.
On Thu, 11 Mar 2021, James Almer wrote: > On 3/11/2021 1:40 PM, James Almer wrote: >> Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> libavdevice/decklink_dec.cpp | 1 + >> libavdevice/decklink_enc.cpp | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp >> index 6c0a338fca..0262b2f16a 100644 >> --- a/libavdevice/decklink_dec.cpp >> +++ b/libavdevice/decklink_dec.cpp >> @@ -39,6 +39,7 @@ extern "C" { >> #include "libavutil/avassert.h" >> #include "libavutil/avutil.h" >> #include "libavutil/common.h" >> +#include "libavutil/internal.h" >> #include "libavutil/imgutils.h" >> #include "libavutil/intreadwrite.h" >> #include "libavutil/time.h" >> diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp >> index df901b0d68..114c3e1a8c 100644 >> --- a/libavdevice/decklink_enc.cpp >> +++ b/libavdevice/decklink_enc.cpp >> @@ -32,6 +32,7 @@ extern "C" { >> >> extern "C" { >> #include "libavformat/avformat.h" >> +#include "libavutil/internal.h" >> #include "libavutil/imgutils.h" >> #include "avdevice.h" >> } > > Will apply soon since it fixes coverity builds. LGTM, thanks. Marton
On 3/11/2021 5:37 PM, Marton Balint wrote: > > > On Thu, 11 Mar 2021, James Almer wrote: > >> On 3/11/2021 1:40 PM, James Almer wrote: >>> Should fix compilation broken in >>> f7abb53cb427515faac582f114ab97cbbd590280. >>> >>> Signed-off-by: James Almer <jamrial@gmail.com> >>> --- >>> libavdevice/decklink_dec.cpp | 1 + >>> libavdevice/decklink_enc.cpp | 1 + >>> 2 files changed, 2 insertions(+) >>> >>> diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp >>> index 6c0a338fca..0262b2f16a 100644 >>> --- a/libavdevice/decklink_dec.cpp >>> +++ b/libavdevice/decklink_dec.cpp >>> @@ -39,6 +39,7 @@ extern "C" { >>> #include "libavutil/avassert.h" >>> #include "libavutil/avutil.h" >>> #include "libavutil/common.h" >>> +#include "libavutil/internal.h" >>> #include "libavutil/imgutils.h" >>> #include "libavutil/intreadwrite.h" >>> #include "libavutil/time.h" >>> diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp >>> index df901b0d68..114c3e1a8c 100644 >>> --- a/libavdevice/decklink_enc.cpp >>> +++ b/libavdevice/decklink_enc.cpp >>> @@ -32,6 +32,7 @@ extern "C" { >>> >>> extern "C" { >>> #include "libavformat/avformat.h" >>> +#include "libavutil/internal.h" >>> #include "libavutil/imgutils.h" >>> #include "avdevice.h" >>> } >> >> Will apply soon since it fixes coverity builds. > > LGTM, thanks. > > Marton Pushed, thanks.
diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 6c0a338fca..0262b2f16a 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_dec.cpp @@ -39,6 +39,7 @@ extern "C" { #include "libavutil/avassert.h" #include "libavutil/avutil.h" #include "libavutil/common.h" +#include "libavutil/internal.h" #include "libavutil/imgutils.h" #include "libavutil/intreadwrite.h" #include "libavutil/time.h" diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index df901b0d68..114c3e1a8c 100644 --- a/libavdevice/decklink_enc.cpp +++ b/libavdevice/decklink_enc.cpp @@ -32,6 +32,7 @@ extern "C" { extern "C" { #include "libavformat/avformat.h" +#include "libavutil/internal.h" #include "libavutil/imgutils.h" #include "avdevice.h" }
Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer <jamrial@gmail.com> --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2 insertions(+)