diff mbox series

[FFmpeg-devel,9/9] avcodec/cbs_h26[45]: Remove redundant enum constants

Message ID 20210310102901.1150707-1-andreas.rheinhardt@gmail.com
State Accepted
Commit ec54c32d4a13689678e99cccda3cbaae3af0df52
Headers show
Series [FFmpeg-devel,1/8] avcodec/cbs: Remove redundant checks for CodedBitstreamContext.codec | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt March 10, 2021, 10:29 a.m. UTC
Unused since 8843607f495c95c1e67a3ce3d6f15dca6e252439.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/cbs_h264.h | 10 ----------
 libavcodec/cbs_h265.h |  9 ---------
 2 files changed, 19 deletions(-)

Comments

Mark Thompson March 12, 2021, 10:20 p.m. UTC | #1
On 10/03/2021 10:29, Andreas Rheinhardt wrote:
> Unused since 8843607f495c95c1e67a3ce3d6f15dca6e252439.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>   libavcodec/cbs_h264.h | 10 ----------
>   libavcodec/cbs_h265.h |  9 ---------
>   2 files changed, 19 deletions(-)
> 
> diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h
> index 9eb97eae24..5a8641a333 100644
> --- a/libavcodec/cbs_h264.h
> +++ b/libavcodec/cbs_h264.h
> @@ -28,16 +28,6 @@
>   #include "h264.h"
>   
>   
> -enum {
> -    // This limit is arbitrary - it is sufficient for one message of each
> -    // type plus some repeats, and will therefore easily cover all sane
> -    // streams.  However, it is possible to make technically-valid streams
> -    // for which it will fail (for example, by including a large number of
> -    // user-data-unregistered messages).
> -    H264_MAX_SEI_PAYLOADS = 64,
> -};
> -
> -
>   typedef struct H264RawNALUnitHeader {
>       uint8_t nal_ref_idc;
>       uint8_t nal_unit_type;
> diff --git a/libavcodec/cbs_h265.h b/libavcodec/cbs_h265.h
> index 738cbeec2c..f7753f1206 100644
> --- a/libavcodec/cbs_h265.h
> +++ b/libavcodec/cbs_h265.h
> @@ -26,15 +26,6 @@
>   #include "cbs_sei.h"
>   #include "hevc.h"
>   
> -enum {
> -    // This limit is arbitrary - it is sufficient for one message of each
> -    // type plus some repeats, and will therefore easily cover all sane
> -    // streams.  However, it is possible to make technically-valid streams
> -    // for which it will fail (for example, by including a large number of
> -    // user-data-unregistered messages).
> -    H265_MAX_SEI_PAYLOADS = 64,
> -};
> -
>   typedef struct H265RawNALUnitHeader {
>       uint8_t nal_unit_type;
>       uint8_t nuh_layer_id;
> 

Yes, LGTM.

Thanks,

- Mark
diff mbox series

Patch

diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h
index 9eb97eae24..5a8641a333 100644
--- a/libavcodec/cbs_h264.h
+++ b/libavcodec/cbs_h264.h
@@ -28,16 +28,6 @@ 
 #include "h264.h"
 
 
-enum {
-    // This limit is arbitrary - it is sufficient for one message of each
-    // type plus some repeats, and will therefore easily cover all sane
-    // streams.  However, it is possible to make technically-valid streams
-    // for which it will fail (for example, by including a large number of
-    // user-data-unregistered messages).
-    H264_MAX_SEI_PAYLOADS = 64,
-};
-
-
 typedef struct H264RawNALUnitHeader {
     uint8_t nal_ref_idc;
     uint8_t nal_unit_type;
diff --git a/libavcodec/cbs_h265.h b/libavcodec/cbs_h265.h
index 738cbeec2c..f7753f1206 100644
--- a/libavcodec/cbs_h265.h
+++ b/libavcodec/cbs_h265.h
@@ -26,15 +26,6 @@ 
 #include "cbs_sei.h"
 #include "hevc.h"
 
-enum {
-    // This limit is arbitrary - it is sufficient for one message of each
-    // type plus some repeats, and will therefore easily cover all sane
-    // streams.  However, it is possible to make technically-valid streams
-    // for which it will fail (for example, by including a large number of
-    // user-data-unregistered messages).
-    H265_MAX_SEI_PAYLOADS = 64,
-};
-
 typedef struct H265RawNALUnitHeader {
     uint8_t nal_unit_type;
     uint8_t nuh_layer_id;