| Context | Check | Description |
|---|---|---|
| andriy/x86 | warning | Failed to apply patch |
On Wed, Dec 2, 2020 at 5:24 AM Andreas Rheinhardt < andreas.rheinhardt@gmail.com> wrote: > Fixes potential heap-buffer-overflow. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavcodec/ass_split.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c > index c2c388d9f0..189272bbd9 100644 > --- a/libavcodec/ass_split.c > +++ b/libavcodec/ass_split.c > @@ -376,7 +376,7 @@ ASSSplitContext *ff_ass_split(const char *buf) > ASSSplitContext *ctx = av_mallocz(sizeof(*ctx)); > if (!ctx) > return NULL; > - if (buf && !memcmp(buf, "\xef\xbb\xbf", 3)) // Skip UTF-8 BOM header > + if (buf && !strncmp(buf, "\xef\xbb\xbf", 3)) // Skip UTF-8 BOM header > buf += 3; > ctx->current_section = -1; > if (ass_split(ctx, buf) < 0) { > -- > 2.25.1 > > Will apply. - Andreas
diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index c2c388d9f0..189272bbd9 100644 --- a/libavcodec/ass_split.c +++ b/libavcodec/ass_split.c @@ -376,7 +376,7 @@ ASSSplitContext *ff_ass_split(const char *buf) ASSSplitContext *ctx = av_mallocz(sizeof(*ctx)); if (!ctx) return NULL; - if (buf && !memcmp(buf, "\xef\xbb\xbf", 3)) // Skip UTF-8 BOM header + if (buf && !strncmp(buf, "\xef\xbb\xbf", 3)) // Skip UTF-8 BOM header buf += 3; ctx->current_section = -1; if (ass_split(ctx, buf) < 0) {
Fixes potential heap-buffer-overflow. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavcodec/ass_split.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)