diff mbox series

[FFmpeg-devel] avformat/adtsenc: clarify option help

Message ID 20210426112249.1617-1-ffmpeg@gyani.pro
State Accepted
Commit 45fc214ebfcdf36b935632edda54aee9e8745550
Headers show
Series [FFmpeg-devel] avformat/adtsenc: clarify option help | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Gyan Doshi April 26, 2021, 11:22 a.m. UTC 
Also remove unnecessary unit as option does not accept any constants.
---
 libavformat/adtsenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gyan Doshi April 26, 2021, 4:16 p.m. UTC | #1 
Will apply tomorrow.

On 2021-04-26 16:52, Gyan Doshi wrote:
> Also remove unnecessary unit as option does not accept any constants.
> ---
>   libavformat/adtsenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c
> index ae1b1b364c..19262784ce 100644
> --- a/libavformat/adtsenc.c
> +++ b/libavformat/adtsenc.c
> @@ -216,7 +216,7 @@ static int adts_write_trailer(AVFormatContext *s)
>   static const AVOption options[] = {
>       { "write_id3v2",  "Enable ID3v2 tag writing", OFFSET(id3v2tag), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, ENC},
>       { "write_apetag", "Enable APE tag writing",   OFFSET(apetag),   AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, ENC},
> -    { "write_mpeg2",  "Use MPE2 ID when writing", OFFSET(mpeg_id),  AV_OPT_TYPE_BOOL,  {.i64 = 0}, 0, 1, ENC, "mpeg_id"},
> +    { "write_mpeg2",  "Set MPEG version to MPEG-2", OFFSET(mpeg_id),  AV_OPT_TYPE_BOOL,  {.i64 = 0}, 0, 1, ENC},
>       { NULL },
>   };
>
Gyan Doshi April 27, 2021, 3:53 a.m. UTC | #2 
On 2021-04-26 21:46, Gyan Doshi wrote:
> Will apply tomorrow.

Pushed as 45fc214ebfcdf36b935632edda54aee9e8745550

Gyan
diff mbox series

Patch

diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c
index ae1b1b364c..19262784ce 100644
--- a/libavformat/adtsenc.c
+++ b/libavformat/adtsenc.c
@@ -216,7 +216,7 @@  static int adts_write_trailer(AVFormatContext *s)
 static const AVOption options[] = {
     { "write_id3v2",  "Enable ID3v2 tag writing", OFFSET(id3v2tag), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, ENC},
     { "write_apetag", "Enable APE tag writing",   OFFSET(apetag),   AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, ENC},
-    { "write_mpeg2",  "Use MPE2 ID when writing", OFFSET(mpeg_id),  AV_OPT_TYPE_BOOL,  {.i64 = 0}, 0, 1, ENC, "mpeg_id"},
+    { "write_mpeg2",  "Set MPEG version to MPEG-2", OFFSET(mpeg_id),  AV_OPT_TYPE_BOOL,  {.i64 = 0}, 0, 1, ENC},
     { NULL },
 };