diff mbox series

[FFmpeg-devel,01/20] avcodec/wma: Remove nonsense volatile

Message ID HE1PR0301MB215439C192FB781466EE7FB98F579@HE1PR0301MB2154.eurprd03.prod.outlook.com
State Accepted
Commit 0bc522a0a1c83894fbf7975e17de19ca34a02ae0
Headers show
Series [FFmpeg-devel,01/20] avcodec/wma: Remove nonsense volatile | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt May 7, 2021, 6:26 a.m. UTC
The address of this variable never leaks, so it cannot be modified
by anyone else at all.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/wma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt May 10, 2021, 8:02 p.m. UTC | #1
Andreas Rheinhardt:
> The address of this variable never leaks, so it cannot be modified
> by anyone else at all.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/wma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/wma.c b/libavcodec/wma.c
> index cfa5fa3355..ee04ef725f 100644
> --- a/libavcodec/wma.c
> +++ b/libavcodec/wma.c
> @@ -79,7 +79,7 @@ av_cold int ff_wma_init(AVCodecContext *avctx, int flags2)
>      WMACodecContext *s = avctx->priv_data;
>      int i, ret;
>      float bps1, high_freq;
> -    volatile float bps;
> +    float bps;
>      int sample_rate1;
>      int coef_vlc_table;
>  
> 
Will apply tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/wma.c b/libavcodec/wma.c
index cfa5fa3355..ee04ef725f 100644
--- a/libavcodec/wma.c
+++ b/libavcodec/wma.c
@@ -79,7 +79,7 @@  av_cold int ff_wma_init(AVCodecContext *avctx, int flags2)
     WMACodecContext *s = avctx->priv_data;
     int i, ret;
     float bps1, high_freq;
-    volatile float bps;
+    float bps;
     int sample_rate1;
     int coef_vlc_table;