diff mbox series

[FFmpeg-devel] configure: msys also has .exe suffix

Message ID 20210612123045.14557-1-timo@rothenpieler.org
State Accepted
Commit abe150c9de6a096b14b6d623c5be49b19afe92b2
Headers show
Series [FFmpeg-devel] configure: msys also has .exe suffix | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Timo Rothenpieler June 12, 2021, 12:30 p.m. UTC
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hendrik Leppkes June 12, 2021, 4:08 p.m. UTC | #1
On Sat, Jun 12, 2021 at 2:31 PM Timo Rothenpieler <timo@rothenpieler.org> wrote:
>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index bdd23479ba..41449eac5f 100755
> --- a/configure
> +++ b/configure
> @@ -4424,7 +4424,7 @@ fi
>
>  exesuf() {
>      case $1 in
> -        mingw32*|mingw64*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
> +        mingw32*|mingw64*|msys*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
>      esac
>  }
>

Technically, you should never be building ffmpeg for msys, its only
designed as a target to build the msys tools itself, anything not
related to the core system should be build using a mingw target.

But I suppose there is no harm in including that.

- Hendrik
Timo Rothenpieler June 12, 2021, 4:22 p.m. UTC | #2
On 12.06.2021 18:08, Hendrik Leppkes wrote:
> On Sat, Jun 12, 2021 at 2:31 PM Timo Rothenpieler <timo@rothenpieler.org> wrote:
>>
>> ---
>>   configure | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index bdd23479ba..41449eac5f 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4424,7 +4424,7 @@ fi
>>
>>   exesuf() {
>>       case $1 in
>> -        mingw32*|mingw64*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
>> +        mingw32*|mingw64*|msys*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
>>       esac
>>   }
>>
> 
> Technically, you should never be building ffmpeg for msys, its only
> designed as a target to build the msys tools itself, anything not
> related to the core system should be build using a mingw target.
> 
> But I suppose there is no harm in including that.

This is mainly an issue when using MSYS as environment to build with MSVC.
diff mbox series

Patch

diff --git a/configure b/configure
index bdd23479ba..41449eac5f 100755
--- a/configure
+++ b/configure
@@ -4424,7 +4424,7 @@  fi
 
 exesuf() {
     case $1 in
-        mingw32*|mingw64*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
+        mingw32*|mingw64*|msys*|win32|win64|cygwin*|*-dos|freedos|opendos|os/2*|symbian) echo .exe ;;
     esac
 }