| Message ID | CAFKHHPmEB50qNgmxqZZNkEGK0v52QfGtpu4YnLaG7mprM3Qp+w@mail.gmail.com |
|---|---|
| State | Accepted |
| Commit | d06518752b84f534acf8cddfe2c228aa1aa07dcf |
| Headers | show |
On 1 January 2017 at 07:52, John Comeau <jc@unternet.net> wrote: > fixes `operation size not specified` errors as described here: > http://stackoverflow.com/questions/36854583/compiling- > ffmpeg-for-kali-linux-2 > > I rebuilt again with yasm and made sure it didn't break that. > -- > John Comeau KE5TFZ jc@unternet.net http://jc.unternet.net/ > "A place for everything, and everything all over the place" > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > Odd, I've been using nasm to build ffmpeg for years now. What version do you use? It sure works on nasm 2.12.01 here.
nasm version 2.11.05, which is current in Debian stable. I could use 2.12.01 from sid, but should that be a requirement? On 1/1/17, Rostislav Pehlivanov <atomnuker@gmail.com> wrote: > On 1 January 2017 at 07:52, John Comeau <jc@unternet.net> wrote: > >> fixes `operation size not specified` errors as described here: >> http://stackoverflow.com/questions/36854583/compiling- >> ffmpeg-for-kali-linux-2 >> >> I rebuilt again with yasm and made sure it didn't break that. >> -- >> John Comeau KE5TFZ jc@unternet.net http://jc.unternet.net/ >> "A place for everything, and everything all over the place" >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > Odd, I've been using nasm to build ffmpeg for years now. > What version do you use? It sure works on nasm 2.12.01 here. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
2017-01-01 17:02 GMT+01:00 John Comeau <jc@unternet.net>: > nasm version 2.11.05, which is current in Debian stable. I could use > 2.12.01 from sid, but should that be a requirement? I thought 2.11 has more issues with FFmpeg, or was that only on osx? Please avoid top-posting here, Carl Eugen
On Sun, Jan 1, 2017 at 11:08 AM, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > 2017-01-01 17:02 GMT+01:00 John Comeau <jc@unternet.net>: >> nasm version 2.11.05, which is current in Debian stable. I could use >> 2.12.01 from sid, but should that be a requirement? > > I thought 2.11 has more issues with FFmpeg, or was that only on osx? > > Please avoid top-posting here, Carl Eugen sorry about the top-posting, I haven't used a listserv for so long I'd forgotten the etiquette. there were no other errors after fixing those 3 lines. whether or not it actually built correctly I can't say. I didn't run `make check` after the nasm build, and on my slow netbook I don't want to do it over again and waste a few more hours. I have no emotional attachment to the patches I submitted, so feel free to ignore. my fork is up on github if anybody wants to take a look. I'm unsubscribing for now, so if there's any more commentary on this or my Floureon ipcam patch, please CC me. thanks -- jc
On Sun, Jan 01, 2017 at 08:16:00AM +0000, Rostislav Pehlivanov wrote: > On 1 January 2017 at 07:52, John Comeau <jc@unternet.net> wrote: > > > fixes `operation size not specified` errors as described here: > > http://stackoverflow.com/questions/36854583/compiling- > > ffmpeg-for-kali-linux-2 > > > > I rebuilt again with yasm and made sure it didn't break that. > > -- > > John Comeau KE5TFZ jc@unternet.net http://jc.unternet.net/ > > "A place for everything, and everything all over the place" > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > Odd, I've been using nasm to build ffmpeg for years now. > What version do you use? It sure works on nasm 2.12.01 here. do you see a disadvantage in the change by the patch ? if not, then i think it should be applied as it seems improving support for some nasm version be that the only issue or one of several [...]
Hi, On Sun, Jan 1, 2017 at 8:36 PM, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Sun, Jan 01, 2017 at 08:16:00AM +0000, Rostislav Pehlivanov wrote: > > On 1 January 2017 at 07:52, John Comeau <jc@unternet.net> wrote: > > > > > fixes `operation size not specified` errors as described here: > > > http://stackoverflow.com/questions/36854583/compiling- > > > ffmpeg-for-kali-linux-2 > > > > > > I rebuilt again with yasm and made sure it didn't break that. > > > -- > > > John Comeau KE5TFZ jc@unternet.net http://jc.unternet.net/ > > > "A place for everything, and everything all over the place" > > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > Odd, I've been using nasm to build ffmpeg for years now. > > What version do you use? It sure works on nasm 2.12.01 here. > > do you see a disadvantage in the change by the patch ? > if not, then i think it should be applied as it seems improving > support for some nasm version be that the only issue or one of > several I think it's fine to merge. Ronald
On Mon, Jan 02, 2017 at 10:54:18AM -0500, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 1, 2017 at 8:36 PM, Michael Niedermayer <michael@niedermayer.cc> > wrote: > > > On Sun, Jan 01, 2017 at 08:16:00AM +0000, Rostislav Pehlivanov wrote: > > > On 1 January 2017 at 07:52, John Comeau <jc@unternet.net> wrote: > > > > > > > fixes `operation size not specified` errors as described here: > > > > http://stackoverflow.com/questions/36854583/compiling- > > > > ffmpeg-for-kali-linux-2 > > > > > > > > I rebuilt again with yasm and made sure it didn't break that. > > > > -- > > > > John Comeau KE5TFZ jc@unternet.net http://jc.unternet.net/ > > > > "A place for everything, and everything all over the place" > > > > > > > > _______________________________________________ > > > > ffmpeg-devel mailing list > > > > ffmpeg-devel@ffmpeg.org > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > > > > Odd, I've been using nasm to build ffmpeg for years now. > > > What version do you use? It sure works on nasm 2.12.01 here. > > > > do you see a disadvantage in the change by the patch ? > > if not, then i think it should be applied as it seems improving > > support for some nasm version be that the only issue or one of > > several > > > I think it's fine to merge. applied thx [...]
diff --git a/libavcodec/x86/imdct36.asm b/libavcodec/x86/imdct36.asm index 409b2c5796..960eabdda5 100644 --- a/libavcodec/x86/imdct36.asm +++ b/libavcodec/x86/imdct36.asm @@ -145,9 +145,9 @@ SECTION .text %macro STORE 4 %if cpuflag(sse4) movss [%3 ], %1 - extractps [%3 + %4], %1, 1 - extractps [%3 + 2*%4], %1, 2 - extractps [%3 + 3*%4], %1, 3 + extractps dword [%3 + %4], %1, 1 + extractps dword [%3 + 2*%4], %1, 2 + extractps dword [%3 + 3*%4], %1, 3 %else movhlps %2, %1 movss [%3 ], %1