diff mbox series

[FFmpeg-devel,01/11] avcodec/bsf: ff_list_bsf static

Message ID AM7PR03MB6660515048D7368B9CB9F7818FD29@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 97bc4695fb7a51574d863812af58ab63746558fd
Headers show
Series [FFmpeg-devel,01/11] avcodec/bsf: ff_list_bsf static | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 6, 2021, 12:41 p.m. UTC 
It is a special BSF that is only available via the av_bsf_list-API;
it is not part of the list generated from the declarations in
bitstream_filters.c and therefore needn't have external linkage.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/bsf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Andreas Rheinhardt Sept. 8, 2021, 12:32 p.m. UTC | #1 
Andreas Rheinhardt:
> It is a special BSF that is only available via the av_bsf_list-API;
> it is not part of the list generated from the declarations in
> bitstream_filters.c and therefore needn't have external linkage.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/bsf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
> index 57034ce646..d9c8395260 100644
> --- a/libavcodec/bsf.c
> +++ b/libavcodec/bsf.c
> @@ -394,7 +394,7 @@ static const AVClass bsf_list_class = {
>          .version    = LIBAVUTIL_VERSION_INT,
>  };
>  
> -const AVBitStreamFilter ff_list_bsf = {
> +static const AVBitStreamFilter list_bsf = {
>          .name           = "bsf_list",
>          .priv_data_size = sizeof(BSFListContext),
>          .priv_class     = &bsf_list_class,
> @@ -490,7 +490,7 @@ int av_bsf_list_finalize(AVBSFList **lst, AVBSFContext **bsf)
>          goto end;
>      }
>  
> -    ret = av_bsf_alloc(&ff_list_bsf, bsf);
> +    ret = av_bsf_alloc(&list_bsf, bsf);
>      if (ret < 0)
>          return ret;
>  
> @@ -544,5 +544,5 @@ end:
>  
>  int av_bsf_get_null_filter(AVBSFContext **bsf)
>  {
> -    return av_bsf_alloc(&ff_list_bsf, bsf);
> +    return av_bsf_alloc(&list_bsf, bsf);
>  }
> 
Will apply this patchset later tonight.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
index 57034ce646..d9c8395260 100644
--- a/libavcodec/bsf.c
+++ b/libavcodec/bsf.c
@@ -394,7 +394,7 @@  static const AVClass bsf_list_class = {
         .version    = LIBAVUTIL_VERSION_INT,
 };
 
-const AVBitStreamFilter ff_list_bsf = {
+static const AVBitStreamFilter list_bsf = {
         .name           = "bsf_list",
         .priv_data_size = sizeof(BSFListContext),
         .priv_class     = &bsf_list_class,
@@ -490,7 +490,7 @@  int av_bsf_list_finalize(AVBSFList **lst, AVBSFContext **bsf)
         goto end;
     }
 
-    ret = av_bsf_alloc(&ff_list_bsf, bsf);
+    ret = av_bsf_alloc(&list_bsf, bsf);
     if (ret < 0)
         return ret;
 
@@ -544,5 +544,5 @@  end:
 
 int av_bsf_get_null_filter(AVBSFContext **bsf)
 {
-    return av_bsf_alloc(&ff_list_bsf, bsf);
+    return av_bsf_alloc(&list_bsf, bsf);
 }