diff mbox series

[FFmpeg-devel,14/14] fftools/ffprobe: Don't access AVProgram.(start|end)_time

Message ID PR3PR03MB6665DB6A9C657B29F392D10B8FD59@PR3PR03MB6665.eurprd03.prod.outlook.com
State Superseded
Headers show
Series [FFmpeg-devel,01/14] Revert "avfilter/af_silenceremove: fix processing of periods > 1" | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 9, 2021, 3:57 p.m. UTC 
These are internal fields.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
show_program() is only entered by three tests: mpegts-probe-pmt-merge,
mpegts-probe-program and mpegts-probe-latm. Even mpegts-probe-latm does
not print detailed information about programs, hence the lack of
FATE-updates.

 fftools/ffprobe.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Tobias Rapp Sept. 10, 2021, 12:23 p.m. UTC | #1 
On 09.09.2021 17:57, Andreas Rheinhardt wrote:
> These are internal fields.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> show_program() is only entered by three tests: mpegts-probe-pmt-merge,
> mpegts-probe-program and mpegts-probe-latm. Even mpegts-probe-latm does
> not print detailed information about programs, hence the lack of
> FATE-updates.
> 
>   fftools/ffprobe.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index acfec09656..d8e968321e 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2844,10 +2844,6 @@ static int show_program(WriterContext *w, InputFile *ifile, AVProgram *program)
>       print_int("nb_streams", program->nb_stream_indexes);
>       print_int("pmt_pid", program->pmt_pid);
>       print_int("pcr_pid", program->pcr_pid);
> -    print_ts("start_pts", program->start_time);
> -    print_time("start_time", program->start_time, &AV_TIME_BASE_Q);
> -    print_ts("end_pts", program->end_time);
> -    print_time("end_time", program->end_time, &AV_TIME_BASE_Q);
>       if (do_show_program_tags)
>           ret = show_tags(w, program->metadata, SECTION_ID_PROGRAM_TAGS);
>       if (ret < 0)
> 

The "program" element type definition in doc/ffprobe.xsd should be 
adjusted accordingly.

Regards,
Tobias
diff mbox series

Patch

diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index acfec09656..d8e968321e 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2844,10 +2844,6 @@  static int show_program(WriterContext *w, InputFile *ifile, AVProgram *program)
     print_int("nb_streams", program->nb_stream_indexes);
     print_int("pmt_pid", program->pmt_pid);
     print_int("pcr_pid", program->pcr_pid);
-    print_ts("start_pts", program->start_time);
-    print_time("start_time", program->start_time, &AV_TIME_BASE_Q);
-    print_ts("end_pts", program->end_time);
-    print_time("end_time", program->end_time, &AV_TIME_BASE_Q);
     if (do_show_program_tags)
         ret = show_tags(w, program->metadata, SECTION_ID_PROGRAM_TAGS);
     if (ret < 0)