diff mbox series

[FFmpeg-devel,25/26] avfilter/vf_xfade: Remove always-false format check

Message ID AM7PR03MB6660ECCCBB390827AEFEE0988FA19@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 04a5ffa75fdbee4c1622d49185b057d564a155e1
Headers show
Series [FFmpeg-devel,01/26] avfilter/af_afade: Remove redundant checks and assignments | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 21, 2021, 6:27 a.m. UTC 
This filter uses ff_set_common_formats_from_list().

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_xfade.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Paul B Mahol Sept. 21, 2021, 6:51 a.m. UTC | #1 
lgtm
diff mbox series

Patch

diff --git a/libavfilter/vf_xfade.c b/libavfilter/vf_xfade.c
index eff8a8b854..b4edcbf1b4 100644
--- a/libavfilter/vf_xfade.c
+++ b/libavfilter/vf_xfade.c
@@ -1717,10 +1717,6 @@  static int config_output(AVFilterLink *outlink)
     XFadeContext *s = ctx->priv;
     const AVPixFmtDescriptor *pix_desc = av_pix_fmt_desc_get(inlink0->format);
 
-    if (inlink0->format != inlink1->format) {
-        av_log(ctx, AV_LOG_ERROR, "inputs must be of same pixel format\n");
-        return AVERROR(EINVAL);
-    }
     if (inlink0->w != inlink1->w || inlink0->h != inlink1->h) {
         av_log(ctx, AV_LOG_ERROR, "First input link %s parameters "
                "(size %dx%d) do not match the corresponding "