| Message ID | 20211117030415.81482-1-jianhua.wu@intel.com |
|---|---|
| State | Accepted |
| Commit | e95969c07e9eb83bacf7ffebbdbe2687879bf5b1 |
| Headers | show |
| Series | [FFmpeg-devel] avfilter/gblur_vulkan: fix memory leak | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | success | Make fate finished |
17 Nov 2021, 04:04 by jianhua.wu@intel.com: > Whether failed or not, the block of codes labeled with fail should > be always run to ensure the av_free(kernel_def) is executed. > > Signed-off-by: Wu Jianhua <jianhua.wu@intel.com> > --- > libavfilter/vf_gblur_vulkan.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c > index b9e2c4fbc7..d4f391b25d 100644 > --- a/libavfilter/vf_gblur_vulkan.c > +++ b/libavfilter/vf_gblur_vulkan.c > @@ -296,8 +296,6 @@ static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in) > > s->initialized = 1; > > - return 0; > - > fail: > av_free(kernel_def); > return err; > Pushed, thanks.
diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c index b9e2c4fbc7..d4f391b25d 100644 --- a/libavfilter/vf_gblur_vulkan.c +++ b/libavfilter/vf_gblur_vulkan.c @@ -296,8 +296,6 @@ static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in) s->initialized = 1; - return 0; - fail: av_free(kernel_def); return err;
Whether failed or not, the block of codes labeled with fail should be always run to ensure the av_free(kernel_def) is executed. Signed-off-by: Wu Jianhua <jianhua.wu@intel.com> --- libavfilter/vf_gblur_vulkan.c | 2 -- 1 file changed, 2 deletions(-)