diff mbox series

[FFmpeg-devel,1/2] libavcodec/videotoolboxenc: use the correct types for options

Message ID 20211218215319.84070-1-rcombs@rcombs.me
State Accepted
Commit 802c0515067fa3f5a67feb56241789dfcfb1ad09
Headers show
Series [FFmpeg-devel,1/2] libavcodec/videotoolboxenc: use the correct types for options | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

rcombs Dec. 18, 2021, 9:53 p.m. UTC
These are all set by AV_OPT_TYPE_INT or AV_OPT_TYPE_BOOL; the only reason
they worked before was that this is only used on little-endian.
---
 libavcodec/videotoolboxenc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Aman Karmani Dec. 19, 2021, 4:37 p.m. UTC | #1
On Sat, Dec 18, 2021 at 1:53 PM rcombs <rcombs@rcombs.me> wrote:

> These are all set by AV_OPT_TYPE_INT or AV_OPT_TYPE_BOOL; the only reason
> they worked before was that this is only used on little-endian.
> ---
>  libavcodec/videotoolboxenc.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 8237bd0ec5..5f1e3a9b9c 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -227,14 +227,14 @@ typedef struct VTEncContext {
>      int64_t dts_delta;
>
>      int64_t profile;
> -    int64_t level;
> -    int64_t entropy;
> -    int64_t realtime;
> -    int64_t frames_before;
> -    int64_t frames_after;
> -
> -    int64_t allow_sw;
> -    int64_t require_sw;
> +    int level;
> +    int entropy;
> +    int realtime;
> +    int frames_before;
> +    int frames_after;
> +
> +    int allow_sw;
> +    int require_sw;


LGTM


>      double alpha_quality;
>
>      bool flushing;
> --
> 2.33.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 8237bd0ec5..5f1e3a9b9c 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -227,14 +227,14 @@  typedef struct VTEncContext {
     int64_t dts_delta;
 
     int64_t profile;
-    int64_t level;
-    int64_t entropy;
-    int64_t realtime;
-    int64_t frames_before;
-    int64_t frames_after;
-
-    int64_t allow_sw;
-    int64_t require_sw;
+    int level;
+    int entropy;
+    int realtime;
+    int frames_before;
+    int frames_after;
+
+    int allow_sw;
+    int require_sw;
     double alpha_quality;
 
     bool flushing;