| Message ID | MrMKbOp--3-2@lynne.ee |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] configure: autodetect vulkan | expand |
| Context | Check | Description |
|---|---|---|
| andriy/configure_x86 | warning | Failed to run configure |
| andriy/configure_ppc | warning | Failed to run configure |
Quoting Lynne (2021-12-20 11:15:08) > Recently, Metal support was merged, which is autodetected > by default. Metal doesn't even have a hwcontext and it's not > a hwaccel, nor would it likely ever be one as Apple won't drop > videotoolbox. > > To keep it fair, autodetect Vulkan, which is a hwcontext, > and for which there is an unmerged hwaccel patch. vaapi and vdpau seem to be autodetected, so sure why not
On Mon, Dec 20, 2021 at 11:15 AM Lynne <dev@lynne.ee> wrote: > > Recently, Metal support was merged, which is autodetected > by default. Metal doesn't even have a hwcontext and it's not > a hwaccel, nor would it likely ever be one as Apple won't drop > videotoolbox. > > To keep it fair, autodetect Vulkan, which is a hwcontext, > and for which there is an unmerged hwaccel patch. > "fair"? what kind of argument is that? Is there a big hw competition on? Not that i'm against the change, but please argue on technical merits, not some nonsense. - Hendrik
On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote: > Recently, Metal support was merged, which is autodetected > by default. Metal doesn't even have a hwcontext and it's not > a hwaccel, nor would it likely ever be one as Apple won't drop > videotoolbox. > > To keep it fair, autodetect Vulkan, which is a hwcontext, > and for which there is an unmerged hwaccel patch. > > Patch attached. > > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 09c6bfd367bd2ac897abc5716e2e9605341036cd 0001-configure-autodetect-vulkan.patch > From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001 > From: Lynne <dev@lynne.ee> > Date: Mon, 20 Dec 2021 11:04:49 +0100 > Subject: [PATCH] configure: autodetect vulkan breaks build here on ubuntu ./configure ERROR: defined VK_VERSION_1_2 not satisfied If you think configure made a mistake, make sure you are using the latest version from Git. If the latest version fails, report the problem to the ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat. Include the log file "ffbuild/config.log" produced by configure as this will help solve the problem. [....]
20 Dec 2021, 17:59 by michael@niedermayer.cc: > On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote: > >> Recently, Metal support was merged, which is autodetected >> by default. Metal doesn't even have a hwcontext and it's not >> a hwaccel, nor would it likely ever be one as Apple won't drop >> videotoolbox. >> >> To keep it fair, autodetect Vulkan, which is a hwcontext, >> and for which there is an unmerged hwaccel patch. >> >> Patch attached. >> >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> 09c6bfd367bd2ac897abc5716e2e9605341036cd 0001-configure-autodetect-vulkan.patch >> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001 >> From: Lynne <dev@lynne.ee> >> Date: Mon, 20 Dec 2021 11:04:49 +0100 >> Subject: [PATCH] configure: autodetect vulkan >> > > breaks build here on ubuntu > > ./configure > ERROR: defined VK_VERSION_1_2 not satisfied > > If you think configure made a mistake, make sure you are using the latest > version from Git. If the latest version fails, report the problem to the > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat. > Include the log file "ffbuild/config.log" produced by configure as this will help > solve the problem. > Thanks for testing, V2 attached, just changes require_cpp to check_cpp, since autodetecting is not a hard-require unlike enabling libraries.
On Mon, Dec 20, 2021 at 06:45:43PM +0100, Lynne wrote: > 20 Dec 2021, 17:59 by michael@niedermayer.cc: > > > On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote: > > > >> Recently, Metal support was merged, which is autodetected > >> by default. Metal doesn't even have a hwcontext and it's not > >> a hwaccel, nor would it likely ever be one as Apple won't drop > >> videotoolbox. > >> > >> To keep it fair, autodetect Vulkan, which is a hwcontext, > >> and for which there is an unmerged hwaccel patch. > >> > >> Patch attached. > >> > >> configure | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> 09c6bfd367bd2ac897abc5716e2e9605341036cd 0001-configure-autodetect-vulkan.patch > >> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001 > >> From: Lynne <dev@lynne.ee> > >> Date: Mon, 20 Dec 2021 11:04:49 +0100 > >> Subject: [PATCH] configure: autodetect vulkan > >> > > > > breaks build here on ubuntu > > > > ./configure > > ERROR: defined VK_VERSION_1_2 not satisfied > > > > If you think configure made a mistake, make sure you are using the latest > > version from Git. If the latest version fails, report the problem to the > > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat. > > Include the log file "ffbuild/config.log" produced by configure as this will help > > solve the problem. > > > > Thanks for testing, V2 attached, just changes require_cpp to check_cpp, > since autodetecting is not a hard-require unlike enabling libraries. that fixes the issue thx [...]
> On Dec 21, 2021, at 1:45 AM, Lynne <dev@lynne.ee> wrote: > > > Thanks for testing, V2 attached, just changes require_cpp to check_cpp, > since autodetecting is not a hard-require unlike enabling libraries. > diff --git a/configure b/configure > index d8b07c8e00..3be4de61e0 100755 > --- a/configure > +++ b/configure > @@ -324,7 +324,7 @@ external library support: > --disable-securetransport disable secure transport, needed for tls support > on osx if openssl and gnutls are not used [autodetect] > --enable-vapoursynth enable vapoursynth demuxer [no] > - --enable-vulkan enable vulkan code [no] > + --disable-vulkan enable vulkan code [autodetect] 'enable vulkan code’ —> ‘disable vulkan code' > > <v2-0001-configure-autodetect-vulkan.patch>_______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
21 Dec 2021, 08:05 by quinkblack@foxmail.com: > > >> On Dec 21, 2021, at 1:45 AM, Lynne <dev@lynne.ee> wrote: >> >> >> Thanks for testing, V2 attached, just changes require_cpp to check_cpp, >> since autodetecting is not a hard-require unlike enabling libraries. >> > > >> diff --git a/configure b/configure >> index d8b07c8e00..3be4de61e0 100755 >> --- a/configure >> +++ b/configure >> @@ -324,7 +324,7 @@ external library support: >> --disable-securetransport disable secure transport, needed for tls support >> on osx if openssl and gnutls are not used [autodetect] >> --enable-vapoursynth enable vapoursynth demuxer [no] >> - --enable-vulkan enable vulkan code [no] >> + --disable-vulkan enable vulkan code [autodetect] >> > > 'enable vulkan code’ —> ‘disable vulkan code' > Changed, and applied, thanks to the review.
diff --git a/configure b/configure index d8b07c8e00..5b6e578253 100755 --- a/configure +++ b/configure @@ -324,7 +324,7 @@ External library support: --disable-securetransport disable Secure Transport, needed for TLS support on OSX if openssl and gnutls are not used [autodetect] --enable-vapoursynth enable VapourSynth demuxer [no] - --enable-vulkan enable Vulkan code [no] + --disable-vulkan enable Vulkan code [autodetect] --disable-xlib disable xlib [autodetect] --disable-zlib disable zlib [autodetect] @@ -1896,6 +1896,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST=" vaapi vdpau videotoolbox + vulkan v4l2_m2m xvmc " @@ -1918,7 +1919,6 @@ HWACCEL_LIBRARY_LIST=" mmal omx opencl - vulkan " DOCUMENT_LIST="