diff mbox series

[FFmpeg-devel] lavc/qsvdec: needn't free the string for AV_OPT_TYPE_STRING AVOption

Message ID 20210129005432.13307-1-haihao.xiang@intel.com
State New
Headers show
Series [FFmpeg-devel] lavc/qsvdec: needn't free the string for AV_OPT_TYPE_STRING AVOption | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Xiang, Haihao Jan. 29, 2021, 12:54 a.m. UTC
The string for AV_OPT_TYPE_STRING AVOption gets freed by av_opt_free()
when closing the AVCodecContext

Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
 libavcodec/qsvdec.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Xiang, Haihao Dec. 29, 2021, 5:40 a.m. UTC | #1
On Fri, 2021-01-29 at 08:54 +0800, Haihao Xiang wrote:
> The string for AV_OPT_TYPE_STRING AVOption gets freed by av_opt_free()
> when closing the AVCodecContext
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  libavcodec/qsvdec.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
> index d10f90a0db..2d4f72b3f6 100644
> --- a/libavcodec/qsvdec.c
> +++ b/libavcodec/qsvdec.c
> @@ -667,8 +667,6 @@ static av_cold int qsv_decode_close(AVCodecContext *avctx)
>  {
>      QSVDecContext *s = avctx->priv_data;
>  
> -    av_freep(&s->qsv.load_plugins);
> -
>      ff_qsv_decode_close(&s->qsv);
>  
>      qsv_clear_buffers(s);

Will apply.

-Haihao
diff mbox series

Patch

diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
index d10f90a0db..2d4f72b3f6 100644
--- a/libavcodec/qsvdec.c
+++ b/libavcodec/qsvdec.c
@@ -667,8 +667,6 @@  static av_cold int qsv_decode_close(AVCodecContext *avctx)
 {
     QSVDecContext *s = avctx->priv_data;
 
-    av_freep(&s->qsv.load_plugins);
-
     ff_qsv_decode_close(&s->qsv);
 
     qsv_clear_buffers(s);