| Message ID | 20211231105307.30946-6-anton@khirnov.net |
|---|---|
| State | Accepted |
| Commit | 53f513c60b460f3597c831e41e455c40a2862920 |
| Headers | show |
| Series | [FFmpeg-devel,1/7] lavc/flac_parser: use a custom FIFO implementation | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | fail | Make fate failed |
Anton Khirnov: > This object was never intended to be thread-safe, so these carry no > useful information. > --- > libavutil/fifo.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavutil/fifo.c b/libavutil/fifo.c > index 171c1aa9cd..f38e8ff089 100644 > --- a/libavutil/fifo.c > +++ b/libavutil/fifo.c > @@ -144,7 +144,6 @@ int av_fifo_generic_write(AVFifoBuffer *f, void *src, int size, > memcpy(wptr, src, len); > src = (uint8_t *)src + len; > } > -// Write memory barrier needed for SMP here in theory > wptr += len; > if (wptr >= f->end) > wptr = f->buffer; > @@ -197,7 +196,6 @@ int av_fifo_generic_peek_at(AVFifoBuffer *f, void *dest, int offset, int buf_siz > int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > void (*func)(void *, void *, int)) > { > -// Read memory barrier needed for SMP here in theory > uint8_t *rptr = f->rptr; > > do { > @@ -208,7 +206,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > memcpy(dest, rptr, len); > dest = (uint8_t *)dest + len; > } > -// memory barrier needed for SMP here in theory > rptr += len; > if (rptr >= f->end) > rptr -= f->end - f->buffer; > @@ -221,7 +218,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, > void (*func)(void *, void *, int)) > { > -// Read memory barrier needed for SMP here in theory > do { > int len = FFMIN(f->end - f->rptr, buf_size); > if (func) > @@ -230,7 +226,6 @@ int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, > memcpy(dest, f->rptr, len); > dest = (uint8_t *)dest + len; > } > -// memory barrier needed for SMP here in theory > av_fifo_drain(f, len); > buf_size -= len; > } while (buf_size > 0); > LGTM. - Andreas
diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 171c1aa9cd..f38e8ff089 100644 --- a/libavutil/fifo.c +++ b/libavutil/fifo.c @@ -144,7 +144,6 @@ int av_fifo_generic_write(AVFifoBuffer *f, void *src, int size, memcpy(wptr, src, len); src = (uint8_t *)src + len; } -// Write memory barrier needed for SMP here in theory wptr += len; if (wptr >= f->end) wptr = f->buffer; @@ -197,7 +196,6 @@ int av_fifo_generic_peek_at(AVFifoBuffer *f, void *dest, int offset, int buf_siz int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, void (*func)(void *, void *, int)) { -// Read memory barrier needed for SMP here in theory uint8_t *rptr = f->rptr; do { @@ -208,7 +206,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, memcpy(dest, rptr, len); dest = (uint8_t *)dest + len; } -// memory barrier needed for SMP here in theory rptr += len; if (rptr >= f->end) rptr -= f->end - f->buffer; @@ -221,7 +218,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, void (*func)(void *, void *, int)) { -// Read memory barrier needed for SMP here in theory do { int len = FFMIN(f->end - f->rptr, buf_size); if (func) @@ -230,7 +226,6 @@ int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, memcpy(dest, f->rptr, len); dest = (uint8_t *)dest + len; } -// memory barrier needed for SMP here in theory av_fifo_drain(f, len); buf_size -= len; } while (buf_size > 0);