diff mbox series

[FFmpeg-devel] fftools/ffmpeg: fix (a)buffer src names

Message ID 20220121081515.14847-1-anton@khirnov.net
State Accepted
Commit e85958ece84a8d3a6390f50ac2690addf28a082e
Headers show
Series [FFmpeg-devel] fftools/ffmpeg: fix (a)buffer src names | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc fail Make fate failed
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished

Commit Message

Anton Khirnov Jan. 21, 2022, 8:15 a.m. UTC
---
Grmbl, could have sworn I tested this
---
 fftools/ffmpeg_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

James Almer Jan. 21, 2022, 12:05 p.m. UTC | #1
On 1/21/2022 5:15 AM, Anton Khirnov wrote:
> ---
> Grmbl, could have sworn I tested this
> ---
>   fftools/ffmpeg_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
> index 1f6cba2c04..7b6fcc36de 100644
> --- a/fftools/ffmpeg_filter.c
> +++ b/fftools/ffmpeg_filter.c
> @@ -949,8 +949,8 @@ static void cleanup_filtergraph(FilterGraph *fg)
>   static int filter_is_buffersrc(const AVFilterContext *f)
>   {
>       return f->nb_inputs == 0 &&
> -           (!strcmp(f->filter->name, "buffersrc") ||
> -            !strcmp(f->filter->name, "abuffersrc"));
> +           (!strcmp(f->filter->name, "buffer") ||
> +            !strcmp(f->filter->name, "abuffer"));

Curious no fate test was affected by this. I see gcov shows this 
function is called a bunch of times.

LGTM.

>   }
>   
>   static int graph_is_meta(AVFilterGraph *graph)
diff mbox series

Patch

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 1f6cba2c04..7b6fcc36de 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -949,8 +949,8 @@  static void cleanup_filtergraph(FilterGraph *fg)
 static int filter_is_buffersrc(const AVFilterContext *f)
 {
     return f->nb_inputs == 0 &&
-           (!strcmp(f->filter->name, "buffersrc") ||
-            !strcmp(f->filter->name, "abuffersrc"));
+           (!strcmp(f->filter->name, "buffer") ||
+            !strcmp(f->filter->name, "abuffer"));
 }
 
 static int graph_is_meta(AVFilterGraph *graph)